* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
[not found] <1728C9EC4C3A35F2.13174@lists.yoctoproject.org>
@ 2022-12-07 22:23 ` Denys Dmytriyenko
2022-12-07 22:34 ` Ryan Eatmon
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2022-12-07 22:23 UTC (permalink / raw)
To: meta-ti
Ping?
On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
>
> Replace "require" with "include" to load ti-paths.inc and not break
> parsing when meta-ti-extras is not in the BBLAYERS list.
>
> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> the soft dependency will still work fine and give a build error
> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
>
> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
> d.getVar() to access it ensuring it doesn't break the condition.
>
> Reported-by: Daniel Díaz <mrchapp@gmail.com>
> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> index e89a6855..c99cd660 100644
> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> @@ -1,5 +1,5 @@
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> -require recipes-ti/includes/ti-paths.inc
> +include recipes-ti/includes/ti-paths.inc
>
> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native virtual/bootloader"
> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or '${TI_K3_SECDEV_INSTALL_DIR}' }"
> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
> export TI_SECURE_DEV_PKG
>
> SYSFW_SOC ?= "unknown"
> --
> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-07 22:23 ` [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft Denys Dmytriyenko
@ 2022-12-07 22:34 ` Ryan Eatmon
2022-12-07 22:39 ` Daniel Díaz
0 siblings, 1 reply; 7+ messages in thread
From: Ryan Eatmon @ 2022-12-07 22:34 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-ti
I literally merged this out to master about 30mins ago.
On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
> Ping?
>
>
> On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
>> From: Denys Dmytriyenko <denys@konsulko.com>
>>
>> Replace "require" with "include" to load ti-paths.inc and not break
>> parsing when meta-ti-extras is not in the BBLAYERS list.
>>
>> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
>> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
>> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
>> the soft dependency will still work fine and give a build error
>> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
>>
>> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
>> d.getVar() to access it ensuring it doesn't break the condition.
>>
>> Reported-by: Daniel Díaz <mrchapp@gmail.com>
>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
>> ---
>> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>> index e89a6855..c99cd660 100644
>> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>> @@ -1,5 +1,5 @@
>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>> -require recipes-ti/includes/ti-paths.inc
>> +include recipes-ti/includes/ti-paths.inc
>>
>> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native virtual/bootloader"
>> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
>> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
>>
>> PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or '${TI_K3_SECDEV_INSTALL_DIR}' }"
>> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
>> export TI_SECURE_DEV_PKG
>>
>> SYSFW_SOC ?= "unknown"
>> --
>> 2.25.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#15429): https://lists.yoctoproject.org/g/meta-ti/message/15429
>> Mute This Topic: https://lists.yoctoproject.org/mt/95121729/6551054
>> Group Owner: meta-ti+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-07 22:34 ` Ryan Eatmon
@ 2022-12-07 22:39 ` Daniel Díaz
2022-12-07 22:42 ` Ryan Eatmon
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Díaz @ 2022-12-07 22:39 UTC (permalink / raw)
To: reatmon; +Cc: Denys Dmytriyenko, meta-ti
Hello!
On Wed, Dec 7, 2022 at 4:34 PM Ryan Eatmon via lists.yoctoproject.org
<reatmon=ti.com@lists.yoctoproject.org> wrote:
> I literally merged this out to master about 30mins ago.
We can this be expected to land on Kirkstone?
Thanks and greetings!
Daniel Díaz
yosoy@danieldiaz.org
> On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
> > Ping?
> >
> >
> > On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
> >> From: Denys Dmytriyenko <denys@konsulko.com>
> >>
> >> Replace "require" with "include" to load ti-paths.inc and not break
> >> parsing when meta-ti-extras is not in the BBLAYERS list.
> >>
> >> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> >> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> >> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> >> the soft dependency will still work fine and give a build error
> >> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
> >>
> >> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
> >> d.getVar() to access it ensuring it doesn't break the condition.
> >>
> >> Reported-by: Daniel Díaz <mrchapp@gmail.com>
> >> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >> ---
> >> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >> index e89a6855..c99cd660 100644
> >> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >> @@ -1,5 +1,5 @@
> >> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> >> -require recipes-ti/includes/ti-paths.inc
> >> +include recipes-ti/includes/ti-paths.inc
> >>
> >> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native virtual/bootloader"
> >> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
> >> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
> >>
> >> PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>
> >> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or '${TI_K3_SECDEV_INSTALL_DIR}' }"
> >> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
> >> export TI_SECURE_DEV_PKG
> >>
> >> SYSFW_SOC ?= "unknown"
> >> --
> >> 2.25.1
> >>
> >>
> >>
> >>
>
> --
> Ryan Eatmon reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc. - LCPD - MGTS
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15430): https://lists.yoctoproject.org/g/meta-ti/message/15430
> Mute This Topic: https://lists.yoctoproject.org/mt/95121729/1051867
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [mrchapp@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-07 22:39 ` Daniel Díaz
@ 2022-12-07 22:42 ` Ryan Eatmon
2022-12-12 12:19 ` Jose Quaresma
0 siblings, 1 reply; 7+ messages in thread
From: Ryan Eatmon @ 2022-12-07 22:42 UTC (permalink / raw)
To: Daniel Díaz; +Cc: Denys Dmytriyenko, meta-ti
The test builds for this are running right now. I would expect that I
can merge it over to kirkstone tomorrow morning sometime.
On 12/7/2022 4:39 PM, Daniel Díaz wrote:
> Hello!
>
> On Wed, Dec 7, 2022 at 4:34 PM Ryan Eatmon via lists.yoctoproject.org
> <reatmon=ti.com@lists.yoctoproject.org> wrote:
>> I literally merged this out to master about 30mins ago.
>
> We can this be expected to land on Kirkstone?
>
> Thanks and greetings!
>
> Daniel Díaz
> yosoy@danieldiaz.org
>
>
>
>> On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
>>> Ping?
>>>
>>>
>>> On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
>>>> From: Denys Dmytriyenko <denys@konsulko.com>
>>>>
>>>> Replace "require" with "include" to load ti-paths.inc and not break
>>>> parsing when meta-ti-extras is not in the BBLAYERS list.
>>>>
>>>> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
>>>> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
>>>> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
>>>> the soft dependency will still work fine and give a build error
>>>> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
>>>>
>>>> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
>>>> d.getVar() to access it ensuring it doesn't break the condition.
>>>>
>>>> Reported-by: Daniel Díaz <mrchapp@gmail.com>
>>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
>>>> ---
>>>> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>>>> index e89a6855..c99cd660 100644
>>>> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>>>> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
>>>> @@ -1,5 +1,5 @@
>>>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>>>> -require recipes-ti/includes/ti-paths.inc
>>>> +include recipes-ti/includes/ti-paths.inc
>>>>
>>>> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native virtual/bootloader"
>>>> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
>>>> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
>>>>
>>>> PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>>
>>>> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or '${TI_K3_SECDEV_INSTALL_DIR}' }"
>>>> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
>>>> export TI_SECURE_DEV_PKG
>>>>
>>>> SYSFW_SOC ?= "unknown"
>>>> --
>>>> 2.25.1
>>>>
>>>>
>>>>
>>>>
>>
>> --
>> Ryan Eatmon reatmon@ti.com
>> -----------------------------------------
>> Texas Instruments, Inc. - LCPD - MGTS
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#15430): https://lists.yoctoproject.org/g/meta-ti/message/15430
>> Mute This Topic: https://lists.yoctoproject.org/mt/95121729/1051867
>> Group Owner: meta-ti+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [mrchapp@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-07 22:42 ` Ryan Eatmon
@ 2022-12-12 12:19 ` Jose Quaresma
2022-12-14 0:00 ` Denys Dmytriyenko
0 siblings, 1 reply; 7+ messages in thread
From: Jose Quaresma @ 2022-12-12 12:19 UTC (permalink / raw)
To: reatmon; +Cc: Daniel Díaz, Denys Dmytriyenko, meta-ti, Ricardo Salveti
[-- Attachment #1: Type: text/plain, Size: 4702 bytes --]
Hi,
This is not enough to fix the issue, the layer is still broken
because ti-k3-secdev is needed as well and it is on meta-ti-extras.
I tested this patch in kirkstone but maybe master is affected too.
builder@ac8b892cdf40:/lmp/build-am64xx-evm$ grep ti-k3-secdev
/lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
ti-sci-fw_git.bb
DEPENDS:append = "${@ '' if d.getVar('TI_SECURE_DEV_PKG_K3') else '
ti-k3-secdev-native' }"
Without the meta-ti-extras layer bitbake fails with:
ERROR: Nothing PROVIDES 'ti-k3-secdev-native' (but
mc:k3r5-sr2-hs-fs:/lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
ti-sci-fw_git.bb DEPENDS on or otherwise requires it). Close matches:
libtspi-dev-native
makedevs-native
ERROR: Required build target 'ti-sci-fw' has no buildable providers.
Missing or unbuildable dependency chain was: ['ti-sci-fw',
'ti-k3-secdev-native']
Jose
Ryan Eatmon via lists.yoctoproject.org <reatmon=
ti.com@lists.yoctoproject.org> escreveu no dia quarta, 7/12/2022 à(s) 22:42:
>
> The test builds for this are running right now. I would expect that I
> can merge it over to kirkstone tomorrow morning sometime.
>
>
> On 12/7/2022 4:39 PM, Daniel Díaz wrote:
> > Hello!
> >
> > On Wed, Dec 7, 2022 at 4:34 PM Ryan Eatmon via lists.yoctoproject.org
> > <reatmon=ti.com@lists.yoctoproject.org> wrote:
> >> I literally merged this out to master about 30mins ago.
> >
> > We can this be expected to land on Kirkstone?
> >
> > Thanks and greetings!
> >
> > Daniel Díaz
> > yosoy@danieldiaz.org
> >
> >
> >
> >> On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
> >>> Ping?
> >>>
> >>>
> >>> On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
> >>>> From: Denys Dmytriyenko <denys@konsulko.com>
> >>>>
> >>>> Replace "require" with "include" to load ti-paths.inc and not break
> >>>> parsing when meta-ti-extras is not in the BBLAYERS list.
> >>>>
> >>>> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> >>>> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> >>>> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> >>>> the soft dependency will still work fine and give a build error
> >>>> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
> >>>>
> >>>> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
> >>>> d.getVar() to access it ensuring it doesn't break the condition.
> >>>>
> >>>> Reported-by: Daniel Díaz <mrchapp@gmail.com>
> >>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >>>> ---
> >>>> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
> >>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>>> index e89a6855..c99cd660 100644
> >>>> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>>> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>>> @@ -1,5 +1,5 @@
> >>>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> >>>> -require recipes-ti/includes/ti-paths.inc
> >>>> +include recipes-ti/includes/ti-paths.inc
> >>>>
> >>>> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native
> virtual/bootloader"
> >>>> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
> >>>> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
> >>>>
> >>>> PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>>>
> >>>> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> '${TI_K3_SECDEV_INSTALL_DIR}' }"
> >>>> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
> >>>> export TI_SECURE_DEV_PKG
> >>>>
> >>>> SYSFW_SOC ?= "unknown"
> >>>> --
> >>>> 2.25.1
> >>>>
> >>>>
> >>>>
> >>>>
> >>
> >> --
> >> Ryan Eatmon reatmon@ti.com
> >> -----------------------------------------
> >> Texas Instruments, Inc. - LCPD - MGTS
> >>
> >>
> >>
>
> --
> Ryan Eatmon reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc. - LCPD - MGTS
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15432):
> https://lists.yoctoproject.org/g/meta-ti/message/15432
> Mute This Topic: https://lists.yoctoproject.org/mt/95121729/5052612
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 7662 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-12 12:19 ` Jose Quaresma
@ 2022-12-14 0:00 ` Denys Dmytriyenko
2022-12-14 10:04 ` Jose Quaresma
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2022-12-14 0:00 UTC (permalink / raw)
To: Jose Quaresma; +Cc: reatmon, Daniel Díaz, meta-ti, Ricardo Salveti
Everything you said was already mentioned in the commit log below:
> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> the soft dependency will still work fine and give a build error
> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
--
Denys
On Mon, Dec 12, 2022 at 12:19:41PM +0000, Jose Quaresma wrote:
> Hi,
>
> This is not enough to fix the issue, the layer is still broken
> because ti-k3-secdev is needed as well and it is on meta-ti-extras.
> I tested this patch in kirkstone but maybe master is affected too.
>
> builder@ac8b892cdf40:/lmp/build-am64xx-evm$ grep ti-k3-secdev
> /lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
> ti-sci-fw_git.bb
> DEPENDS:append = "${@ '' if d.getVar('TI_SECURE_DEV_PKG_K3') else '
> ti-k3-secdev-native' }"
>
>
> Without the meta-ti-extras layer bitbake fails with:
>
> ERROR: Nothing PROVIDES 'ti-k3-secdev-native' (but
> mc:k3r5-sr2-hs-fs:/lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
> ti-sci-fw_git.bb DEPENDS on or otherwise requires it). Close matches:
> libtspi-dev-native
> makedevs-native
> ERROR: Required build target 'ti-sci-fw' has no buildable providers.
> Missing or unbuildable dependency chain was: ['ti-sci-fw',
> 'ti-k3-secdev-native']
>
>
> Jose
>
> Ryan Eatmon via lists.yoctoproject.org <reatmon=
> ti.com@lists.yoctoproject.org> escreveu no dia quarta, 7/12/2022 à(s) 22:42:
>
> >
> > The test builds for this are running right now. I would expect that I
> > can merge it over to kirkstone tomorrow morning sometime.
> >
> >
> > On 12/7/2022 4:39 PM, Daniel Díaz wrote:
> > > Hello!
> > >
> > > On Wed, Dec 7, 2022 at 4:34 PM Ryan Eatmon via lists.yoctoproject.org
> > > <reatmon=ti.com@lists.yoctoproject.org> wrote:
> > >> I literally merged this out to master about 30mins ago.
> > >
> > > We can this be expected to land on Kirkstone?
> > >
> > > Thanks and greetings!
> > >
> > > Daniel Díaz
> > > yosoy@danieldiaz.org
> > >
> > >
> > >
> > >> On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
> > >>> Ping?
> > >>>
> > >>>
> > >>> On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
> > >>>> From: Denys Dmytriyenko <denys@konsulko.com>
> > >>>>
> > >>>> Replace "require" with "include" to load ti-paths.inc and not break
> > >>>> parsing when meta-ti-extras is not in the BBLAYERS list.
> > >>>>
> > >>>> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> > >>>> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> > >>>> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> > >>>> the soft dependency will still work fine and give a build error
> > >>>> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
> > >>>>
> > >>>> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
> > >>>> d.getVar() to access it ensuring it doesn't break the condition.
> > >>>>
> > >>>> Reported-by: Daniel Díaz <mrchapp@gmail.com>
> > >>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> > >>>> ---
> > >>>> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
> > >>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > >>>>
> > >>>> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > >>>> index e89a6855..c99cd660 100644
> > >>>> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > >>>> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > >>>> @@ -1,5 +1,5 @@
> > >>>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > >>>> -require recipes-ti/includes/ti-paths.inc
> > >>>> +include recipes-ti/includes/ti-paths.inc
> > >>>>
> > >>>> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native
> > virtual/bootloader"
> > >>>> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
> > >>>> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
> > >>>>
> > >>>> PACKAGE_ARCH = "${MACHINE_ARCH}"
> > >>>>
> > >>>> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> > '${TI_K3_SECDEV_INSTALL_DIR}' }"
> > >>>> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> > d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
> > >>>> export TI_SECURE_DEV_PKG
> > >>>>
> > >>>> SYSFW_SOC ?= "unknown"
> > >>>> --
> > >>>> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft
2022-12-14 0:00 ` Denys Dmytriyenko
@ 2022-12-14 10:04 ` Jose Quaresma
0 siblings, 0 replies; 7+ messages in thread
From: Jose Quaresma @ 2022-12-14 10:04 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: reatmon, Daniel Díaz, meta-ti, Ricardo Salveti
[-- Attachment #1: Type: text/plain, Size: 5362 bytes --]
Denys Dmytriyenko <denis@denix.org> escreveu no dia quarta, 14/12/2022 à(s)
00:00:
> Everything you said was already mentioned in the commit log below:
>
> > As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> > for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> > for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> > the soft dependency will still work fine and give a build error
> > "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
>
So the layer is still broken for K3 HS platforms!
This patch makes the check-layer happy again as it does not fail any more
during bitbake parsing
but it will be difficult for the end user to discover this dependency.
And this is a circular dependency because meta-ti-extras depend on
meta-ti-bsp
and for this corner case with K3 HS platforms machines meta-ti-bsp depends
on meta-ti-extras.
Jose
> --
> Denys
>
>
> On Mon, Dec 12, 2022 at 12:19:41PM +0000, Jose Quaresma wrote:
> > Hi,
> >
> > This is not enough to fix the issue, the layer is still broken
> > because ti-k3-secdev is needed as well and it is on meta-ti-extras.
> > I tested this patch in kirkstone but maybe master is affected too.
> >
> > builder@ac8b892cdf40:/lmp/build-am64xx-evm$ grep ti-k3-secdev
> >
> /lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
> > ti-sci-fw_git.bb
> > DEPENDS:append = "${@ '' if d.getVar('TI_SECURE_DEV_PKG_K3') else '
> > ti-k3-secdev-native' }"
> >
> >
> > Without the meta-ti-extras layer bitbake fails with:
> >
> > ERROR: Nothing PROVIDES 'ti-k3-secdev-native' (but
> >
> mc:k3r5-sr2-hs-fs:/lmp/build-am64xx-evm/conf/../../layers/meta-ti/meta-ti-bsp/recipes-bsp/ti-sci-fw/
> > ti-sci-fw_git.bb DEPENDS on or otherwise requires it). Close matches:
> > libtspi-dev-native
> > makedevs-native
> > ERROR: Required build target 'ti-sci-fw' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['ti-sci-fw',
> > 'ti-k3-secdev-native']
> >
> >
> > Jose
> >
> > Ryan Eatmon via lists.yoctoproject.org <reatmon=
> > ti.com@lists.yoctoproject.org> escreveu no dia quarta, 7/12/2022 à(s)
> 22:42:
> >
> > >
> > > The test builds for this are running right now. I would expect that I
> > > can merge it over to kirkstone tomorrow morning sometime.
> > >
> > >
> > > On 12/7/2022 4:39 PM, Daniel Díaz wrote:
> > > > Hello!
> > > >
> > > > On Wed, Dec 7, 2022 at 4:34 PM Ryan Eatmon via
> lists.yoctoproject.org
> > > > <reatmon=ti.com@lists.yoctoproject.org> wrote:
> > > >> I literally merged this out to master about 30mins ago.
> > > >
> > > > We can this be expected to land on Kirkstone?
> > > >
> > > > Thanks and greetings!
> > > >
> > > > Daniel Díaz
> > > > yosoy@danieldiaz.org
> > > >
> > > >
> > > >
> > > >> On 12/7/2022 4:23 PM, Denys Dmytriyenko wrote:
> > > >>> Ping?
> > > >>>
> > > >>>
> > > >>> On Fri, Nov 18, 2022 at 09:07:49PM +0000, Denys Dmytriyenko wrote:
> > > >>>> From: Denys Dmytriyenko <denys@konsulko.com>
> > > >>>>
> > > >>>> Replace "require" with "include" to load ti-paths.inc and not
> break
> > > >>>> parsing when meta-ti-extras is not in the BBLAYERS list.
> > > >>>>
> > > >>>> As ti-paths.inc is only needed to define TI_K3_SECDEV_INSTALL_DIR
> > > >>>> for ti-k3-secdev when TI_SECURE_DEV_PKG_K3 is not set and building
> > > >>>> for K3 HS platforms. Since ti-k3-secdev resides in meta-ti-extras,
> > > >>>> the soft dependency will still work fine and give a build error
> > > >>>> "Nothing PROVIDES 'ti-k3-secdev-native'" when it is needed.
> > > >>>>
> > > >>>> Also, since TI_K3_SECDEV_INSTALL_DIR can now be undefined, use
> > > >>>> d.getVar() to access it ensuring it doesn't break the condition.
> > > >>>>
> > > >>>> Reported-by: Daniel Díaz <mrchapp@gmail.com>
> > > >>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> > > >>>> ---
> > > >>>> meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ++--
> > > >>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >>>>
> > > >>>> diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > > b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > > >>>> index e89a6855..c99cd660 100644
> > > >>>> --- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > > >>>> +++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> > > >>>> @@ -1,5 +1,5 @@
> > > >>>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > > >>>> -require recipes-ti/includes/ti-paths.inc
> > > >>>> +include recipes-ti/includes/ti-paths.inc
> > > >>>>
> > > >>>> DEPENDS = "openssl-native u-boot-mkimage-native dtc-native
> > > virtual/bootloader"
> > > >>>> DEPENDS:remove:am65xx-evm-k3r5 = "virtual/bootloader"
> > > >>>> @@ -20,7 +20,7 @@ COMPATIBLE_MACHINE:aarch64 = "null"
> > > >>>>
> > > >>>> PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > >>>>
> > > >>>> -TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> > > '${TI_K3_SECDEV_INSTALL_DIR}' }"
> > > >>>> +TI_SECURE_DEV_PKG = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or
> > > d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
> > > >>>> export TI_SECURE_DEV_PKG
> > > >>>>
> > > >>>> SYSFW_SOC ?= "unknown"
> > > >>>> --
> > > >>>> 2.25.1
>
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 8580 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-14 10:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1728C9EC4C3A35F2.13174@lists.yoctoproject.org>
2022-12-07 22:23 ` [meta-ti] [master/kirkstone][PATCH] ti-sci-fw: make dependency on meta-ti-extras soft Denys Dmytriyenko
2022-12-07 22:34 ` Ryan Eatmon
2022-12-07 22:39 ` Daniel Díaz
2022-12-07 22:42 ` Ryan Eatmon
2022-12-12 12:19 ` Jose Quaresma
2022-12-14 0:00 ` Denys Dmytriyenko
2022-12-14 10:04 ` Jose Quaresma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.