[U-Boot] U-Boot DFU test and Ctrl+C

[U-Boot] U-Boot DFU test and Ctrl+C

[Tom Rini]

Hey guys,

As I use the DFU tests more and more, I keep hitting what I'm pretty
sure is a false failure in the tests.  Sometimes the tests fail at:
>       u_boot_console.wait_for('Ctrl+C to exit ...')

and the last bit of the console log is:
Starting download: [#################################################################] finished!
unable to read DFU status
#File System is consistent
file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=> 

So perhaps we should make the test look for the prompt itself rather
than 'Ctrl+C' ?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/d8c3a238/attachment.sig>

[U-Boot] U-Boot DFU test and Ctrl+C

[Stephen Warren]

On 09/27/2016 09:46 AM, Tom Rini wrote:
> Hey guys,
>
> As I use the DFU tests more and more, I keep hitting what I'm pretty
> sure is a false failure in the tests.  Sometimes the tests fail at:
>>       u_boot_console.wait_for('Ctrl+C to exit ...')
>
> and the last bit of the console log is:
> Starting download: [#################################################################] finished!
> unable to read DFU status
> #File System is consistent
> file found, deleting
> update journal finished
> File System is consistent
> update journal finished
> 65 bytes written in 12380 ms (0 Bytes/s)
> =>
>
> So perhaps we should make the test look for the prompt itself rather
> than 'Ctrl+C' ?  Thanks!

FWIW, I haven't seen this issue at all.

This looks like a bug in the DFU code to me; from the log you gave it 
seems like the dfu shell command is exiting back to the shell prompt all 
by itself. It shouldn't do that, but should rather wait for the user to 
press Ctrl-C. The only exception would be that the host tool has some 
options to trigger a "reset" on the target. The test/py code shouldn't 
be using that option though, and IIRC U-Boot attempts a CPU/board reset 
in response to that command rather than simply dropping back to the 
shell prompt.

[U-Boot] U-Boot DFU test and Ctrl+C

[Lukasz Majewski]

Hi Tom,

> Hey guys,
> 
> As I use the DFU tests more and more, I keep hitting what I'm pretty
> sure is a false failure in the tests.  Sometimes the tests fail at:
> >       u_boot_console.wait_for('Ctrl+C to exit ...')
> 
> and the last bit of the console log is:
> Starting download:
> [#################################################################]
> finished! unable to read DFU status #File System is consistent
> file found, deleting
> update journal finished
> File System is consistent
> update journal finished
> 65 bytes written in 12380 ms (0 Bytes/s)
> => 
> 
> So perhaps we should make the test look for the prompt itself rather
> than 'Ctrl+C' ?  Thanks!

As fair as I remember, dfu-util provides and u-boot's dfu supports -e
switch behavior. This switch causes the dfu u-boot command to go
directly to u-boot prompt.

Tom, I suppose that this is what you would need. 
Just add -e to your host's dfu-util command.

> 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] U-Boot DFU test and Ctrl+C

[Stephen Warren]

On 09/28/2016 03:32 AM, Lukasz Majewski wrote:
> Hi Tom,
>
>> Hey guys,
>>
>> As I use the DFU tests more and more, I keep hitting what I'm pretty
>> sure is a false failure in the tests.  Sometimes the tests fail at:
>>>       u_boot_console.wait_for('Ctrl+C to exit ...')
>>
>> and the last bit of the console log is:
>> Starting download:
>> [#################################################################]
>> finished! unable to read DFU status #File System is consistent
>> file found, deleting
>> update journal finished
>> File System is consistent
>> update journal finished
>> 65 bytes written in 12380 ms (0 Bytes/s)
>> =>
>>
>> So perhaps we should make the test look for the prompt itself rather
>> than 'Ctrl+C' ?  Thanks!
>
> As fair as I remember, dfu-util provides and u-boot's dfu supports -e
> switch behavior. This switch causes the dfu u-boot command to go
> directly to u-boot prompt.
>
> Tom, I suppose that this is what you would need.
> Just add -e to your host's dfu-util command.

Using -e is the opposite of what Tom wants. The test/py script expects 
the dfu command to continue running after an upload/download, since 
that's the default behaviour.

[U-Boot] U-Boot DFU test and Ctrl+C

[Tom Rini]

On Wed, Sep 28, 2016 at 11:49:52AM -0600, Stephen Warren wrote:
> On 09/28/2016 03:32 AM, Lukasz Majewski wrote:
> >Hi Tom,
> >
> >>Hey guys,
> >>
> >>As I use the DFU tests more and more, I keep hitting what I'm pretty
> >>sure is a false failure in the tests.  Sometimes the tests fail at:
> >>>      u_boot_console.wait_for('Ctrl+C to exit ...')
> >>
> >>and the last bit of the console log is:
> >>Starting download:
> >>[#################################################################]
> >>finished! unable to read DFU status #File System is consistent
> >>file found, deleting
> >>update journal finished
> >>File System is consistent
> >>update journal finished
> >>65 bytes written in 12380 ms (0 Bytes/s)
> >>=>
> >>
> >>So perhaps we should make the test look for the prompt itself rather
> >>than 'Ctrl+C' ?  Thanks!
> >
> >As fair as I remember, dfu-util provides and u-boot's dfu supports -e
> >switch behavior. This switch causes the dfu u-boot command to go
> >directly to u-boot prompt.
> >
> >Tom, I suppose that this is what you would need.
> >Just add -e to your host's dfu-util command.
> 
> Using -e is the opposite of what Tom wants. The test/py script
> expects the dfu command to continue running after an
> upload/download, since that's the default behaviour.

Right.  It sounds like DWC3 might have an intermittent issue I need to
find some time to try and debug, or talk someone else into debugging :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160930/1d97aa9d/attachment.sig>