All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Lyude Paul <lyude@redhat.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@intel.com>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@linux.ie>
Subject: Re: [v2,1/3] drm/dp: Introduce EDID-based quirks
Date: Tue, 03 Mar 2020 14:51:27 -0500	[thread overview]
Message-ID: <faad55e121f844d9b47afa603ad09641a58957b5.camel@redhat.com> (raw)
In-Reply-To: <20200211183358.157448-2-lyude@redhat.com>

On Tue, 2020-02-11 at 13:33 -0500, Lyude Paul wrote:
> The whole point of using OUIs is so that we can recognize certain
> devices and potentially apply quirks for them. Normally this should work
> quite well, but there appears to be quite a number of laptop panels out
> there that will fill the OUI but not the device ID. As such, for devices
> like this I can't imagine it's a very good idea to try relying on OUIs
> for applying quirks. As well, some laptop vendors have confirmed to us
> that their panels have this exact issue.
> 
> So, let's introduce the ability to apply DP quirks based on EDID
> identification. We reuse the same quirk bits for OUI-based quirks, so
> that callers can simply check all possible quirks using
> drm_dp_has_quirk().

With the bug URL fixed in 2/3, series is:

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax


WARNING: multiple messages have this Message-ID (diff)
From: Adam Jackson <ajax@redhat.com>
To: Lyude Paul <lyude@redhat.com>,
	intel-gfx@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [v2,1/3] drm/dp: Introduce EDID-based quirks
Date: Tue, 03 Mar 2020 14:51:27 -0500	[thread overview]
Message-ID: <faad55e121f844d9b47afa603ad09641a58957b5.camel@redhat.com> (raw)
In-Reply-To: <20200211183358.157448-2-lyude@redhat.com>

On Tue, 2020-02-11 at 13:33 -0500, Lyude Paul wrote:
> The whole point of using OUIs is so that we can recognize certain
> devices and potentially apply quirks for them. Normally this should work
> quite well, but there appears to be quite a number of laptop panels out
> there that will fill the OUI but not the device ID. As such, for devices
> like this I can't imagine it's a very good idea to try relying on OUIs
> for applying quirks. As well, some laptop vendors have confirmed to us
> that their panels have this exact issue.
> 
> So, let's introduce the ability to apply DP quirks based on EDID
> identification. We reuse the same quirk bits for OUI-based quirks, so
> that callers can simply check all possible quirks using
> drm_dp_has_quirk().

With the bug URL fixed in 2/3, series is:

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Adam Jackson <ajax@redhat.com>
To: Lyude Paul <lyude@redhat.com>,
	intel-gfx@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@linux.ie>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [v2,1/3] drm/dp: Introduce EDID-based quirks
Date: Tue, 03 Mar 2020 14:51:27 -0500	[thread overview]
Message-ID: <faad55e121f844d9b47afa603ad09641a58957b5.camel@redhat.com> (raw)
In-Reply-To: <20200211183358.157448-2-lyude@redhat.com>

On Tue, 2020-02-11 at 13:33 -0500, Lyude Paul wrote:
> The whole point of using OUIs is so that we can recognize certain
> devices and potentially apply quirks for them. Normally this should work
> quite well, but there appears to be quite a number of laptop panels out
> there that will fill the OUI but not the device ID. As such, for devices
> like this I can't imagine it's a very good idea to try relying on OUIs
> for applying quirks. As well, some laptop vendors have confirmed to us
> that their panels have this exact issue.
> 
> So, let's introduce the ability to apply DP quirks based on EDID
> identification. We reuse the same quirk bits for OUI-based quirks, so
> that callers can simply check all possible quirks using
> drm_dp_has_quirk().

With the bug URL fixed in 2/3, series is:

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-03-03 19:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 18:33 [PATCH v2 0/3] drm/dp,i915: eDP DPCD backlight control detection fixes Lyude Paul
2020-02-11 18:33 ` [Intel-gfx] [PATCH v2 0/3] drm/dp, i915: " Lyude Paul
2020-02-11 18:33 ` Lyude Paul
2020-02-11 18:33 ` [PATCH v2 1/3] drm/dp: Introduce EDID-based quirks Lyude Paul
2020-02-11 18:33   ` [Intel-gfx] " Lyude Paul
2020-02-11 18:33   ` Lyude Paul
2020-03-03 19:51   ` Adam Jackson [this message]
2020-03-03 19:51     ` [Intel-gfx] [v2,1/3] " Adam Jackson
2020-03-03 19:51     ` Adam Jackson
2020-02-11 18:33 ` [PATCH v2 2/3] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel Lyude Paul
2020-02-11 18:33   ` [Intel-gfx] " Lyude Paul
2020-02-11 18:33   ` Lyude Paul
2020-03-03 19:50   ` [v2,2/3] " Adam Jackson
2020-03-03 19:50     ` [Intel-gfx] [v2, 2/3] " Adam Jackson
2020-03-03 19:50     ` [v2,2/3] " Adam Jackson
2020-03-03 21:53   ` [PATCH v3] " Lyude Paul
2020-03-03 21:53     ` [Intel-gfx] " Lyude Paul
2020-03-03 21:53     ` Lyude Paul
2020-02-11 18:33 ` [PATCH v2 3/3] drm/i915: Force DPCD backlight mode for some Dell CML 2020 panels Lyude Paul
2020-02-11 18:33   ` [Intel-gfx] " Lyude Paul
2020-02-11 18:33   ` Lyude Paul
2020-02-13  0:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp, i915: eDP DPCD backlight control detection fixes (rev2) Patchwork
2020-02-15 21:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-03  0:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/dp, i915: eDP DPCD backlight control detection fixes (rev3) Patchwork
2020-03-03  1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-03 14:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-04  0:48 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/dp, i915: eDP DPCD backlight control detection fixes (rev4) Patchwork
2020-03-04  0:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-04 15:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=faad55e121f844d9b47afa603ad09641a58957b5.camel@redhat.com \
    --to=ajax@redhat.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=lyude@redhat.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.