* [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-13 14:49 ` Antonio Borneo
0 siblings, 0 replies; 9+ messages in thread
From: Antonio Borneo @ 2021-07-13 14:49 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: Antonio Borneo, linux-kernel
The driver uses a conservative set of hardcoded values for the
maximum time delay of the transitions between LP and HS, either
for data and clock lanes.
By using the info in STM32MP157 datasheet, valid also for other ST
devices, compute the actual delay from the lane's bps.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
To: Yannick Fertre <yannick.fertre@foss.st.com>
To: Philippe Cornu <philippe.cornu@foss.st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: David Airlie <airlied@linux.ie>
To: Daniel Vetter <daniel@ffwll.ch>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: dri-devel@lists.freedesktop.org
To: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index 8399d337589d..32cb41b2202f 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
return 0;
}
+#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
+
static int
dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
struct dw_mipi_dsi_dphy_timing *timing)
{
- timing->clk_hs2lp = 0x40;
- timing->clk_lp2hs = 0x40;
- timing->data_hs2lp = 0x40;
- timing->data_lp2hs = 0x40;
+ /*
+ * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
+ * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
+ * phy_clklp2hs_time = (512+40*UI)/(8*UI)
+ * phy_hs2lp_time = (192+64*UI)/(8*UI)
+ * phy_lp2hs_time = (256+32*UI)/(8*UI)
+ */
+ timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
+ timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
+ timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
+ timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
return 0;
}
base-commit: 35d283658a6196b2057be562096610c6793e1219
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-13 14:49 ` Antonio Borneo
0 siblings, 0 replies; 9+ messages in thread
From: Antonio Borneo @ 2021-07-13 14:49 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: Antonio Borneo, linux-kernel
The driver uses a conservative set of hardcoded values for the
maximum time delay of the transitions between LP and HS, either
for data and clock lanes.
By using the info in STM32MP157 datasheet, valid also for other ST
devices, compute the actual delay from the lane's bps.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
To: Yannick Fertre <yannick.fertre@foss.st.com>
To: Philippe Cornu <philippe.cornu@foss.st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: David Airlie <airlied@linux.ie>
To: Daniel Vetter <daniel@ffwll.ch>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: dri-devel@lists.freedesktop.org
To: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index 8399d337589d..32cb41b2202f 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
return 0;
}
+#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
+
static int
dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
struct dw_mipi_dsi_dphy_timing *timing)
{
- timing->clk_hs2lp = 0x40;
- timing->clk_lp2hs = 0x40;
- timing->data_hs2lp = 0x40;
- timing->data_lp2hs = 0x40;
+ /*
+ * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
+ * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
+ * phy_clklp2hs_time = (512+40*UI)/(8*UI)
+ * phy_hs2lp_time = (192+64*UI)/(8*UI)
+ * phy_lp2hs_time = (256+32*UI)/(8*UI)
+ */
+ timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
+ timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
+ timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
+ timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
return 0;
}
base-commit: 35d283658a6196b2057be562096610c6793e1219
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-13 14:49 ` Antonio Borneo
0 siblings, 0 replies; 9+ messages in thread
From: Antonio Borneo @ 2021-07-13 14:49 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: Antonio Borneo, linux-kernel
The driver uses a conservative set of hardcoded values for the
maximum time delay of the transitions between LP and HS, either
for data and clock lanes.
By using the info in STM32MP157 datasheet, valid also for other ST
devices, compute the actual delay from the lane's bps.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
To: Yannick Fertre <yannick.fertre@foss.st.com>
To: Philippe Cornu <philippe.cornu@foss.st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: David Airlie <airlied@linux.ie>
To: Daniel Vetter <daniel@ffwll.ch>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: dri-devel@lists.freedesktop.org
To: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index 8399d337589d..32cb41b2202f 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
return 0;
}
+#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
+
static int
dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
struct dw_mipi_dsi_dphy_timing *timing)
{
- timing->clk_hs2lp = 0x40;
- timing->clk_lp2hs = 0x40;
- timing->data_hs2lp = 0x40;
- timing->data_lp2hs = 0x40;
+ /*
+ * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
+ * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
+ * phy_clklp2hs_time = (512+40*UI)/(8*UI)
+ * phy_hs2lp_time = (192+64*UI)/(8*UI)
+ * phy_lp2hs_time = (256+32*UI)/(8*UI)
+ */
+ timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
+ timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
+ timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
+ timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
return 0;
}
base-commit: 35d283658a6196b2057be562096610c6793e1219
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
2021-07-13 14:49 ` Antonio Borneo
(?)
@ 2021-07-13 16:47 ` Philippe CORNU
-1 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-13 16:47 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
Hi Antonio,
On 7/13/21 4:49 PM, Antonio Borneo wrote:
> The driver uses a conservative set of hardcoded values for the
> maximum time delay of the transitions between LP and HS, either
> for data and clock lanes.
>
> By using the info in STM32MP157 datasheet, valid also for other ST
> devices, compute the actual delay from the lane's bps.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> To: Yannick Fertre <yannick.fertre@foss.st.com>
> To: Philippe Cornu <philippe.cornu@foss.st.com>
> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> To: David Airlie <airlied@linux.ie>
> To: Daniel Vetter <daniel@ffwll.ch>
> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> To: dri-devel@lists.freedesktop.org
> To: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 8399d337589d..32cb41b2202f 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
> return 0;
> }
>
> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
> +
> static int
> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
> struct dw_mipi_dsi_dphy_timing *timing)
> {
> - timing->clk_hs2lp = 0x40;
> - timing->clk_lp2hs = 0x40;
> - timing->data_hs2lp = 0x40;
> - timing->data_lp2hs = 0x40;
> + /*
> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
> + */
> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
Many thanks for your patch.
Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
I will apply it on drm-misc-next early next week,
Philippe :-)
>
> return 0;
> }
>
> base-commit: 35d283658a6196b2057be562096610c6793e1219
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-13 16:47 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-13 16:47 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
Hi Antonio,
On 7/13/21 4:49 PM, Antonio Borneo wrote:
> The driver uses a conservative set of hardcoded values for the
> maximum time delay of the transitions between LP and HS, either
> for data and clock lanes.
>
> By using the info in STM32MP157 datasheet, valid also for other ST
> devices, compute the actual delay from the lane's bps.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> To: Yannick Fertre <yannick.fertre@foss.st.com>
> To: Philippe Cornu <philippe.cornu@foss.st.com>
> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> To: David Airlie <airlied@linux.ie>
> To: Daniel Vetter <daniel@ffwll.ch>
> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> To: dri-devel@lists.freedesktop.org
> To: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 8399d337589d..32cb41b2202f 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
> return 0;
> }
>
> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
> +
> static int
> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
> struct dw_mipi_dsi_dphy_timing *timing)
> {
> - timing->clk_hs2lp = 0x40;
> - timing->clk_lp2hs = 0x40;
> - timing->data_hs2lp = 0x40;
> - timing->data_lp2hs = 0x40;
> + /*
> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
> + */
> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
Many thanks for your patch.
Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
I will apply it on drm-misc-next early next week,
Philippe :-)
>
> return 0;
> }
>
> base-commit: 35d283658a6196b2057be562096610c6793e1219
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-13 16:47 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-13 16:47 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
Hi Antonio,
On 7/13/21 4:49 PM, Antonio Borneo wrote:
> The driver uses a conservative set of hardcoded values for the
> maximum time delay of the transitions between LP and HS, either
> for data and clock lanes.
>
> By using the info in STM32MP157 datasheet, valid also for other ST
> devices, compute the actual delay from the lane's bps.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> To: Yannick Fertre <yannick.fertre@foss.st.com>
> To: Philippe Cornu <philippe.cornu@foss.st.com>
> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> To: David Airlie <airlied@linux.ie>
> To: Daniel Vetter <daniel@ffwll.ch>
> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> To: dri-devel@lists.freedesktop.org
> To: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 8399d337589d..32cb41b2202f 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
> return 0;
> }
>
> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000 * (vp), 8000)
> +
> static int
> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
> struct dw_mipi_dsi_dphy_timing *timing)
> {
> - timing->clk_hs2lp = 0x40;
> - timing->clk_lp2hs = 0x40;
> - timing->data_hs2lp = 0x40;
> - timing->data_lp2hs = 0x40;
> + /*
> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9, STM32H747
> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
> + */
> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
Many thanks for your patch.
Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
I will apply it on drm-misc-next early next week,
Philippe :-)
>
> return 0;
> }
>
> base-commit: 35d283658a6196b2057be562096610c6793e1219
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
2021-07-13 16:47 ` Philippe CORNU
(?)
@ 2021-07-19 13:40 ` Philippe CORNU
-1 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-19 13:40 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
On 7/13/21 6:47 PM, Philippe CORNU wrote:
> Hi Antonio,
>
> On 7/13/21 4:49 PM, Antonio Borneo wrote:
>> The driver uses a conservative set of hardcoded values for the
>> maximum time delay of the transitions between LP and HS, either
>> for data and clock lanes.
>>
>> By using the info in STM32MP157 datasheet, valid also for other ST
>> devices, compute the actual delay from the lane's bps.
>>
>> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>> ---
>> To: Yannick Fertre <yannick.fertre@foss.st.com>
>> To: Philippe Cornu <philippe.cornu@foss.st.com>
>> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> To: David Airlie <airlied@linux.ie>
>> To: Daniel Vetter <daniel@ffwll.ch>
>> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
>> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>> To: dri-devel@lists.freedesktop.org
>> To: linux-stm32@st-md-mailman.stormreply.com
>> To: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>>
>> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> index 8399d337589d..32cb41b2202f 100644
>> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const
>> struct drm_display_mode *mode,
>> return 0;
>> }
>> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000
>> * (vp), 8000)
>> +
>> static int
>> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
>> struct dw_mipi_dsi_dphy_timing *timing)
>> {
>> - timing->clk_hs2lp = 0x40;
>> - timing->clk_lp2hs = 0x40;
>> - timing->data_hs2lp = 0x40;
>> - timing->data_lp2hs = 0x40;
>> + /*
>> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9,
>> STM32H747
>> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
>> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
>> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
>> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
>> + */
>> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
>> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
>> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
>> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
>
> Many thanks for your patch.
>
> Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
> Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
>
> I will apply it on drm-misc-next early next week,
>
> Philippe :-)
>
>> return 0;
>> }
>>
>> base-commit: 35d283658a6196b2057be562096610c6793e1219
>>
Applied on drm-misc-next.
Many thanks for your patch,
Philippe :-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-19 13:40 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-19 13:40 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
On 7/13/21 6:47 PM, Philippe CORNU wrote:
> Hi Antonio,
>
> On 7/13/21 4:49 PM, Antonio Borneo wrote:
>> The driver uses a conservative set of hardcoded values for the
>> maximum time delay of the transitions between LP and HS, either
>> for data and clock lanes.
>>
>> By using the info in STM32MP157 datasheet, valid also for other ST
>> devices, compute the actual delay from the lane's bps.
>>
>> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>> ---
>> To: Yannick Fertre <yannick.fertre@foss.st.com>
>> To: Philippe Cornu <philippe.cornu@foss.st.com>
>> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> To: David Airlie <airlied@linux.ie>
>> To: Daniel Vetter <daniel@ffwll.ch>
>> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
>> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>> To: dri-devel@lists.freedesktop.org
>> To: linux-stm32@st-md-mailman.stormreply.com
>> To: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>>
>> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> index 8399d337589d..32cb41b2202f 100644
>> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const
>> struct drm_display_mode *mode,
>> return 0;
>> }
>> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000
>> * (vp), 8000)
>> +
>> static int
>> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
>> struct dw_mipi_dsi_dphy_timing *timing)
>> {
>> - timing->clk_hs2lp = 0x40;
>> - timing->clk_lp2hs = 0x40;
>> - timing->data_hs2lp = 0x40;
>> - timing->data_lp2hs = 0x40;
>> + /*
>> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9,
>> STM32H747
>> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
>> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
>> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
>> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
>> + */
>> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
>> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
>> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
>> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
>
> Many thanks for your patch.
>
> Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
> Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
>
> I will apply it on drm-misc-next early next week,
>
> Philippe :-)
>
>> return 0;
>> }
>>
>> base-commit: 35d283658a6196b2057be562096610c6793e1219
>>
Applied on drm-misc-next.
Many thanks for your patch,
Philippe :-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back
@ 2021-07-19 13:40 ` Philippe CORNU
0 siblings, 0 replies; 9+ messages in thread
From: Philippe CORNU @ 2021-07-19 13:40 UTC (permalink / raw)
To: Antonio Borneo, Yannick Fertre, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue,
Raphael Gallais-Pou, dri-devel, linux-stm32, linux-arm-kernel
Cc: linux-kernel
On 7/13/21 6:47 PM, Philippe CORNU wrote:
> Hi Antonio,
>
> On 7/13/21 4:49 PM, Antonio Borneo wrote:
>> The driver uses a conservative set of hardcoded values for the
>> maximum time delay of the transitions between LP and HS, either
>> for data and clock lanes.
>>
>> By using the info in STM32MP157 datasheet, valid also for other ST
>> devices, compute the actual delay from the lane's bps.
>>
>> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
>> ---
>> To: Yannick Fertre <yannick.fertre@foss.st.com>
>> To: Philippe Cornu <philippe.cornu@foss.st.com>
>> To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> To: David Airlie <airlied@linux.ie>
>> To: Daniel Vetter <daniel@ffwll.ch>
>> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> To: Alexandre Torgue <alexandre.torgue@foss.st.com>
>> To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>> To: dri-devel@lists.freedesktop.org
>> To: linux-stm32@st-md-mailman.stormreply.com
>> To: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>>
>> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> index 8399d337589d..32cb41b2202f 100644
>> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> @@ -309,14 +309,23 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const
>> struct drm_display_mode *mode,
>> return 0;
>> }
>> +#define DSI_PHY_DELAY(fp, vp, mbps) DIV_ROUND_UP((fp) * (mbps) + 1000
>> * (vp), 8000)
>> +
>> static int
>> dw_mipi_dsi_phy_get_timing(void *priv_data, unsigned int lane_mbps,
>> struct dw_mipi_dsi_dphy_timing *timing)
>> {
>> - timing->clk_hs2lp = 0x40;
>> - timing->clk_lp2hs = 0x40;
>> - timing->data_hs2lp = 0x40;
>> - timing->data_lp2hs = 0x40;
>> + /*
>> + * From STM32MP157 datasheet, valid for STM32F469, STM32F7x9,
>> STM32H747
>> + * phy_clkhs2lp_time = (272+136*UI)/(8*UI)
>> + * phy_clklp2hs_time = (512+40*UI)/(8*UI)
>> + * phy_hs2lp_time = (192+64*UI)/(8*UI)
>> + * phy_lp2hs_time = (256+32*UI)/(8*UI)
>> + */
>> + timing->clk_hs2lp = DSI_PHY_DELAY(272, 136, lane_mbps);
>> + timing->clk_lp2hs = DSI_PHY_DELAY(512, 40, lane_mbps);
>> + timing->data_hs2lp = DSI_PHY_DELAY(192, 64, lane_mbps);
>> + timing->data_lp2hs = DSI_PHY_DELAY(256, 32, lane_mbps);
>
> Many thanks for your patch.
>
> Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
> Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
>
> I will apply it on drm-misc-next early next week,
>
> Philippe :-)
>
>> return 0;
>> }
>>
>> base-commit: 35d283658a6196b2057be562096610c6793e1219
>>
Applied on drm-misc-next.
Many thanks for your patch,
Philippe :-)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-07-19 13:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 14:49 [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back Antonio Borneo
2021-07-13 14:49 ` Antonio Borneo
2021-07-13 14:49 ` Antonio Borneo
2021-07-13 16:47 ` Philippe CORNU
2021-07-13 16:47 ` Philippe CORNU
2021-07-13 16:47 ` Philippe CORNU
2021-07-19 13:40 ` Philippe CORNU
2021-07-19 13:40 ` Philippe CORNU
2021-07-19 13:40 ` Philippe CORNU
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.