meson incremental build doesn't handle config file going away

meson incremental build doesn't handle config file going away

[Peter Maydell]

I've noticed that the meson incremental build doesn't seem to
cleanly handle a config file going away, as ppc64abi32-linux-user
has recently. The build fails with:

../../meson.build:1941:2: ERROR: Failed to load
/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak:
[Errno 2] No such file or directory:
'/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak'

where line 1941 is
  config_target += keyval.load('configs/targets' / target + '.mak')

Rerunning make doesn't help; you have to manually re-run
configure.

Something here should figure out that "config file deleted" means
it needs to rerun configure, I think.

thanks
-- PMM

Re: meson incremental build doesn't handle config file going away

[Thomas Huth]

On 18/02/2022 12.59, Peter Maydell wrote:
> I've noticed that the meson incremental build doesn't seem to
> cleanly handle a config file going away, as ppc64abi32-linux-user
> has recently. The build fails with:
> 
> ../../meson.build:1941:2: ERROR: Failed to load
> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak:
> [Errno 2] No such file or directory:
> '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak'
> 
> where line 1941 is
>    config_target += keyval.load('configs/targets' / target + '.mak')
> 
> Rerunning make doesn't help; you have to manually re-run
> configure.
> 
> Something here should figure out that "config file deleted" means
> it needs to rerun configure, I think.

That's weird, since the patch that removed that target actually change the 
configure script, too, so it should have re-run configure afterwards... or 
is that broken, too?

  Thomas

Re: meson incremental build doesn't handle config file going away

[Peter Maydell]

On Fri, 18 Feb 2022 at 12:08, Thomas Huth <thuth@redhat.com> wrote:
>
> On 18/02/2022 12.59, Peter Maydell wrote:
> > I've noticed that the meson incremental build doesn't seem to
> > cleanly handle a config file going away, as ppc64abi32-linux-user
> > has recently. The build fails with:
> >
> > ../../meson.build:1941:2: ERROR: Failed to load
> > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak:
> > [Errno 2] No such file or directory:
> > '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/configs/targets/ppc64abi32-linux-user.mak'
> >
> > where line 1941 is
> >    config_target += keyval.load('configs/targets' / target + '.mak')
> >
> > Rerunning make doesn't help; you have to manually re-run
> > configure.
> >
> > Something here should figure out that "config file deleted" means
> > it needs to rerun configure, I think.
>
> That's weird, since the patch that removed that target actually change the
> configure script, too, so it should have re-run configure afterwards... or
> is that broken, too?

I'm not sure exactly what's going on -- I didn't see this when I
originally applied the pullreq, but I have seen it a couple of times
later. I guess that some amount of switching between branches and
incrementally-building of older build trees might be involved.

-- PMM