All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhenyu Ye <yezhenyu2@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <mark.rutland@arm.com>, <catalin.marinas@arm.com>,
	<linux-mm@kvack.org>, <guohanjun@huawei.com>, <will@kernel.org>,
	<linux-arch@vger.kernel.org>, <yuzhao@google.com>,
	<maz@kernel.org>, <steven.price@arm.com>, <arm@kernel.org>,
	<Dave.Martin@arm.com>, <arnd@arndb.de>, <suzuki.poulose@arm.com>,
	<npiggin@gmail.com>, <zhangshaokun@hisilicon.com>,
	<broonie@kernel.org>, <rostedt@goodmis.org>,
	<prime.zeng@hisilicon.com>, <tglx@linutronix.de>,
	<linux-arm-kernel@lists.infradead.org>, <xiexiangyou@huawei.com>,
	<linux-kernel@vger.kernel.org>, <aneesh.kumar@linux.ibm.com>,
	<akpm@linux-foundation.org>
Subject: Re: Re: [RFC PATCH v4 0/6] arm64: tlb: add support for TTL feature
Date: Wed, 25 Mar 2020 12:49:45 +0800	[thread overview]
Message-ID: <fb06ba92-a3ce-6925-e914-167a85837f27@huawei.com> (raw)
In-Reply-To: <20200324150155.GH20713@hirez.programming.kicks-ass.net>

Hi Peter,

On 2020/3/24 23:01, Peter Zijlstra wrote:
> On Tue, Mar 24, 2020 at 09:45:28PM +0800, Zhenyu Ye wrote:
>> In order to reduce the cost of TLB invalidation, the ARMv8.4 TTL
>> feature allows TLBs to be issued with a level allowing for quicker
>> invalidation.  This series provide support for this feature. 
>>
>> Patch 1 and Patch 2 was provided by Marc on his NV series[1] patches,
>> which detect the TTL feature and add __tlbi_level interface.
> 
> I realy hate how it makes vma->vm_flags more important for tlbi.
> 

Thanks for your review.

The tlbi interfaces only have two parameters: vma and addr. If we
try to not use vma->vm_flags, we may should have to add a parameter
to some of these interfaces(such as flush_tlb_range), which are
common to all architectures.

I'm not sure if this is feasible, because this feature is only
supported by ARM64 currently.


Thanks,
Zhenyu


WARNING: multiple messages have this Message-ID (diff)
From: Zhenyu Ye <yezhenyu2@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
	linux-mm@kvack.org, guohanjun@huawei.com, will@kernel.org,
	linux-arch@vger.kernel.org, yuzhao@google.com, maz@kernel.org,
	steven.price@arm.com, arm@kernel.org, Dave.Martin@arm.com,
	arnd@arndb.de, suzuki.poulose@arm.com, npiggin@gmail.com,
	zhangshaokun@hisilicon.com, broonie@kernel.org,
	rostedt@goodmis.org, prime.zeng@hisilicon.com,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	xiexiangyou@huawei.com, linux-kernel@vger.kernel.org,
	aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org
Subject: Re: Re: [RFC PATCH v4 0/6] arm64: tlb: add support for TTL feature
Date: Wed, 25 Mar 2020 12:49:45 +0800	[thread overview]
Message-ID: <fb06ba92-a3ce-6925-e914-167a85837f27@huawei.com> (raw)
In-Reply-To: <20200324150155.GH20713@hirez.programming.kicks-ass.net>

Hi Peter,

On 2020/3/24 23:01, Peter Zijlstra wrote:
> On Tue, Mar 24, 2020 at 09:45:28PM +0800, Zhenyu Ye wrote:
>> In order to reduce the cost of TLB invalidation, the ARMv8.4 TTL
>> feature allows TLBs to be issued with a level allowing for quicker
>> invalidation.  This series provide support for this feature. 
>>
>> Patch 1 and Patch 2 was provided by Marc on his NV series[1] patches,
>> which detect the TTL feature and add __tlbi_level interface.
> 
> I realy hate how it makes vma->vm_flags more important for tlbi.
> 

Thanks for your review.

The tlbi interfaces only have two parameters: vma and addr. If we
try to not use vma->vm_flags, we may should have to add a parameter
to some of these interfaces(such as flush_tlb_range), which are
common to all architectures.

I'm not sure if this is feasible, because this feature is only
supported by ARM64 currently.


Thanks,
Zhenyu

WARNING: multiple messages have this Message-ID (diff)
From: Zhenyu Ye <yezhenyu2@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
	linux-mm@kvack.org, guohanjun@huawei.com, will@kernel.org,
	linux-arch@vger.kernel.org, yuzhao@google.com, maz@kernel.org,
	steven.price@arm.com, arm@kernel.org, Dave.Martin@arm.com,
	arnd@arndb.de, suzuki.poulose@arm.com, npiggin@gmail.com,
	zhangshaokun@hisilicon.com, broonie@kernel.org,
	rostedt@goodmis.org, prime.zeng@hisilicon.com,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	xiexiangyou@huawei.com, linux-kernel@vger.kernel.org,
	aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org
Subject: Re: Re: [RFC PATCH v4 0/6] arm64: tlb: add support for TTL feature
Date: Wed, 25 Mar 2020 12:49:45 +0800	[thread overview]
Message-ID: <fb06ba92-a3ce-6925-e914-167a85837f27@huawei.com> (raw)
In-Reply-To: <20200324150155.GH20713@hirez.programming.kicks-ass.net>

Hi Peter,

On 2020/3/24 23:01, Peter Zijlstra wrote:
> On Tue, Mar 24, 2020 at 09:45:28PM +0800, Zhenyu Ye wrote:
>> In order to reduce the cost of TLB invalidation, the ARMv8.4 TTL
>> feature allows TLBs to be issued with a level allowing for quicker
>> invalidation.  This series provide support for this feature. 
>>
>> Patch 1 and Patch 2 was provided by Marc on his NV series[1] patches,
>> which detect the TTL feature and add __tlbi_level interface.
> 
> I realy hate how it makes vma->vm_flags more important for tlbi.
> 

Thanks for your review.

The tlbi interfaces only have two parameters: vma and addr. If we
try to not use vma->vm_flags, we may should have to add a parameter
to some of these interfaces(such as flush_tlb_range), which are
common to all architectures.

I'm not sure if this is feasible, because this feature is only
supported by ARM64 currently.


Thanks,
Zhenyu


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-25  4:50 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24 13:45 [RFC PATCH v4 0/6] arm64: tlb: add support for TTL feature Zhenyu Ye
2020-03-24 13:45 ` Zhenyu Ye
2020-03-24 13:45 ` Zhenyu Ye
2020-03-24 13:45 ` [RFC PATCH v4 1/6] arm64: Detect the ARMv8.4 " Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45 ` [RFC PATCH v4 2/6] arm64: Add level-hinted TLB invalidation helper Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45 ` [RFC PATCH v4 3/6] arm64: Add level-hinted TLB invalidation helper to tlbi_user Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 14:19   ` Marc Zyngier
2020-03-24 14:19     ` Marc Zyngier
2020-03-24 14:19     ` Marc Zyngier
2020-03-25  2:47     ` Zhenyu Ye
2020-03-25  2:47       ` Zhenyu Ye
2020-03-25  2:47       ` Zhenyu Ye
2020-03-24 13:45 ` [RFC PATCH v4 4/6] mm: Add page table level flags to vm_flags Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 18:44   ` Steven Rostedt
2020-03-24 18:44     ` Steven Rostedt
2020-03-24 18:44     ` Steven Rostedt
2020-03-25  2:10     ` yezhenyu (A)
2020-03-25  2:10       ` yezhenyu (A)
2020-03-25  2:10       ` yezhenyu (A)
2020-03-25  2:10       ` yezhenyu (A)
2020-03-24 13:45 ` [RFC PATCH v4 5/6] arm64: tlb: Use translation level hint in vm_flags Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 14:45   ` Marc Zyngier
2020-03-24 14:45     ` Marc Zyngier
2020-03-24 14:45     ` Marc Zyngier
2020-03-25  8:00     ` Zhenyu Ye
2020-03-25  8:00       ` Zhenyu Ye
2020-03-25  8:00       ` Zhenyu Ye
2020-03-25  8:00       ` Zhenyu Ye
2020-03-25 14:13       ` Marc Zyngier
2020-03-25 14:13         ` Marc Zyngier
2020-03-26  7:11         ` Zhenyu Ye
2020-03-26  7:11           ` Zhenyu Ye
2020-03-26  7:11           ` Zhenyu Ye
2020-03-24 13:45 ` [RFC PATCH v4 6/6] mm: Set VM_LEVEL flags in some tlb_flush functions Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 13:45   ` Zhenyu Ye
2020-03-24 15:01 ` [RFC PATCH v4 0/6] arm64: tlb: add support for TTL feature Peter Zijlstra
2020-03-24 15:01   ` Peter Zijlstra
2020-03-24 15:01   ` Peter Zijlstra
2020-03-25  4:49   ` Zhenyu Ye [this message]
2020-03-25  4:49     ` Zhenyu Ye
2020-03-25  4:49     ` Zhenyu Ye
2020-03-25 13:32     ` Peter Zijlstra
2020-03-25 13:32       ` Peter Zijlstra
2020-03-26  7:15       ` Zhenyu Ye
2020-03-26  7:15         ` Zhenyu Ye
2020-03-26  7:15         ` Zhenyu Ye
2020-03-25 16:15 ` James Morse
2020-03-25 16:15   ` James Morse
2020-03-25 16:41   ` Peter Zijlstra
2020-03-25 16:41     ` Peter Zijlstra
2020-03-25 16:41     ` Peter Zijlstra
2020-03-26  6:45   ` Zhenyu Ye
2020-03-26  6:45     ` Zhenyu Ye
2020-03-26  6:45     ` Zhenyu Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb06ba92-a3ce-6925-e914-167a85837f27@huawei.com \
    --to=yezhenyu2@huawei.com \
    --cc=Dave.Martin@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rostedt@goodmis.org \
    --cc=steven.price@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=xiexiangyou@huawei.com \
    --cc=yuzhao@google.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.