All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}
@ 2022-02-11 11:11 Jan Beulich
  2022-02-11 11:38 ` Andrew Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-02-11 11:11 UTC (permalink / raw)
  To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné

Despite their suffixes these aren't scalar instructions, and hence the
128- and 256-bit EVEX forms may not be used without AVX512VL. Gcc11 ends
up generating such instances for simd-sg.c.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/simd.h
+++ b/tools/tests/x86_emulator/simd.h
@@ -250,7 +250,9 @@ asm ( ".macro override insn    \n\t"
 # define OVR_INT(n) OVR_BW(n); OVR_DQ(n)
 
 OVR_INT(broadcast);
+# ifdef __AVX512VL__
 OVR_SFP(broadcast);
+# endif
 OVR_SFP(comi);
 OVR_VFP(cvtdq2);
 OVR_INT(abs);



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}
  2022-02-11 11:11 [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D} Jan Beulich
@ 2022-02-11 11:38 ` Andrew Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2022-02-11 11:38 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Wei Liu, Roger Pau Monne

On 11/02/2022 11:11, Jan Beulich wrote:
> Despite their suffixes these aren't scalar instructions, and hence the
> 128- and 256-bit EVEX forms may not be used without AVX512VL. Gcc11 ends
> up generating such instances for simd-sg.c.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-11 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 11:11 [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D} Jan Beulich
2022-02-11 11:38 ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.