* [PATCH] fcoe: fix io path allocation
@ 2020-08-07 20:23 Mike Christie
2020-08-07 22:41 ` Lee Duncan
2020-08-18 3:12 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Mike Christie @ 2020-08-07 20:23 UTC (permalink / raw)
To: martin.petersen, linux-scsi, james.bottomley; +Cc: Hannes Reinecke
ixgbe_fcoe_ddp_setup can be called from the main IO path and is called
with a spin_lock held, so we have to use GFP_ATOMIC allocation instead
of GFP_KERNEL.
Signed-off-by: Mike Christie <michael.christie@oracle.com>
cc: Hannes Reinecke <hare@suse.de>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
index ec7a11d..9e70b9a 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
@@ -192,7 +192,7 @@ static int ixgbe_fcoe_ddp_setup(struct net_device *netdev, u16 xid,
}
/* alloc the udl from per cpu ddp pool */
- ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_KERNEL, &ddp->udp);
+ ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_ATOMIC, &ddp->udp);
if (!ddp->udl) {
e_err(drv, "failed allocated ddp context\n");
goto out_noddp_unmap;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fcoe: fix io path allocation
2020-08-07 20:23 [PATCH] fcoe: fix io path allocation Mike Christie
@ 2020-08-07 22:41 ` Lee Duncan
2020-08-18 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Lee Duncan @ 2020-08-07 22:41 UTC (permalink / raw)
To: Mike Christie, martin.petersen, linux-scsi, james.bottomley
Cc: Hannes Reinecke
On 8/7/20 1:23 PM, Mike Christie wrote:
> ixgbe_fcoe_ddp_setup can be called from the main IO path and is called
> with a spin_lock held, so we have to use GFP_ATOMIC allocation instead
> of GFP_KERNEL.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> cc: Hannes Reinecke <hare@suse.de>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> index ec7a11d..9e70b9a 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> @@ -192,7 +192,7 @@ static int ixgbe_fcoe_ddp_setup(struct net_device *netdev, u16 xid,
> }
>
> /* alloc the udl from per cpu ddp pool */
> - ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_KERNEL, &ddp->udp);
> + ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_ATOMIC, &ddp->udp);
> if (!ddp->udl) {
> e_err(drv, "failed allocated ddp context\n");
> goto out_noddp_unmap;
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fcoe: fix io path allocation
2020-08-07 20:23 [PATCH] fcoe: fix io path allocation Mike Christie
2020-08-07 22:41 ` Lee Duncan
@ 2020-08-18 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-08-18 3:12 UTC (permalink / raw)
To: linux-scsi, james.bottomley, Mike Christie
Cc: Martin K . Petersen, Hannes Reinecke
On Fri, 7 Aug 2020 15:23:33 -0500, Mike Christie wrote:
> ixgbe_fcoe_ddp_setup can be called from the main IO path and is called
> with a spin_lock held, so we have to use GFP_ATOMIC allocation instead
> of GFP_KERNEL.
Applied to 5.9/scsi-fixes, thanks!
[1/1] scsi: fcoe: Fix I/O path allocation
https://git.kernel.org/mkp/scsi/c/fa39ab5184d6
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 20:23 [PATCH] fcoe: fix io path allocation Mike Christie
2020-08-07 22:41 ` Lee Duncan
2020-08-18 3:12 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.