From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>, Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Manikanta Maddireddy <mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Vidya Sagar <vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Date: Mon, 4 May 2020 23:55:09 +0300 [thread overview] Message-ID: <fb261f0c-157c-b97c-b58f-057b053f8444@gmail.com> (raw) In-Reply-To: <20200504154226.GA614153@ulmo> 04.05.2020 18:42, Thierry Reding пишет: > On Sat, May 02, 2020 at 05:40:35PM +0300, Dmitry Osipenko wrote: >> 27.04.2020 18:31, Wolfram Sang пишет: >>> >>>> Yes, that bug should be fixed anyway. But that doesn't justify breaking >>>> suspend/resume completely, which *is* a regression. >>>> >>>> Look, I'm not saying that we should drop this patch altogether. All I'm >>>> saying is that we should postpone it so that we can: a) get suspend and >>>> resume working again (and by doing so make sure no other suspend/resume >>>> regressions silently creep in, because that always seems to happen when >>>> you're not looking) and b) fix any preexisting issues without possibly >>>> scrambling the result with this perhaps unrelated fix. >>>> >>>> So, again, I think the safest road forward is to back this one out for >>>> now, fix whatever this other bug is and once suspend/resume is working >>>> properly again we can revisit this patch based on a known-good baseline. >>> >>> I am with you here. I want to add that the proper fix should be >>> developed without thinking too much about stable in the first place. >>> *When* we have a proper working fix, then we can think about making it >>> "more" suitable for backporting. Yet, it may also be a result that older >>> kernels need a different solution. Or have no solution at all, in case >>> they can't do atomic_transfers and this is needed. >>> >>> D'accord? >>> >> >> I saw that you submitted the revert of the patches for 5.7, hopefully it >> won't result in putting the PCIe driver problem into the back burner. >> I'll try not to forget about these patches to resubmit them later on, >> once the problem will be resolved :) > > I can put these two patches into a local development branch to keep > track of them. From what I said earlier, it looks like it would be fine > to apply these if we also make that runtime PM change (i.e. drop force > runtime PM and instead manually invoke runtime PM callbacks, which seems > to be in line with what the PM maintainers suggest, as pointed out > elsewhere in this thread). > > How about if I put all of that into a branch and push it to linux-next > so that we can get some broader testing? I've already run it through our > internal test system, which, while not perfect, is the broadest system I > am aware of, and all tests came back positive. Will be great. > I'm not exactly sure I see a real issue with the PCIe driver after those > patches are applied. The regulator errors are gone (presumably because > the regulators now do get turned off properly) and I don't observe any > other issues. That's probably because this I2C patch removed the "completion done after timeout" message. You may try to re-add the message, it should pop up on the PCIe driver's suspension. The IRQF_NO_SUSPEND flag should fix it. My assumption was that it should be always fine handle interrupt after timeout, and thus, the message isn't really needed. But this wasn't a correct assumption as we see now, so it should be better to keep the message for the debugging purposes, maybe turn it into dev_info_once().
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Wolfram Sang <wsa@the-dreams.de>, Jon Hunter <jonathanh@nvidia.com>, Laxman Dewangan <ldewangan@nvidia.com>, Manikanta Maddireddy <mmaddireddy@nvidia.com>, Vidya Sagar <vidyas@nvidia.com>, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Date: Mon, 4 May 2020 23:55:09 +0300 [thread overview] Message-ID: <fb261f0c-157c-b97c-b58f-057b053f8444@gmail.com> (raw) In-Reply-To: <20200504154226.GA614153@ulmo> 04.05.2020 18:42, Thierry Reding пишет: > On Sat, May 02, 2020 at 05:40:35PM +0300, Dmitry Osipenko wrote: >> 27.04.2020 18:31, Wolfram Sang пишет: >>> >>>> Yes, that bug should be fixed anyway. But that doesn't justify breaking >>>> suspend/resume completely, which *is* a regression. >>>> >>>> Look, I'm not saying that we should drop this patch altogether. All I'm >>>> saying is that we should postpone it so that we can: a) get suspend and >>>> resume working again (and by doing so make sure no other suspend/resume >>>> regressions silently creep in, because that always seems to happen when >>>> you're not looking) and b) fix any preexisting issues without possibly >>>> scrambling the result with this perhaps unrelated fix. >>>> >>>> So, again, I think the safest road forward is to back this one out for >>>> now, fix whatever this other bug is and once suspend/resume is working >>>> properly again we can revisit this patch based on a known-good baseline. >>> >>> I am with you here. I want to add that the proper fix should be >>> developed without thinking too much about stable in the first place. >>> *When* we have a proper working fix, then we can think about making it >>> "more" suitable for backporting. Yet, it may also be a result that older >>> kernels need a different solution. Or have no solution at all, in case >>> they can't do atomic_transfers and this is needed. >>> >>> D'accord? >>> >> >> I saw that you submitted the revert of the patches for 5.7, hopefully it >> won't result in putting the PCIe driver problem into the back burner. >> I'll try not to forget about these patches to resubmit them later on, >> once the problem will be resolved :) > > I can put these two patches into a local development branch to keep > track of them. From what I said earlier, it looks like it would be fine > to apply these if we also make that runtime PM change (i.e. drop force > runtime PM and instead manually invoke runtime PM callbacks, which seems > to be in line with what the PM maintainers suggest, as pointed out > elsewhere in this thread). > > How about if I put all of that into a branch and push it to linux-next > so that we can get some broader testing? I've already run it through our > internal test system, which, while not perfect, is the broadest system I > am aware of, and all tests came back positive. Will be great. > I'm not exactly sure I see a real issue with the PCIe driver after those > patches are applied. The regulator errors are gone (presumably because > the regulators now do get turned off properly) and I don't observe any > other issues. That's probably because this I2C patch removed the "completion done after timeout" message. You may try to re-add the message, it should pop up on the PCIe driver's suspension. The IRQF_NO_SUSPEND flag should fix it. My assumption was that it should be always fine handle interrupt after timeout, and thus, the message isn't really needed. But this wasn't a correct assumption as we see now, so it should be better to keep the message for the debugging purposes, maybe turn it into dev_info_once().
next prev parent reply other threads:[~2020-05-04 20:55 UTC|newest] Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-24 19:12 [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Dmitry Osipenko 2020-03-24 19:12 ` [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Dmitry Osipenko [not found] ` <20200324191217.1829-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-15 16:31 ` Wolfram Sang 2020-04-15 16:31 ` Wolfram Sang 2020-04-20 19:53 ` Jon Hunter 2020-04-20 19:53 ` Jon Hunter [not found] ` <1e259e22-c300-663a-e537-18d854e0f478-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-20 22:11 ` Dmitry Osipenko 2020-04-20 22:11 ` Dmitry Osipenko [not found] ` <f59ba318-8e99-c486-fa4d-1ee28a7b203d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-21 0:32 ` Dmitry Osipenko 2020-04-21 0:32 ` Dmitry Osipenko 2020-04-21 9:49 ` Jon Hunter 2020-04-21 9:49 ` Jon Hunter 2020-04-21 12:39 ` Manikanta Maddireddy 2020-04-21 12:39 ` Manikanta Maddireddy 2020-04-21 13:08 ` Jon Hunter 2020-04-21 13:08 ` Jon Hunter [not found] ` <1a5e5455-597f-7724-f992-32a2492c1e24-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-21 13:49 ` Manikanta Maddireddy 2020-04-21 13:49 ` Manikanta Maddireddy [not found] ` <8cd085e1-f9fd-6ec0-9f7a-d5463f176a63-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-21 13:25 ` Dmitry Osipenko 2020-04-21 13:25 ` Dmitry Osipenko [not found] ` <db1132ce-53a8-371c-98e0-cb7cd91d5c7d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-21 14:40 ` Jon Hunter 2020-04-21 14:40 ` Jon Hunter 2020-04-21 15:08 ` Dmitry Osipenko [not found] ` <bba0a93a-8ec4-eda6-97f3-fb2ab0b9b503-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-21 19:42 ` Jon Hunter 2020-04-21 19:42 ` Jon Hunter [not found] ` <6f07e5c8-7916-7ea2-2fe7-d05f8f011471-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-22 13:40 ` Dmitry Osipenko 2020-04-22 13:40 ` Dmitry Osipenko [not found] ` <77a31b2f-f525-ba9e-f1ae-2b474465bde4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-22 13:59 ` Jon Hunter 2020-04-22 13:59 ` Jon Hunter [not found] ` <470b4de4-e98a-1bdc-049e-6259ad603507-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-22 14:07 ` Dmitry Osipenko 2020-04-22 14:07 ` Dmitry Osipenko 2020-04-23 10:56 ` Jon Hunter 2020-04-23 10:56 ` Jon Hunter [not found] ` <a5198024-7273-74c4-b4f4-3a29d042bc36-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-23 16:33 ` Dmitry Osipenko 2020-04-23 16:33 ` Dmitry Osipenko [not found] ` <f8fb1f7f-2497-033e-ff2c-c86c6caa9706-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-24 7:10 ` Jon Hunter 2020-04-24 7:10 ` Jon Hunter [not found] ` <fd1ca178-1ea3-851f-20a6-10bf00453ce3-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-24 14:45 ` Dmitry Osipenko 2020-04-24 14:45 ` Dmitry Osipenko [not found] ` <a5734f19-254e-b6bc-e791-fa1ac63f11a4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-24 15:19 ` Jon Hunter 2020-04-24 15:19 ` Jon Hunter [not found] ` <79f6560e-dbb5-0ae1-49f8-cf1cd95396ec-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-27 7:48 ` Thierry Reding 2020-04-27 7:48 ` Thierry Reding 2020-04-27 8:44 ` Wolfram Sang 2020-04-27 8:44 ` Wolfram Sang 2020-04-27 9:07 ` Dmitry Osipenko 2020-04-27 9:07 ` Dmitry Osipenko 2020-04-27 10:35 ` Wolfram Sang 2020-04-27 10:50 ` Thierry Reding 2020-04-27 15:32 ` Thierry Reding 2020-04-27 15:32 ` Thierry Reding 2020-04-27 16:02 ` Dmitry Osipenko [not found] ` <820200ce-17f3-18c0-6f79-3e582f45492d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 10:49 ` Thierry Reding 2020-04-27 10:49 ` Thierry Reding 2020-04-27 9:52 ` Dmitry Osipenko [not found] ` <c1190858-eaea-8e94-b4d1-1cf28076c330-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 10:38 ` Wolfram Sang 2020-04-27 10:38 ` Wolfram Sang 2020-04-27 13:15 ` Dmitry Osipenko 2020-04-27 14:19 ` Thierry Reding 2020-04-27 15:31 ` Wolfram Sang 2020-04-27 15:31 ` Wolfram Sang 2020-05-02 14:40 ` Dmitry Osipenko 2020-05-02 14:40 ` Dmitry Osipenko [not found] ` <e5a3dd07-97f5-29f1-974e-3037a01cc89c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-02 14:43 ` Wolfram Sang 2020-05-02 14:43 ` Wolfram Sang 2020-05-04 15:42 ` Thierry Reding 2020-05-04 15:42 ` Thierry Reding 2020-05-04 20:55 ` Dmitry Osipenko [this message] 2020-05-04 20:55 ` Dmitry Osipenko 2020-04-27 11:00 ` Thierry Reding 2020-04-27 11:00 ` Thierry Reding 2020-04-27 14:21 ` Dmitry Osipenko 2020-04-27 14:21 ` Dmitry Osipenko [not found] ` <3a06811c-02dc-ce72-ebef-78c3fc3f4f7c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 15:12 ` Thierry Reding 2020-04-27 15:12 ` Thierry Reding 2020-04-27 15:18 ` Dmitry Osipenko 2020-04-28 8:01 ` Jon Hunter 2020-04-28 8:01 ` Jon Hunter [not found] ` <4981d7eb-b41e-c597-04ff-3d3295804d5a-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-28 12:37 ` Dmitry Osipenko 2020-04-28 12:37 ` Dmitry Osipenko [not found] ` <1ab276cf-c2b0-e085-49d8-b8ce3dba8fbe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-29 8:14 ` Thierry Reding 2020-04-29 8:14 ` Thierry Reding 2020-04-29 8:55 ` Thierry Reding 2020-04-29 12:35 ` Dmitry Osipenko [not found] ` <9e36c4ec-ca02-bd15-d765-15635f09db4b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-29 13:57 ` Jon Hunter 2020-04-29 13:57 ` Jon Hunter [not found] ` <7442f4cd-6406-41f6-5c9b-932bff8ad5b2-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-29 14:46 ` Dmitry Osipenko 2020-04-29 14:46 ` Dmitry Osipenko [not found] ` <5863e364-480e-7839-c42b-73a7f6990a30-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-29 16:24 ` Thierry Reding 2020-04-29 16:24 ` Thierry Reding 2020-04-29 17:02 ` Dmitry Osipenko 2020-04-29 17:02 ` Dmitry Osipenko 2020-04-29 16:30 ` Thierry Reding 2020-04-29 16:54 ` Dmitry Osipenko 2020-04-29 16:54 ` Dmitry Osipenko [not found] ` <bd622667-9364-abfa-ad98-5ed51919ca09-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-29 17:34 ` Dmitry Osipenko 2020-04-29 17:34 ` Dmitry Osipenko 2020-04-27 12:46 ` Dmitry Osipenko 2020-04-27 12:46 ` Dmitry Osipenko [not found] ` <da5985f4-44b3-336d-207d-4c0388806f95-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 14:13 ` Dmitry Osipenko 2020-04-27 14:13 ` Dmitry Osipenko [not found] ` <5fc71168-e4ac-11f6-dbf1-e80f4fae8d1a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 14:45 ` Dmitry Osipenko 2020-04-27 14:45 ` Dmitry Osipenko [not found] ` <090241c4-e026-aea4-e1e9-a2a661b2c27e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-27 15:38 ` Dmitry Osipenko 2020-04-27 15:38 ` Dmitry Osipenko [not found] ` <9a3d283c-d4ff-c55a-3ebf-4e08d35792ec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-28 8:02 ` Jon Hunter 2020-04-28 8:02 ` Jon Hunter [not found] ` <f78bb10c-0744-4a23-c584-0212dd9fb491-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-28 23:12 ` Dmitry Osipenko 2020-04-28 23:12 ` Dmitry Osipenko 2020-04-21 15:18 ` Dmitry Osipenko [not found] ` <93b738f2-ccf2-68ed-3ca5-30945bd40521-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-21 15:34 ` Jon Hunter 2020-04-21 15:34 ` Jon Hunter [not found] ` <61c9f5a7-3a48-8200-1cfe-d5d0524511f7-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-04-21 19:07 ` Dmitry Osipenko 2020-04-21 19:07 ` Dmitry Osipenko 2020-04-28 13:43 ` Dmitry Osipenko 2020-03-24 19:12 ` [PATCH v2 2/2] i2c: tegra: Synchronize DMA before termination Dmitry Osipenko [not found] ` <20200324191217.1829-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-15 16:31 ` Wolfram Sang 2020-04-15 16:31 ` Wolfram Sang 2020-04-15 11:45 ` [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Wolfram Sang 2020-04-15 14:14 ` Dmitry Osipenko 2020-04-15 14:14 ` Dmitry Osipenko [not found] ` <87f18a67-5aec-b5df-9d8f-341f03ff3a72-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-15 16:23 ` Wolfram Sang 2020-04-15 16:23 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fb261f0c-157c-b97c-b58f-057b053f8444@gmail.com \ --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.