* [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
@ 2017-11-28 12:45 ` Andrii Vladyka
0 siblings, 0 replies; 6+ messages in thread
From: Andrii Vladyka @ 2017-11-28 12:45 UTC (permalink / raw)
To: samuel, gregkh; +Cc: netdev, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
irlan_seq_stop() for sparse
Signed-off-by: Andrii Vladyka <tulup@mail.ru
<https://e.mail.ru/compose?To=tulup@mail.ru>>
[-- Attachment #2: task16.patch --]
[-- Type: text/plain, Size: 750 bytes --]
diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
index fdcd714..832df11 100644
--- a/drivers/staging/irda/net/irlan/irlan_common.c
+++ b/drivers/staging/irda/net/irlan/irlan_common.c
@@ -1090,6 +1090,7 @@ int irlan_extract_param(__u8 *buf, char *name, char *value, __u16 *len)
* or NULL if end of file
*/
static void *irlan_seq_start(struct seq_file *seq, loff_t *pos)
+ __acquires(RCU)
{
rcu_read_lock();
return seq_list_start_head(&irlans, *pos);
@@ -1103,6 +1104,7 @@ static void *irlan_seq_next(struct seq_file *seq, void *v, loff_t *pos)
/* End of reading /proc file */
static void irlan_seq_stop(struct seq_file *seq, void *v)
+ __releases(RCU)
{
rcu_read_unlock();
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
@ 2017-11-28 12:45 ` Andrii Vladyka
0 siblings, 0 replies; 6+ messages in thread
From: Andrii Vladyka @ 2017-11-28 12:45 UTC (permalink / raw)
To: samuel, gregkh; +Cc: devel, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
irlan_seq_stop() for sparse
Signed-off-by: Andrii Vladyka <tulup@mail.ru
<https://e.mail.ru/compose?To=tulup@mail.ru>>
[-- Attachment #2: task16.patch --]
[-- Type: text/plain, Size: 750 bytes --]
diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
index fdcd714..832df11 100644
--- a/drivers/staging/irda/net/irlan/irlan_common.c
+++ b/drivers/staging/irda/net/irlan/irlan_common.c
@@ -1090,6 +1090,7 @@ int irlan_extract_param(__u8 *buf, char *name, char *value, __u16 *len)
* or NULL if end of file
*/
static void *irlan_seq_start(struct seq_file *seq, loff_t *pos)
+ __acquires(RCU)
{
rcu_read_lock();
return seq_list_start_head(&irlans, *pos);
@@ -1103,6 +1104,7 @@ static void *irlan_seq_next(struct seq_file *seq, void *v, loff_t *pos)
/* End of reading /proc file */
static void irlan_seq_stop(struct seq_file *seq, void *v)
+ __releases(RCU)
{
rcu_read_unlock();
}
[-- Attachment #3: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
2017-11-28 12:45 ` Andrii Vladyka
@ 2017-11-28 13:05 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-11-28 13:05 UTC (permalink / raw)
To: Andrii Vladyka; +Cc: samuel, devel, netdev, linux-kernel
On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote:
> Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
> irlan_seq_stop() for sparse
>
> Signed-off-by: Andrii Vladyka <tulup@mail.ru
> <https://e.mail.ru/compose?To=tulup@mail.ru>>
Something went really wrong here with your email address :(
> diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
> index fdcd714..832df11 100644
> --- a/drivers/staging/irda/net/irlan/irlan_common.c
> +++ b/drivers/staging/irda/net/irlan/irlan_common.c
Did you read drivers/staging/irda/TODO?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
@ 2017-11-28 13:05 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-11-28 13:05 UTC (permalink / raw)
To: Andrii Vladyka; +Cc: devel, netdev, samuel, linux-kernel
On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote:
> Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
> irlan_seq_stop() for sparse
>
> Signed-off-by: Andrii Vladyka <tulup@mail.ru
> <https://e.mail.ru/compose?To=tulup@mail.ru>>
Something went really wrong here with your email address :(
> diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
> index fdcd714..832df11 100644
> --- a/drivers/staging/irda/net/irlan/irlan_common.c
> +++ b/drivers/staging/irda/net/irlan/irlan_common.c
Did you read drivers/staging/irda/TODO?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
2017-11-28 13:05 ` Greg KH
@ 2017-11-28 13:30 ` Andrii
-1 siblings, 0 replies; 6+ messages in thread
From: Andrii @ 2017-11-28 13:30 UTC (permalink / raw)
To: Greg KH; +Cc: samuel, devel, netdev, linux-kernel
On 11/28/2017 3:05 PM, Greg KH wrote:
> On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote:
>> Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
>> irlan_seq_stop() for sparse
>>
>> Signed-off-by: Andrii Vladyka <tulup@mail.ru
>> <https://e.mail.ru/compose?To=tulup@mail.ru>>
> Something went really wrong here with your email address :(
>
>> diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
>> index fdcd714..832df11 100644
>> --- a/drivers/staging/irda/net/irlan/irlan_common.c
>> +++ b/drivers/staging/irda/net/irlan/irlan_common.c
> Did you read drivers/staging/irda/TODO?
What a shame... Thanks.
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse
@ 2017-11-28 13:30 ` Andrii
0 siblings, 0 replies; 6+ messages in thread
From: Andrii @ 2017-11-28 13:30 UTC (permalink / raw)
To: Greg KH; +Cc: devel, netdev, samuel, linux-kernel
On 11/28/2017 3:05 PM, Greg KH wrote:
> On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote:
>> Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in
>> irlan_seq_stop() for sparse
>>
>> Signed-off-by: Andrii Vladyka <tulup@mail.ru
>> <https://e.mail.ru/compose?To=tulup@mail.ru>>
> Something went really wrong here with your email address :(
>
>> diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c
>> index fdcd714..832df11 100644
>> --- a/drivers/staging/irda/net/irlan/irlan_common.c
>> +++ b/drivers/staging/irda/net/irlan/irlan_common.c
> Did you read drivers/staging/irda/TODO?
What a shame... Thanks.
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-28 18:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 12:45 [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse Andrii Vladyka
2017-11-28 12:45 ` Andrii Vladyka
2017-11-28 13:05 ` Greg KH
2017-11-28 13:05 ` Greg KH
2017-11-28 13:30 ` Andrii
2017-11-28 13:30 ` Andrii
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.