* [PATCH] xfs_db: add -d to short help for write command
@ 2018-07-24 1:25 Eric Sandeen
2018-07-24 1:49 ` Darrick J. Wong
2018-07-24 16:50 ` Bill O'Donnell
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2018-07-24 1:25 UTC (permalink / raw)
To: linux-xfs
And note in the man page that -c and -d are exclusive.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/write.c b/db/write.c
index 5ef76bcd..bbaa609d 100644
--- a/db/write.c
+++ b/db/write.c
@@ -38,7 +38,7 @@ static int write_f(int argc, char **argv);
static void write_help(void);
static const cmdinfo_t write_cmd =
- { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."),
+ { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."),
N_("write value to disk"), write_help };
void
diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8
index 10f2beb9..a1ee3514 100644
--- a/man/man8/xfs_db.8
+++ b/man/man8/xfs_db.8
@@ -837,7 +837,7 @@ and
bits respectively, and their string equivalent reported
(but no modifications are made).
.TP
-.BI "write [\-c] [\-d] [" "field value" "] ..."
+.BI "write [\-c|\-d] [" "field value" "] ..."
Write a value to disk.
Specific fields can be set in structures (struct mode),
or a block can be set to data values (data mode),
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_db: add -d to short help for write command
2018-07-24 1:25 [PATCH] xfs_db: add -d to short help for write command Eric Sandeen
@ 2018-07-24 1:49 ` Darrick J. Wong
2018-07-24 16:50 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-07-24 1:49 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Jul 23, 2018 at 06:25:27PM -0700, Eric Sandeen wrote:
> And note in the man page that -c and -d are exclusive.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/db/write.c b/db/write.c
> index 5ef76bcd..bbaa609d 100644
> --- a/db/write.c
> +++ b/db/write.c
> @@ -38,7 +38,7 @@ static int write_f(int argc, char **argv);
> static void write_help(void);
>
> static const cmdinfo_t write_cmd =
> - { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."),
> + { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."),
> N_("write value to disk"), write_help };
>
> void
> diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8
> index 10f2beb9..a1ee3514 100644
> --- a/man/man8/xfs_db.8
> +++ b/man/man8/xfs_db.8
> @@ -837,7 +837,7 @@ and
> bits respectively, and their string equivalent reported
> (but no modifications are made).
> .TP
> -.BI "write [\-c] [\-d] [" "field value" "] ..."
> +.BI "write [\-c|\-d] [" "field value" "] ..."
> Write a value to disk.
> Specific fields can be set in structures (struct mode),
> or a block can be set to data values (data mode),
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_db: add -d to short help for write command
2018-07-24 1:25 [PATCH] xfs_db: add -d to short help for write command Eric Sandeen
2018-07-24 1:49 ` Darrick J. Wong
@ 2018-07-24 16:50 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2018-07-24 16:50 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Jul 23, 2018 at 06:25:27PM -0700, Eric Sandeen wrote:
> And note in the man page that -c and -d are exclusive.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/db/write.c b/db/write.c
> index 5ef76bcd..bbaa609d 100644
> --- a/db/write.c
> +++ b/db/write.c
> @@ -38,7 +38,7 @@ static int write_f(int argc, char **argv);
> static void write_help(void);
>
> static const cmdinfo_t write_cmd =
> - { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."),
> + { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."),
> N_("write value to disk"), write_help };
>
> void
> diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8
> index 10f2beb9..a1ee3514 100644
> --- a/man/man8/xfs_db.8
> +++ b/man/man8/xfs_db.8
> @@ -837,7 +837,7 @@ and
> bits respectively, and their string equivalent reported
> (but no modifications are made).
> .TP
> -.BI "write [\-c] [\-d] [" "field value" "] ..."
> +.BI "write [\-c|\-d] [" "field value" "] ..."
> Write a value to disk.
> Specific fields can be set in structures (struct mode),
> or a block can be set to data values (data mode),
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-24 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 1:25 [PATCH] xfs_db: add -d to short help for write command Eric Sandeen
2018-07-24 1:49 ` Darrick J. Wong
2018-07-24 16:50 ` Bill O'Donnell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.