* [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
@ 2019-01-03 1:19 ` Ming Lei
0 siblings, 0 replies; 6+ messages in thread
From: Ming Lei @ 2019-01-03 1:19 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Ming Lei, Anatoly Pugachev, David Miller, sparclinux
vdc_blk_queue_start() may be called from irq context, so we can't run
queue via blk_mq_start_hw_queues() since we never allow to run queue
from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
this issue.
Fixes: fa182a1fa97dff56cd ("sunvdc: convert to blk-mq")
Reported-by: Anatoly Pugachev <matorola@gmail.com>
Tested-by: Anatoly Pugachev <matorola@gmail.com>
Cc: Anatoly Pugachev <matorola@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/block/sunvdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 9c0553dd13e7..ab7f7ab4c472 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -181,7 +181,7 @@ static void vdc_blk_queue_start(struct vdc_port *port)
* allocated a disk.
*/
if (port->disk && vdc_tx_dring_avail(dr) * 100 / VDC_TX_RING_SIZE >= 50)
- blk_mq_start_hw_queues(port->disk->queue);
+ blk_mq_start_stopped_hw_queues(port->disk->queue, true);
}
static void vdc_finish(struct vio_driver_state *vio, int err, int waiting_for)
--
2.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
@ 2019-01-03 1:19 ` Ming Lei
0 siblings, 0 replies; 6+ messages in thread
From: Ming Lei @ 2019-01-03 1:19 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Ming Lei, Anatoly Pugachev, David Miller, sparclinux
vdc_blk_queue_start() may be called from irq context, so we can't run
queue via blk_mq_start_hw_queues() since we never allow to run queue
from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
this issue.
Fixes: fa182a1fa97dff56cd ("sunvdc: convert to blk-mq")
Reported-by: Anatoly Pugachev <matorola@gmail.com>
Tested-by: Anatoly Pugachev <matorola@gmail.com>
Cc: Anatoly Pugachev <matorola@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/block/sunvdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 9c0553dd13e7..ab7f7ab4c472 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -181,7 +181,7 @@ static void vdc_blk_queue_start(struct vdc_port *port)
* allocated a disk.
*/
if (port->disk && vdc_tx_dring_avail(dr) * 100 / VDC_TX_RING_SIZE >= 50)
- blk_mq_start_hw_queues(port->disk->queue);
+ blk_mq_start_stopped_hw_queues(port->disk->queue, true);
}
static void vdc_finish(struct vio_driver_state *vio, int err, int waiting_for)
--
2.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
2019-01-03 1:19 ` Ming Lei
@ 2019-01-03 1:49 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-01-03 1:49 UTC (permalink / raw)
To: ming.lei; +Cc: axboe, linux-block, matorola, sparclinux
From: Ming Lei <ming.lei@redhat.com>
Date: Thu, 3 Jan 2019 09:19:48 +0800
> vdc_blk_queue_start() may be called from irq context, so we can't run
> queue via blk_mq_start_hw_queues() since we never allow to run queue
> from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
> this issue.
>
> Fixes: fa182a1fa97dff56cd ("sunvdc: convert to blk-mq")
> Reported-by: Anatoly Pugachev <matorola@gmail.com>
> Tested-by: Anatoly Pugachev <matorola@gmail.com>
> Cc: Anatoly Pugachev <matorola@gmail.com>
> Cc: David Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
@ 2019-01-03 1:49 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-01-03 1:49 UTC (permalink / raw)
To: ming.lei; +Cc: axboe, linux-block, matorola, sparclinux
From: Ming Lei <ming.lei@redhat.com>
Date: Thu, 3 Jan 2019 09:19:48 +0800
> vdc_blk_queue_start() may be called from irq context, so we can't run
> queue via blk_mq_start_hw_queues() since we never allow to run queue
> from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
> this issue.
>
> Fixes: fa182a1fa97dff56cd ("sunvdc: convert to blk-mq")
> Reported-by: Anatoly Pugachev <matorola@gmail.com>
> Tested-by: Anatoly Pugachev <matorola@gmail.com>
> Cc: Anatoly Pugachev <matorola@gmail.com>
> Cc: David Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
2019-01-03 1:19 ` Ming Lei
@ 2019-01-03 15:22 ` Jens Axboe
-1 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2019-01-03 15:22 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-block, Anatoly Pugachev, David Miller, sparclinux
On 1/2/19 6:19 PM, Ming Lei wrote:
> vdc_blk_queue_start() may be called from irq context, so we can't run
> queue via blk_mq_start_hw_queues() since we never allow to run queue
> from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
> this issue.
Thanks Ming, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: sunvdc: don't run hw queue synchronously from irq context
@ 2019-01-03 15:22 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2019-01-03 15:22 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-block, Anatoly Pugachev, David Miller, sparclinux
On 1/2/19 6:19 PM, Ming Lei wrote:
> vdc_blk_queue_start() may be called from irq context, so we can't run
> queue via blk_mq_start_hw_queues() since we never allow to run queue
> from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix
> this issue.
Thanks Ming, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-03 15:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 1:19 [PATCH] block: sunvdc: don't run hw queue synchronously from irq context Ming Lei
2019-01-03 1:19 ` Ming Lei
2019-01-03 1:49 ` David Miller
2019-01-03 1:49 ` David Miller
2019-01-03 15:22 ` Jens Axboe
2019-01-03 15:22 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.