[meta-java][PATCH] icedtea7-native: host gcc-9, extra CFLAGS needed

[meta-java][PATCH] icedtea7-native: host gcc-9, extra CFLAGS needed

[Robert Berger]

Signed-off-by: Robert Berger <robert.berger@ReliableEmbeddedSystems.com>
---
 recipes-core/icedtea/icedtea7-native.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/recipes-core/icedtea/icedtea7-native.inc b/recipes-core/icedtea/icedtea7-native.inc
index 8d0dc71..b9ad2bd 100644
--- a/recipes-core/icedtea/icedtea7-native.inc
+++ b/recipes-core/icedtea/icedtea7-native.inc
@@ -28,6 +28,11 @@ CXX_append = " -std=gnu++98"
 # WORKAROUND: ignore errors from new compilers
 CFLAGS_append = " -Wno-error=stringop-overflow -Wno-error=return-type"
 
+# oe.utils.get_host_compiler_version returns "gcc, 9.2" and we want -> "9"
+HOST_COMPILER_MAJOR="${@oe.utils.get_host_compiler_version(d)[1].split(".", 2)[0]}"
+# if compiler version 9 detected, add more CFLAGS
+CFLAGS_append = " ${@oe.utils.conditional('HOST_COMPILER_MAJOR', '9', '-Wno-error=format-overflow', '', d)}"
+
 inherit native java autotools pkgconfig
 inherit openjdk-build-helper
 inherit python3native
-- 
2.17.1

Re: [meta-java] icedtea7-native: host gcc-9, extra CFLAGS needed

[Robert Berger]

Hi,

My comments are in-line.

On 08/05/2020 19:10, Richard Leitner wrote:
> Hi Robert,
> thanks for the patch!
> 
> One question regarding your E-Mail Addresses: Are you sure
> <oecore.mailinglist@gmail.com> should  be your author address, or should
> it be <robert.berger@ReliableEmbeddedSystems.com> ?

It should be

From: Robert Berger <robert.berger@ReliableEmbeddedSystems.com>

I just sent out v2 - hopefully it's OK now.

please check

> 
> regards;rl

Regards,

Robert

> 
> On Fri, May 08, 2020 at 12:46:38PM +0300, Robert Berger wrote:
>> Signed-off-by: Robert Berger <robert.berger@ReliableEmbeddedSystems.com>
>> ---
>>   recipes-core/icedtea/icedtea7-native.inc | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/recipes-core/icedtea/icedtea7-native.inc b/recipes-core/icedtea/icedtea7-native.inc
>> index 8d0dc71..b9ad2bd 100644
>> --- a/recipes-core/icedtea/icedtea7-native.inc
>> +++ b/recipes-core/icedtea/icedtea7-native.inc
>> @@ -28,6 +28,11 @@ CXX_append = " -std=gnu++98"
>>   # WORKAROUND: ignore errors from new compilers
>>   CFLAGS_append = " -Wno-error=stringop-overflow -Wno-error=return-type"
>>   
>> +# oe.utils.get_host_compiler_version returns "gcc, 9.2" and we want -> "9"
>> +HOST_COMPILER_MAJOR="${@oe.utils.get_host_compiler_version(d)[1].split(".", 2)[0]}"
>> +# if compiler version 9 detected, add more CFLAGS
>> +CFLAGS_append = " ${@oe.utils.conditional('HOST_COMPILER_MAJOR', '9', '-Wno-error=format-overflow', '', d)}"
>> +
>>   inherit native java autotools pkgconfig
>>   inherit openjdk-build-helper
>>   inherit python3native