From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Date: Fri, 17 Apr 2020 00:15:33 +0300 [thread overview] Message-ID: <fbafa641-f2ed-22b5-eaeb-bd2726b53d0a@gmail.com> (raw) In-Reply-To: <20200416205012.GA28162-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 16.04.2020 23:50, Laurent Pinchart пишет: > Hi Dmitry, > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: >> 16.04.2020 21:52, Dmitry Osipenko пишет: >> ... >>>> May I also recommend switching to the DRM panel bridge helper ? It will >>>> simplify the code. >>> >>> Could you please clarify what is the "DRM panel bridge helper"? >>> >>> I think we won't need any additional helpers after switching to the >>> bridge connector helper, no? >> >> Actually, I now see that the panel needs to be manually attached to the >> connector. > > The DRM panel bridge helper creates a bridge from a panel (with > devm_drm_panel_bridge_add()). You can then attach that bridge to the > chain, like any other bridge, and the enable/disable operations will be > called automatically without any need to call the panel enable/disable > manually as done currently. > >> Still it's not apparent to me how to get panel out of the bridge. It >> looks like there is no such "panel helper" for the bridge API or I just >> can't find it. > > You don't need to get a panel out of the bridge. You should get the > bridge as done today, You mean "get the panel", correct? > and wrap it in a bridge with > devm_drm_panel_bridge_add(). > The lvds-codec already wraps panel into the bridge using devm_drm_panel_bridge_add() and chains it for us, please see lvds_codec_probe() / lvds_codec_attach(). Does it mean that lvds-codec is not supporting the new model? Everything works nicely using the old model, where bridge creates connector and attaches panel to it for us. [I'm still not sure what is the point to use the new model in a case of a simple chain of bridges] Using the new model, the connector isn't created by the bridge, so I need to duplicate that creation effort in the driver. Once the bridge connector is manually created, I need to attach panel to this connector, but panel is reachable only via the remote bridge (which wraps the panel). driver connector -> LVDS bridge -> panel bridge -> panel
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-tegra@vger.kernel.org, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Date: Fri, 17 Apr 2020 00:15:33 +0300 [thread overview] Message-ID: <fbafa641-f2ed-22b5-eaeb-bd2726b53d0a@gmail.com> (raw) In-Reply-To: <20200416205012.GA28162@pendragon.ideasonboard.com> 16.04.2020 23:50, Laurent Pinchart пишет: > Hi Dmitry, > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: >> 16.04.2020 21:52, Dmitry Osipenko пишет: >> ... >>>> May I also recommend switching to the DRM panel bridge helper ? It will >>>> simplify the code. >>> >>> Could you please clarify what is the "DRM panel bridge helper"? >>> >>> I think we won't need any additional helpers after switching to the >>> bridge connector helper, no? >> >> Actually, I now see that the panel needs to be manually attached to the >> connector. > > The DRM panel bridge helper creates a bridge from a panel (with > devm_drm_panel_bridge_add()). You can then attach that bridge to the > chain, like any other bridge, and the enable/disable operations will be > called automatically without any need to call the panel enable/disable > manually as done currently. > >> Still it's not apparent to me how to get panel out of the bridge. It >> looks like there is no such "panel helper" for the bridge API or I just >> can't find it. > > You don't need to get a panel out of the bridge. You should get the > bridge as done today, You mean "get the panel", correct? > and wrap it in a bridge with > devm_drm_panel_bridge_add(). > The lvds-codec already wraps panel into the bridge using devm_drm_panel_bridge_add() and chains it for us, please see lvds_codec_probe() / lvds_codec_attach(). Does it mean that lvds-codec is not supporting the new model? Everything works nicely using the old model, where bridge creates connector and attaches panel to it for us. [I'm still not sure what is the point to use the new model in a case of a simple chain of bridges] Using the new model, the connector isn't created by the bridge, so I need to duplicate that creation effort in the driver. Once the bridge connector is manually created, I need to attach panel to this connector, but panel is reachable only via the remote bridge (which wraps the panel). driver connector -> LVDS bridge -> panel bridge -> panel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-16 21:15 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-16 17:24 [PATCH v3 0/2] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko 2020-04-16 17:24 ` Dmitry Osipenko [not found] ` <20200416172405.5051-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 17:24 ` [PATCH v3 1/2] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko 2020-04-16 17:24 ` Dmitry Osipenko [not found] ` <20200416172405.5051-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 17:27 ` Laurent Pinchart 2020-04-16 17:27 ` Laurent Pinchart [not found] ` <20200416172727.GN4796-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-04-16 17:30 ` Dmitry Osipenko 2020-04-16 17:30 ` Dmitry Osipenko [not found] ` <304a2a58-0031-bf88-6290-e72ab025d8c5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 17:45 ` Laurent Pinchart 2020-04-16 17:45 ` Laurent Pinchart 2020-04-16 17:24 ` [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko 2020-04-16 17:24 ` Dmitry Osipenko [not found] ` <20200416172405.5051-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 17:41 ` Laurent Pinchart 2020-04-16 17:41 ` Laurent Pinchart [not found] ` <20200416174112.GS4796-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-04-16 18:52 ` Dmitry Osipenko 2020-04-16 18:52 ` Dmitry Osipenko [not found] ` <6275bcd3-c0b2-4c1c-1817-9e713d3747c7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 20:21 ` Dmitry Osipenko 2020-04-16 20:21 ` Dmitry Osipenko [not found] ` <7cf27640-4fdc-8617-01cb-85f4c5847bb8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 20:37 ` Sam Ravnborg 2020-04-16 20:37 ` Sam Ravnborg 2020-04-16 20:50 ` Laurent Pinchart 2020-04-16 20:50 ` Laurent Pinchart [not found] ` <20200416205012.GA28162-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-04-16 21:15 ` Dmitry Osipenko [this message] 2020-04-16 21:15 ` Dmitry Osipenko [not found] ` <fbafa641-f2ed-22b5-eaeb-bd2726b53d0a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-04-16 21:39 ` Laurent Pinchart 2020-04-16 21:39 ` Laurent Pinchart [not found] ` <20200416213919.GB28162-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-04-16 22:22 ` Dmitry Osipenko 2020-04-16 22:22 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fbafa641-f2ed-22b5-eaeb-bd2726b53d0a@gmail.com \ --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.