Re: [MPTCP] [PATCH 0/2] mptcp: simplify crypto.c

Re: [MPTCP] [PATCH 0/2] mptcp: simplify crypto.c

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]


Looks good to me.

Peter.

On Thu, 2019-07-11 at 19:12 +0200, Davide Caratti wrote:
> his series wants to simplify, and hopefully improve, random generation
> of keys and nonces in crypto.c, While at it, I removed some unneeded
> #includes on top of the file. Any feedbacks are welcome!
> 
> Note:
>  in case you think the code is ok, I will propose to squash it into
>  commit 34f09d53931a ("mptcp: Add key generation and token tree")
> 
> Changes since RFC:
>  - use get_random_bytes() instead of siphash, thanks to Florian / Mat 
> 
> Davide Caratti (2):
>   net: mptcp: remove useless #includes in crypto.c
>   net: mptcp: randomness improvements for crypto.c
> 
>  net/mptcp/crypto.c   | 77 +-------------------------------------------
>  net/mptcp/protocol.c |  1 -
>  net/mptcp/protocol.h | 11 -------
>  net/mptcp/token.c    | 49 +++-------------------------
>  4 files changed, 5 insertions(+), 133 deletions(-)
> 

[MPTCP] [PATCH 0/2] mptcp: simplify crypto.c

[Davide Caratti]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

his series wants to simplify, and hopefully improve, random generation
of keys and nonces in crypto.c, While at it, I removed some unneeded
#includes on top of the file. Any feedbacks are welcome!

Note:
 in case you think the code is ok, I will propose to squash it into
 commit 34f09d53931a ("mptcp: Add key generation and token tree")

Changes since RFC:
 - use get_random_bytes() instead of siphash, thanks to Florian / Mat 

Davide Caratti (2):
  net: mptcp: remove useless #includes in crypto.c
  net: mptcp: randomness improvements for crypto.c

 net/mptcp/crypto.c   | 77 +-------------------------------------------
 net/mptcp/protocol.c |  1 -
 net/mptcp/protocol.h | 11 -------
 net/mptcp/token.c    | 49 +++-------------------------
 4 files changed, 5 insertions(+), 133 deletions(-)

-- 
2.20.1