From: Daniel Baluta <daniel.baluta@nxp.com> To: "dongas86@gmail.com" <dongas86@gmail.com> Cc: dl-linux-imx <linux-imx@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "daniel.baluta@gmail.com" <daniel.baluta@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "S.j. Wang" <shengjiu.wang@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Subject: Re: [PATCH v2] firmware: imx: Add support to start/stop a CPU Date: Wed, 30 Jan 2019 13:12:25 +0000 [thread overview] Message-ID: <fc0ef2f1709cb678f29cd37d618e28a7ed606791.camel@nxp.com> (raw) In-Reply-To: <CAA+hA=Tz0p8Ea9f8wuqUZFkmuDrqMHj8_4sLvT8wi6qrTnaVKQ@mail.gmail.com> Thanks Aisheng for the comments! <snip> +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource, > > + bool enable, u64 address) > > +{ > > + struct imx_sc_msg_req_cpu_start msg; > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > + > > + hdr->ver = IMX_SC_RPC_VERSION; > > + hdr->svc = (uint8_t)IMX_SC_RPC_SVC_PM; > > + hdr->func = (uint8_t)IMX_SC_PM_FUNC_CPU_START; > > pls drop the unneccesary unit8_t Ok, I can do that. I had borrowed it from the already existing functions imx_sc_misc_get_control / imx_sc_misc_set_control > > > + hdr->size = 4; > > + > > + msg.address_hi = address >> 32; > > + msg.address_lo = address; > > + msg.resource = resource; > > + msg.enable = enable; > > + > > + return imx_scu_call_rpc(ipc, &msg, false); > > s/false/true Nice catch! Inded, the old API had a different semantic for this parameter. > > > +} > > +EXPORT_SYMBOL(imx_sc_pm_cpu_start); > > diff --git a/include/linux/firmware/imx/svc/misc.h > > b/include/linux/firmware/imx/svc/misc.h > > index e21c49aba92f..c03bf2a23add 100644 > > --- a/include/linux/firmware/imx/svc/misc.h > > +++ b/include/linux/firmware/imx/svc/misc.h > > @@ -52,4 +52,7 @@ int imx_sc_misc_set_control(struct imx_sc_ipc > > *ipc, u32 resource, > > int imx_sc_misc_get_control(struct imx_sc_ipc *ipc, u32 resource, > > u8 ctrl, u32 *val); > > > > +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource, > > + bool enable, u64 address); > > Nitpick: phy_addr Ok, will fix.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@nxp.com> To: "dongas86@gmail.com" <dongas86@gmail.com> Cc: Aisheng Dong <aisheng.dong@nxp.com>, "daniel.baluta@gmail.com" <daniel.baluta@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "S.j. Wang" <shengjiu.wang@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2] firmware: imx: Add support to start/stop a CPU Date: Wed, 30 Jan 2019 13:12:25 +0000 [thread overview] Message-ID: <fc0ef2f1709cb678f29cd37d618e28a7ed606791.camel@nxp.com> (raw) In-Reply-To: <CAA+hA=Tz0p8Ea9f8wuqUZFkmuDrqMHj8_4sLvT8wi6qrTnaVKQ@mail.gmail.com> Thanks Aisheng for the comments! <snip> +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource, > > + bool enable, u64 address) > > +{ > > + struct imx_sc_msg_req_cpu_start msg; > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > + > > + hdr->ver = IMX_SC_RPC_VERSION; > > + hdr->svc = (uint8_t)IMX_SC_RPC_SVC_PM; > > + hdr->func = (uint8_t)IMX_SC_PM_FUNC_CPU_START; > > pls drop the unneccesary unit8_t Ok, I can do that. I had borrowed it from the already existing functions imx_sc_misc_get_control / imx_sc_misc_set_control > > > + hdr->size = 4; > > + > > + msg.address_hi = address >> 32; > > + msg.address_lo = address; > > + msg.resource = resource; > > + msg.enable = enable; > > + > > + return imx_scu_call_rpc(ipc, &msg, false); > > s/false/true Nice catch! Inded, the old API had a different semantic for this parameter. > > > +} > > +EXPORT_SYMBOL(imx_sc_pm_cpu_start); > > diff --git a/include/linux/firmware/imx/svc/misc.h > > b/include/linux/firmware/imx/svc/misc.h > > index e21c49aba92f..c03bf2a23add 100644 > > --- a/include/linux/firmware/imx/svc/misc.h > > +++ b/include/linux/firmware/imx/svc/misc.h > > @@ -52,4 +52,7 @@ int imx_sc_misc_set_control(struct imx_sc_ipc > > *ipc, u32 resource, > > int imx_sc_misc_get_control(struct imx_sc_ipc *ipc, u32 resource, > > u8 ctrl, u32 *val); > > > > +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource, > > + bool enable, u64 address); > > Nitpick: phy_addr Ok, will fix. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 13:12 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-30 9:58 [PATCH v2] firmware: imx: Add support to start/stop a CPU Daniel Baluta 2019-01-30 9:58 ` Daniel Baluta 2019-01-30 12:46 ` Dong Aisheng 2019-01-30 12:46 ` Dong Aisheng 2019-01-30 13:12 ` Daniel Baluta [this message] 2019-01-30 13:12 ` Daniel Baluta 2019-01-30 13:14 ` Dong Aisheng 2019-01-30 13:14 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fc0ef2f1709cb678f29cd37d618e28a7ed606791.camel@nxp.com \ --to=daniel.baluta@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=daniel.baluta@gmail.com \ --cc=dongas86@gmail.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=shengjiu.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.