All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] mtd/spi: support en25s64 device
@ 2014-05-21 10:05 Shengzhou Liu
  2014-05-21 10:05 ` [PATCH 2/2] powerpc/corenet64_smp_defconfig: enable RTC support Shengzhou Liu
  2014-05-21 20:50 ` [PATCH 1/2] mtd/spi: support en25s64 device Scott Wood
  0 siblings, 2 replies; 11+ messages in thread
From: Shengzhou Liu @ 2014-05-21 10:05 UTC (permalink / raw)
  To: linuxppc-dev, scottwood; +Cc: Shengzhou Liu

Add support for EON en25s64 spi device.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
 drivers/mtd/devices/m25p80.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 7eda71d..6989311 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -745,6 +745,7 @@ static const struct spi_device_id m25p_ids[] = {
 	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
 	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
 	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
+	{ "en25s64",    INFO(0x1c3817, 0, 64 * 1024,  128, 0) },
 	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
 
 	/* ESMT */
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/2] powerpc/corenet64_smp_defconfig:  enable RTC support
  2014-05-21 10:05 [PATCH 1/2] mtd/spi: support en25s64 device Shengzhou Liu
@ 2014-05-21 10:05 ` Shengzhou Liu
  2014-05-22 22:51   ` [2/2] " Scott Wood
  2014-05-21 20:50 ` [PATCH 1/2] mtd/spi: support en25s64 device Scott Wood
  1 sibling, 1 reply; 11+ messages in thread
From: Shengzhou Liu @ 2014-05-21 10:05 UTC (permalink / raw)
  To: linuxppc-dev, scottwood; +Cc: Shengzhou Liu

Enable RTC support for DS1307, DS1374, DS3232, which is
needed on some corenet boards.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
 arch/powerpc/configs/corenet64_smp_defconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
index 63508dd..e9c9f86 100644
--- a/arch/powerpc/configs/corenet64_smp_defconfig
+++ b/arch/powerpc/configs/corenet64_smp_defconfig
@@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=y
 CONFIG_USB_STORAGE=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
+CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_CMOS=y
+CONFIG_RTC_DRV_DS1307=y
+CONFIG_RTC_DRV_DS1374=y
+CONFIG_RTC_DRV_DS3232=y
 CONFIG_EDAC=y
 CONFIG_EDAC_MM_EDAC=y
 CONFIG_DMADEVICES=y
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] mtd/spi: support en25s64 device
  2014-05-21 10:05 [PATCH 1/2] mtd/spi: support en25s64 device Shengzhou Liu
  2014-05-21 10:05 ` [PATCH 2/2] powerpc/corenet64_smp_defconfig: enable RTC support Shengzhou Liu
@ 2014-05-21 20:50 ` Scott Wood
  2014-05-23  8:20   ` Shengzhou.Liu
  1 sibling, 1 reply; 11+ messages in thread
From: Scott Wood @ 2014-05-21 20:50 UTC (permalink / raw)
  To: Shengzhou Liu; +Cc: linuxppc-dev

On Wed, 2014-05-21 at 18:05 +0800, Shengzhou Liu wrote:
> Add support for EON en25s64 spi device.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
>  drivers/mtd/devices/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 7eda71d..6989311 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -745,6 +745,7 @@ static const struct spi_device_id m25p_ids[] = {
>  	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
>  	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
>  	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
> +	{ "en25s64",    INFO(0x1c3817, 0, 64 * 1024,  128, 0) },
>  	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
>  
>  	/* ESMT */

This needs to be sent to the mtd and/or spi maintainers, not here.

What does this have to do with patch 2/2?  Don't put unrelated things in
the same patchset, especially when they're destined for different
maintainers.

-Scott

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-21 10:05 ` [PATCH 2/2] powerpc/corenet64_smp_defconfig: enable RTC support Shengzhou Liu
@ 2014-05-22 22:51   ` Scott Wood
  2014-05-23  8:03     ` Shengzhou.Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Scott Wood @ 2014-05-22 22:51 UTC (permalink / raw)
  To: Shengzhou Liu; +Cc: linuxppc-dev

On Wed, May 21, 2014 at 06:05:51PM +0800, Shengzhou Liu wrote:
> Enable RTC support for DS1307, DS1374, DS3232, which is
> needed on some corenet boards.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> 
> ---
> arch/powerpc/configs/corenet64_smp_defconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
> index 63508dd..e9c9f86 100644
> --- a/arch/powerpc/configs/corenet64_smp_defconfig
> +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> @@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=y
>  CONFIG_USB_STORAGE=y
>  CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
> +CONFIG_RTC_CLASS=y
> +CONFIG_RTC_DRV_CMOS=y
> +CONFIG_RTC_DRV_DS1307=y
> +CONFIG_RTC_DRV_DS1374=y
> +CONFIG_RTC_DRV_DS3232=y
>  CONFIG_EDAC=y
>  CONFIG_EDAC_MM_EDAC=y
>  CONFIG_DMADEVICES=y

Why only corenet64 and not corenet32?

-Scott

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-22 22:51   ` [2/2] " Scott Wood
@ 2014-05-23  8:03     ` Shengzhou.Liu
  2014-05-23 17:06       ` Scott Wood
  0 siblings, 1 reply; 11+ messages in thread
From: Shengzhou.Liu @ 2014-05-23  8:03 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, May 23, 2014 6:52 AM
> To: Liu Shengzhou-B36685
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
>=20
> > +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> > @@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=3Dy  CONFIG_USB_STORAGE=3Dy
> > CONFIG_MMC=3Dy  CONFIG_MMC_SDHCI=3Dy
> > +CONFIG_RTC_CLASS=3Dy
> > +CONFIG_RTC_DRV_CMOS=3Dy
> > +CONFIG_RTC_DRV_DS1307=3Dy
> > +CONFIG_RTC_DRV_DS1374=3Dy
> > +CONFIG_RTC_DRV_DS3232=3Dy
> >  CONFIG_EDAC=3Dy
> >  CONFIG_EDAC_MM_EDAC=3Dy
> >  CONFIG_DMADEVICES=3Dy
>=20
> Why only corenet64 and not corenet32?
>=20
> -Scott
[Shengzhou] There is already RTC support in corenet32, only missing in core=
net64.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH 1/2] mtd/spi: support en25s64 device
  2014-05-21 20:50 ` [PATCH 1/2] mtd/spi: support en25s64 device Scott Wood
@ 2014-05-23  8:20   ` Shengzhou.Liu
  0 siblings, 0 replies; 11+ messages in thread
From: Shengzhou.Liu @ 2014-05-23  8:20 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev

DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gLS0tIGEvZHJpdmVycy9tdGQvZGV2
aWNlcy9tMjVwODAuYw0KPiA+ICsrKyBiL2RyaXZlcnMvbXRkL2RldmljZXMvbTI1cDgwLmMNCj4g
PiBAQCAtNzQ1LDYgKzc0NSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgc3BpX2RldmljZV9pZCBt
MjVwX2lkc1tdID0gew0KPiA+ICAJeyAiZW4yNXEzMmIiLCAgIElORk8oMHgxYzMwMTYsIDAsIDY0
ICogMTAyNCwgICA2NCwgMCkgfSwNCj4gPiAgCXsgImVuMjVwNjQiLCAgICBJTkZPKDB4MWMyMDE3
LCAwLCA2NCAqIDEwMjQsICAxMjgsIDApIH0sDQo+ID4gIAl7ICJlbjI1cTY0IiwgICAgSU5GTygw
eDFjMzAxNywgMCwgNjQgKiAxMDI0LCAgMTI4LCBTRUNUXzRLKSB9LA0KPiA+ICsJeyAiZW4yNXM2
NCIsICAgIElORk8oMHgxYzM4MTcsIDAsIDY0ICogMTAyNCwgIDEyOCwgMCkgfSwNCj4gPiAgCXsg
ImVuMjVxaDI1NiIsICBJTkZPKDB4MWM3MDE5LCAwLCA2NCAqIDEwMjQsICA1MTIsIDApIH0sDQo+
ID4NCj4gPiAgCS8qIEVTTVQgKi8NCj4gDQo+IFRoaXMgbmVlZHMgdG8gYmUgc2VudCB0byB0aGUg
bXRkIGFuZC9vciBzcGkgbWFpbnRhaW5lcnMsIG5vdCBoZXJlLg0KPiANCj4gV2hhdCBkb2VzIHRo
aXMgaGF2ZSB0byBkbyB3aXRoIHBhdGNoIDIvMj8gIERvbid0IHB1dCB1bnJlbGF0ZWQgdGhpbmdz
IGluDQo+IHRoZSBzYW1lIHBhdGNoc2V0LCBlc3BlY2lhbGx5IHdoZW4gdGhleSdyZSBkZXN0aW5l
ZCBmb3IgZGlmZmVyZW50DQo+IG1haW50YWluZXJzLg0KPiANCj4gLVNjb3R0DQo+IA0KW1NoZW5n
emhvdV0gdGhhbmtzLCBzZW50IHRvIGxpbnV4LW10ZEBsaXN0cy5pbmZyYWRlYWQub3JnIGFscmVh
ZHkuDQoNCg==

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-23  8:03     ` Shengzhou.Liu
@ 2014-05-23 17:06       ` Scott Wood
  2014-05-26  3:08         ` Shengzhou.Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Scott Wood @ 2014-05-23 17:06 UTC (permalink / raw)
  To: Liu Shengzhou-B36685; +Cc: linuxppc-dev

On Fri, 2014-05-23 at 03:03 -0500, Liu Shengzhou-B36685 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, May 23, 2014 6:52 AM
> > To: Liu Shengzhou-B36685
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
> > 
> > > +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> > > @@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=y  CONFIG_USB_STORAGE=y
> > > CONFIG_MMC=y  CONFIG_MMC_SDHCI=y
> > > +CONFIG_RTC_CLASS=y
> > > +CONFIG_RTC_DRV_CMOS=y
> > > +CONFIG_RTC_DRV_DS1307=y
> > > +CONFIG_RTC_DRV_DS1374=y
> > > +CONFIG_RTC_DRV_DS3232=y
> > >  CONFIG_EDAC=y
> > >  CONFIG_EDAC_MM_EDAC=y
> > >  CONFIG_DMADEVICES=y
> > 
> > Why only corenet64 and not corenet32?
> > 
> > -Scott
> [Shengzhou] There is already RTC support in corenet32, only missing in corenet64.

Only DS3232, not DS1307 or DS1374.  Which boards use the latter two?

Why do we need CONFIG_RTC_DRV_CMOS?

-Scott

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-23 17:06       ` Scott Wood
@ 2014-05-26  3:08         ` Shengzhou.Liu
  2014-05-27 15:33           ` Kumar Gala
  0 siblings, 1 reply; 11+ messages in thread
From: Shengzhou.Liu @ 2014-05-26  3:08 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev

DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIx
DQo+IFNlbnQ6IFNhdHVyZGF5LCBNYXkgMjQsIDIwMTQgMTowNiBBTQ0KPiBUbzogTGl1IFNoZW5n
emhvdS1CMzY2ODUNCj4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IFN1Ympl
Y3Q6IFJlOiBbMi8yXSBwb3dlcnBjL2NvcmVuZXQ2NF9zbXBfZGVmY29uZmlnOiBlbmFibGUgUlRD
IHN1cHBvcnQNCj4gDQo+IE9uIEZyaSwgMjAxNC0wNS0yMyBhdCAwMzowMyAtMDUwMCwgTGl1IFNo
ZW5nemhvdS1CMzY2ODUgd3JvdGU6DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K
PiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IEZyaWRheSwgTWF5IDIz
LCAyMDE0IDY6NTIgQU0NCj4gPiA+IFRvOiBMaXUgU2hlbmd6aG91LUIzNjY4NQ0KPiA+ID4gQ2M6
IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogWzIvMl0g
cG93ZXJwYy9jb3JlbmV0NjRfc21wX2RlZmNvbmZpZzogZW5hYmxlIFJUQw0KPiA+ID4gc3VwcG9y
dA0KPiA+ID4NCj4gPiA+ID4gKysrIGIvYXJjaC9wb3dlcnBjL2NvbmZpZ3MvY29yZW5ldDY0X3Nt
cF9kZWZjb25maWcNCj4gPiA+ID4gQEAgLTEyNSw2ICsxMjUsMTEgQEAgQ09ORklHX1VTQl9FSENJ
X0ZTTD15ICBDT05GSUdfVVNCX1NUT1JBR0U9eQ0KPiA+ID4gPiBDT05GSUdfTU1DPXkgIENPTkZJ
R19NTUNfU0RIQ0k9eQ0KPiA+ID4gPiArQ09ORklHX1JUQ19DTEFTUz15DQo+ID4gPiA+ICtDT05G
SUdfUlRDX0RSVl9DTU9TPXkNCj4gPiA+ID4gK0NPTkZJR19SVENfRFJWX0RTMTMwNz15DQo+ID4g
PiA+ICtDT05GSUdfUlRDX0RSVl9EUzEzNzQ9eQ0KPiA+ID4gPiArQ09ORklHX1JUQ19EUlZfRFMz
MjMyPXkNCj4gPiA+ID4gIENPTkZJR19FREFDPXkNCj4gPiA+ID4gIENPTkZJR19FREFDX01NX0VE
QUM9eQ0KPiA+ID4gPiAgQ09ORklHX0RNQURFVklDRVM9eQ0KPiA+ID4NCj4gPiA+IFdoeSBvbmx5
IGNvcmVuZXQ2NCBhbmQgbm90IGNvcmVuZXQzMj8NCj4gPiA+DQo+ID4gPiAtU2NvdHQNCj4gPiBb
U2hlbmd6aG91XSBUaGVyZSBpcyBhbHJlYWR5IFJUQyBzdXBwb3J0IGluIGNvcmVuZXQzMiwgb25s
eSBtaXNzaW5nIGluDQo+IGNvcmVuZXQ2NC4NCj4gDQo+IE9ubHkgRFMzMjMyLCBub3QgRFMxMzA3
IG9yIERTMTM3NC4gIFdoaWNoIGJvYXJkcyB1c2UgdGhlIGxhdHRlciB0d28/DQo+IA0KPiBXaHkg
ZG8gd2UgbmVlZCBDT05GSUdfUlRDX0RSVl9DTU9TPw0KPiANCj4gLVNjb3R0DQo+IA0KW1NoZW5n
emhvdV0gc28gZmFyIERTMTMwNyBhbmQgRFMxMzc0IG9jY3VyIG9ubHkgb24gdGhvc2UgYm9hcmRz
IHdpdGggY29yZW5ldDY0LiANCkNPTkZJR19SVENfRFJWX0NNT1MgaXMgZW5hYmxlZCBpbiBtcGM4
NXh4X2RlZmNvbmZpZywgbXBjODV4eF9zbXBfZGVmY29uZmlnLCBjb3JlbmV0MzJfc21wX2RlZmNv
bmZpZywgZXRjLCBoZXJlIGtlZXBzIGNvbnNpc3RlbnQgaW4gY29yZW5ldDY0Lg0KSXQgc2VlbXMg
Q09ORklHX1JUQ19EUlZfQ01PUyBpcyBub3QgbmVlZGVkIG9uIDg1eHggcGxhdGZvcm0sIGRvIHdl
IG5lZWQgdG8gcmVtb3ZlIENPTkZJR19SVENfRFJWX0NNT1MgZnJvbSBhbGwgODV4eC9jb3JlbmV0
IGRlZmNvbmZpZz8gSWYgc28sIEkgd2lsbCBwb3N0IGEgbmV3IHBhdGNoIHRvIGRvIGl0Lg0KDQoN
Cg0K

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-26  3:08         ` Shengzhou.Liu
@ 2014-05-27 15:33           ` Kumar Gala
  2014-05-27 16:21             ` Scott Wood
  0 siblings, 1 reply; 11+ messages in thread
From: Kumar Gala @ 2014-05-27 15:33 UTC (permalink / raw)
  To: Shengzhou.Liu; +Cc: Scott Wood, linuxppc-dev


On May 25, 2014, at 10:08 PM, Shengzhou.Liu@freescale.com wrote:

>=20
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Saturday, May 24, 2014 1:06 AM
>> To: Liu Shengzhou-B36685
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC =
support
>>=20
>> On Fri, 2014-05-23 at 03:03 -0500, Liu Shengzhou-B36685 wrote:
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Friday, May 23, 2014 6:52 AM
>>>> To: Liu Shengzhou-B36685
>>>> Cc: linuxppc-dev@lists.ozlabs.org
>>>> Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC
>>>> support
>>>>=20
>>>>> +++ b/arch/powerpc/configs/corenet64_smp_defconfig
>>>>> @@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=3Dy  CONFIG_USB_STORAGE=3Dy=

>>>>> CONFIG_MMC=3Dy  CONFIG_MMC_SDHCI=3Dy
>>>>> +CONFIG_RTC_CLASS=3Dy
>>>>> +CONFIG_RTC_DRV_CMOS=3Dy
>>>>> +CONFIG_RTC_DRV_DS1307=3Dy
>>>>> +CONFIG_RTC_DRV_DS1374=3Dy
>>>>> +CONFIG_RTC_DRV_DS3232=3Dy
>>>>> CONFIG_EDAC=3Dy
>>>>> CONFIG_EDAC_MM_EDAC=3Dy
>>>>> CONFIG_DMADEVICES=3Dy
>>>>=20
>>>> Why only corenet64 and not corenet32?
>>>>=20
>>>> -Scott
>>> [Shengzhou] There is already RTC support in corenet32, only missing =
in
>> corenet64.
>>=20
>> Only DS3232, not DS1307 or DS1374.  Which boards use the latter two?
>>=20
>> Why do we need CONFIG_RTC_DRV_CMOS?
>>=20
>> -Scott
>>=20
> [Shengzhou] so far DS1307 and DS1374 occur only on those boards with =
corenet64.=20
> CONFIG_RTC_DRV_CMOS is enabled in mpc85xx_defconfig, =
mpc85xx_smp_defconfig, corenet32_smp_defconfig, etc, here keeps =
consistent in corenet64.
> It seems CONFIG_RTC_DRV_CMOS is not needed on 85xx platform, do we =
need to remove CONFIG_RTC_DRV_CMOS from all 85xx/corenet defconfig? If =
so, I will post a new patch to do it.

The CDS board uses an RTC over ISA if I remember correctly, not sure =
what driver deals with that (if its CONFIG_RTC_DRV_CMOS) or something =
else.

- k=

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-27 15:33           ` Kumar Gala
@ 2014-05-27 16:21             ` Scott Wood
  2014-05-28  6:50               ` Shengzhou.Liu
  0 siblings, 1 reply; 11+ messages in thread
From: Scott Wood @ 2014-05-27 16:21 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Shengzhou.Liu

On Tue, 2014-05-27 at 10:33 -0500, Kumar Gala wrote:
> On May 25, 2014, at 10:08 PM, Shengzhou.Liu@freescale.com wrote:
> 
> > 
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Saturday, May 24, 2014 1:06 AM
> >> To: Liu Shengzhou-B36685
> >> Cc: linuxppc-dev@lists.ozlabs.org
> >> Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
> >> 
> >> On Fri, 2014-05-23 at 03:03 -0500, Liu Shengzhou-B36685 wrote:
> >>>> -----Original Message-----
> >>>> From: Wood Scott-B07421
> >>>> Sent: Friday, May 23, 2014 6:52 AM
> >>>> To: Liu Shengzhou-B36685
> >>>> Cc: linuxppc-dev@lists.ozlabs.org
> >>>> Subject: Re: [2/2] powerpc/corenet64_smp_defconfig: enable RTC
> >>>> support
> >>>> 
> >>>>> +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> >>>>> @@ -125,6 +125,11 @@ CONFIG_USB_EHCI_FSL=y  CONFIG_USB_STORAGE=y
> >>>>> CONFIG_MMC=y  CONFIG_MMC_SDHCI=y
> >>>>> +CONFIG_RTC_CLASS=y
> >>>>> +CONFIG_RTC_DRV_CMOS=y
> >>>>> +CONFIG_RTC_DRV_DS1307=y
> >>>>> +CONFIG_RTC_DRV_DS1374=y
> >>>>> +CONFIG_RTC_DRV_DS3232=y
> >>>>> CONFIG_EDAC=y
> >>>>> CONFIG_EDAC_MM_EDAC=y
> >>>>> CONFIG_DMADEVICES=y
> >>>> 
> >>>> Why only corenet64 and not corenet32?
> >>>> 
> >>>> -Scott
> >>> [Shengzhou] There is already RTC support in corenet32, only missing in
> >> corenet64.
> >> 
> >> Only DS3232, not DS1307 or DS1374.  Which boards use the latter two?
> >> 
> >> Why do we need CONFIG_RTC_DRV_CMOS?
> >> 
> >> -Scott
> >> 
> > [Shengzhou] so far DS1307 and DS1374 occur only on those boards with corenet64. 

Which boards?  I don't see them in any corenet dts files.  I do see some
instances of ds1374 in the dts files of boards non-corenet mpc85xx
boards (mpc8568mds, mpc8569mds, and p1021mds), yet it's not in the
mpc85xx_defconfig or mpc85xx_smp_defconfig.

> > CONFIG_RTC_DRV_CMOS is enabled in mpc85xx_defconfig, mpc85xx_smp_defconfig, corenet32_smp_defconfig, etc, here keeps consistent in corenet64.
> > It seems CONFIG_RTC_DRV_CMOS is not needed on 85xx platform, do we need to remove CONFIG_RTC_DRV_CMOS from all 85xx/corenet defconfig? If so, I will post a new patch to do it.
> 
> The CDS board uses an RTC over ISA if I remember correctly, not sure what driver deals with that (if its CONFIG_RTC_DRV_CMOS) or something else.

If it's just CDS then we don't need it in either corenet config.

-Scott

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [2/2] powerpc/corenet64_smp_defconfig: enable RTC support
  2014-05-27 16:21             ` Scott Wood
@ 2014-05-28  6:50               ` Shengzhou.Liu
  0 siblings, 0 replies; 11+ messages in thread
From: Shengzhou.Liu @ 2014-05-28  6:50 UTC (permalink / raw)
  To: Scott Wood, Kumar Gala; +Cc: linuxppc-dev

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBNYXkgMjgsIDIwMTQgMTI6MjEgQU0NCj4gVG86IEt1bWFy
IEdhbGENCj4gQ2M6IExpdSBTaGVuZ3pob3UtQjM2Njg1OyBsaW51eHBwYy1kZXZAbGlzdHMub3ps
YWJzLm9yZw0KPiBTdWJqZWN0OiBSZTogWzIvMl0gcG93ZXJwYy9jb3JlbmV0NjRfc21wX2RlZmNv
bmZpZzogZW5hYmxlIFJUQyBzdXBwb3J0DQo+IA0KPiBPbiBUdWUsIDIwMTQtMDUtMjcgYXQgMTA6
MzMgLTA1MDAsIEt1bWFyIEdhbGEgd3JvdGU6DQo+ID4gT24gTWF5IDI1LCAyMDE0LCBhdCAxMDow
OCBQTSwgU2hlbmd6aG91LkxpdUBmcmVlc2NhbGUuY29tIHdyb3RlOg0KPiA+DQo+ID4gPg0KPiA+
ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPj4gRnJvbTogV29vZCBTY290dC1C
MDc0MjENCj4gPiA+PiBTZW50OiBTYXR1cmRheSwgTWF5IDI0LCAyMDE0IDE6MDYgQU0NCj4gPiA+
PiBUbzogTGl1IFNoZW5nemhvdS1CMzY2ODUNCj4gPiA+PiBDYzogbGludXhwcGMtZGV2QGxpc3Rz
Lm96bGFicy5vcmcNCj4gPiA+PiBTdWJqZWN0OiBSZTogWzIvMl0gcG93ZXJwYy9jb3JlbmV0NjRf
c21wX2RlZmNvbmZpZzogZW5hYmxlIFJUQw0KPiA+ID4+IHN1cHBvcnQNCj4gPiA+Pg0KPiA+ID4+
IE9uIEZyaSwgMjAxNC0wNS0yMyBhdCAwMzowMyAtMDUwMCwgTGl1IFNoZW5nemhvdS1CMzY2ODUg
d3JvdGU6DQo+ID4gPj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4+Pj4gRnJv
bTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+Pj4+IFNlbnQ6IEZyaWRheSwgTWF5IDIzLCAyMDE0
IDY6NTIgQU0NCj4gPiA+Pj4+IFRvOiBMaXUgU2hlbmd6aG91LUIzNjY4NQ0KPiA+ID4+Pj4gQ2M6
IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+ID4gPj4+PiBTdWJqZWN0OiBSZTogWzIv
Ml0gcG93ZXJwYy9jb3JlbmV0NjRfc21wX2RlZmNvbmZpZzogZW5hYmxlIFJUQw0KPiA+ID4+Pj4g
c3VwcG9ydA0KPiA+ID4+Pj4NCj4gPiA+Pj4+PiArKysgYi9hcmNoL3Bvd2VycGMvY29uZmlncy9j
b3JlbmV0NjRfc21wX2RlZmNvbmZpZw0KPiA+ID4+Pj4+IEBAIC0xMjUsNiArMTI1LDExIEBAIENP
TkZJR19VU0JfRUhDSV9GU0w9eSAgQ09ORklHX1VTQl9TVE9SQUdFPXkNCj4gPiA+Pj4+PiBDT05G
SUdfTU1DPXkgIENPTkZJR19NTUNfU0RIQ0k9eQ0KPiA+ID4+Pj4+ICtDT05GSUdfUlRDX0NMQVNT
PXkNCj4gPiA+Pj4+PiArQ09ORklHX1JUQ19EUlZfQ01PUz15DQo+ID4gPj4+Pj4gK0NPTkZJR19S
VENfRFJWX0RTMTMwNz15DQo+ID4gPj4+Pj4gK0NPTkZJR19SVENfRFJWX0RTMTM3ND15DQo+ID4g
Pj4+Pj4gK0NPTkZJR19SVENfRFJWX0RTMzIzMj15DQo+ID4gPj4+Pj4gQ09ORklHX0VEQUM9eQ0K
PiA+ID4+Pj4+IENPTkZJR19FREFDX01NX0VEQUM9eQ0KPiA+ID4+Pj4+IENPTkZJR19ETUFERVZJ
Q0VTPXkNCj4gPiA+Pj4+DQo+ID4gPj4+PiBXaHkgb25seSBjb3JlbmV0NjQgYW5kIG5vdCBjb3Jl
bmV0MzI/DQo+ID4gPj4+Pg0KPiA+ID4+Pj4gLVNjb3R0DQo+ID4gPj4+IFtTaGVuZ3pob3VdIFRo
ZXJlIGlzIGFscmVhZHkgUlRDIHN1cHBvcnQgaW4gY29yZW5ldDMyLCBvbmx5DQo+ID4gPj4+IG1p
c3NpbmcgaW4NCj4gPiA+PiBjb3JlbmV0NjQuDQo+ID4gPj4NCj4gPiA+PiBPbmx5IERTMzIzMiwg
bm90IERTMTMwNyBvciBEUzEzNzQuICBXaGljaCBib2FyZHMgdXNlIHRoZSBsYXR0ZXIgdHdvPw0K
PiA+ID4+DQo+ID4gPj4gV2h5IGRvIHdlIG5lZWQgQ09ORklHX1JUQ19EUlZfQ01PUz8NCj4gPiA+
Pg0KPiA+ID4+IC1TY290dA0KPiA+ID4+DQo+ID4gPiBbU2hlbmd6aG91XSBzbyBmYXIgRFMxMzA3
IGFuZCBEUzEzNzQgb2NjdXIgb25seSBvbiB0aG9zZSBib2FyZHMgd2l0aA0KPiBjb3JlbmV0NjQu
DQo+IA0KPiBXaGljaCBib2FyZHM/ICBJIGRvbid0IHNlZSB0aGVtIGluIGFueSBjb3JlbmV0IGR0
cyBmaWxlcy4gIA0KDQpbU2hlbmd6aG91XSBDT05GSUdfUlRDX0RSVl9EUzEzMDcgaXMgbmVlZGVk
IGZvciBkczEzMzkgb24gdDIwODByZGIuDQoNCj4gSSBkbyBzZWUgc29tZSBpbnN0YW5jZXMgb2Yg
ZHMxMzc0IGluIHRoZSBkdHMgZmlsZXMgb2YgYm9hcmRzIG5vbi1jb3JlbmV0IG1wYzg1eHggYm9h
cmRzDQo+IChtcGM4NTY4bWRzLCBtcGM4NTY5bWRzLCBhbmQgcDEwMjFtZHMpLCB5ZXQgaXQncyBu
b3QgaW4gdGhlDQo+IG1wYzg1eHhfZGVmY29uZmlnIG9yIG1wYzg1eHhfc21wX2RlZmNvbmZpZy4N
Cj4gDQo+ID4gPiBDT05GSUdfUlRDX0RSVl9DTU9TIGlzIGVuYWJsZWQgaW4gbXBjODV4eF9kZWZj
b25maWcsDQo+IG1wYzg1eHhfc21wX2RlZmNvbmZpZywgY29yZW5ldDMyX3NtcF9kZWZjb25maWcs
IGV0YywgaGVyZSBrZWVwcw0KPiBjb25zaXN0ZW50IGluIGNvcmVuZXQ2NC4NCj4gPiA+IEl0IHNl
ZW1zIENPTkZJR19SVENfRFJWX0NNT1MgaXMgbm90IG5lZWRlZCBvbiA4NXh4IHBsYXRmb3JtLCBk
byB3ZQ0KPiBuZWVkIHRvIHJlbW92ZSBDT05GSUdfUlRDX0RSVl9DTU9TIGZyb20gYWxsIDg1eHgv
Y29yZW5ldCBkZWZjb25maWc/IElmIHNvLA0KPiBJIHdpbGwgcG9zdCBhIG5ldyBwYXRjaCB0byBk
byBpdC4NCj4gPg0KPiA+IFRoZSBDRFMgYm9hcmQgdXNlcyBhbiBSVEMgb3ZlciBJU0EgaWYgSSBy
ZW1lbWJlciBjb3JyZWN0bHksIG5vdCBzdXJlDQo+IHdoYXQgZHJpdmVyIGRlYWxzIHdpdGggdGhh
dCAoaWYgaXRzIENPTkZJR19SVENfRFJWX0NNT1MpIG9yIHNvbWV0aGluZw0KPiBlbHNlLg0KPiAN
Cj4gSWYgaXQncyBqdXN0IENEUyB0aGVuIHdlIGRvbid0IG5lZWQgaXQgaW4gZWl0aGVyIGNvcmVu
ZXQgY29uZmlnLg0KPiANCj4gLVNjb3R0DQo+IA0KW1NoZW5nemhvdV0geWVzLCBtcGM4NTQ4Y2Rz
IGJvYXJkIHVzZXMgQ09ORklHX1JUQ19EUlZfQ01PUyB0byBkZWFsIHdpdGggcnRjLiANCkkgdXBk
YXRlZCB0aGVzZSBjaGFuZ2VzIHdpdGggbmV3IHBhdGNoIHYyOiBodHRwOi8vcGF0Y2h3b3JrLm96
bGFicy5vcmcvcGF0Y2gvMzUzMjQzLw0KDQoNCg==

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-05-28  6:50 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-21 10:05 [PATCH 1/2] mtd/spi: support en25s64 device Shengzhou Liu
2014-05-21 10:05 ` [PATCH 2/2] powerpc/corenet64_smp_defconfig: enable RTC support Shengzhou Liu
2014-05-22 22:51   ` [2/2] " Scott Wood
2014-05-23  8:03     ` Shengzhou.Liu
2014-05-23 17:06       ` Scott Wood
2014-05-26  3:08         ` Shengzhou.Liu
2014-05-27 15:33           ` Kumar Gala
2014-05-27 16:21             ` Scott Wood
2014-05-28  6:50               ` Shengzhou.Liu
2014-05-21 20:50 ` [PATCH 1/2] mtd/spi: support en25s64 device Scott Wood
2014-05-23  8:20   ` Shengzhou.Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.