[PATCH] staging: iio: adis16240_core: Replace symbolic permission with octal permission

[PATCH] staging: iio: adis16240_core: Replace symbolic permission with octal permission

[sayli karnik]

The patch resolves following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using
octal permissions '0444'.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/iio/accel/adis16240_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
index d5b99e6..e1bc9fc 100644
--- a/drivers/staging/iio/accel/adis16240_core.c
+++ b/drivers/staging/iio/accel/adis16240_core.c
@@ -65,7 +65,7 @@ static ssize_t adis16240_read_12bit_signed(struct device *dev,
 	return ret;
 }
 
-static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, S_IRUGO,
+static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, 0444,
 		       adis16240_read_12bit_signed, NULL,
 		       ADIS16240_XYZPEAK_OUT);
 
-- 
2.7.4

Re: [PATCH] staging: iio: adis16240_core: Replace symbolic permission with octal permission

[Jonathan Cameron]

On 17/02/17 18:08, sayli karnik wrote:
> The patch resolves following checkpatch issue:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using
> octal permissions '0444'.
> 
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Applied to the togreg branch of iio.git. Pushed out as testing initially to let
the autobuilders play with it.

One request though, please post iio related patches to linux-iio@vger.kernel.org even
for drivers in staging.  That way they are less likely to fall through the cracks!

Jonathan
> ---
>  drivers/staging/iio/accel/adis16240_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
> index d5b99e6..e1bc9fc 100644
> --- a/drivers/staging/iio/accel/adis16240_core.c
> +++ b/drivers/staging/iio/accel/adis16240_core.c
> @@ -65,7 +65,7 @@ static ssize_t adis16240_read_12bit_signed(struct device *dev,
>  	return ret;
>  }
>  
> -static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, S_IRUGO,
> +static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, 0444,
>  		       adis16240_read_12bit_signed, NULL,
>  		       ADIS16240_XYZPEAK_OUT);
>  
> 

Re: [Outreachy kernel] Re: [PATCH] staging: iio: adis16240_core: Replace symbolic permission with octal permission

[Julia Lawall]

On Sat, 18 Feb 2017, Jonathan Cameron wrote:

> On 17/02/17 18:08, sayli karnik wrote:
> > The patch resolves following checkpatch issue:
> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using
> > octal permissions '0444'.
> >
> > Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> Applied to the togreg branch of iio.git. Pushed out as testing initially to let
> the autobuilders play with it.
>
> One request though, please post iio related patches to linux-iio@vger.kernel.org even
> for drivers in staging.  That way they are less likely to fall through the cracks!

I updates the Outreachy instructions accordingly.

thanks,
julia

>
> Jonathan
> > ---
> >  drivers/staging/iio/accel/adis16240_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
> > index d5b99e6..e1bc9fc 100644
> > --- a/drivers/staging/iio/accel/adis16240_core.c
> > +++ b/drivers/staging/iio/accel/adis16240_core.c
> > @@ -65,7 +65,7 @@ static ssize_t adis16240_read_12bit_signed(struct device *dev,
> >  	return ret;
> >  }
> >
> > -static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, S_IRUGO,
> > +static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, 0444,
> >  		       adis16240_read_12bit_signed, NULL,
> >  		       ADIS16240_XYZPEAK_OUT);
> >
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/fc505638-1355-7a14-3853-32210e186df8%40kernel.org.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] Re: [PATCH] staging: iio: adis16240_core: Replace symbolic permission with octal permission

[Jonathan Cameron]

On 18 February 2017 19:17:36 GMT+00:00, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>On Sat, 18 Feb 2017, Jonathan Cameron wrote:
>
>> On 17/02/17 18:08, sayli karnik wrote:
>> > The patch resolves following checkpatch issue:
>> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
>using
>> > octal permissions '0444'.
>> >
>> > Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>> Applied to the togreg branch of iio.git. Pushed out as testing
>initially to let
>> the autobuilders play with it.
>>
>> One request though, please post iio related patches to
>linux-iio@vger.kernel.org even
>> for drivers in staging.  That way they are less likely to fall
>through the cracks!
>
>I updates the Outreachy instructions accordingly.
Thanks

Jonathan
>
>thanks,
>julia
>
>>
>> Jonathan
>> > ---
>> >  drivers/staging/iio/accel/adis16240_core.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/staging/iio/accel/adis16240_core.c
>b/drivers/staging/iio/accel/adis16240_core.c
>> > index d5b99e6..e1bc9fc 100644
>> > --- a/drivers/staging/iio/accel/adis16240_core.c
>> > +++ b/drivers/staging/iio/accel/adis16240_core.c
>> > @@ -65,7 +65,7 @@ static ssize_t adis16240_read_12bit_signed(struct
>device *dev,
>> >  	return ret;
>> >  }
>> >
>> > -static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, S_IRUGO,
>> > +static IIO_DEVICE_ATTR(in_accel_xyz_squared_peak_raw, 0444,
>> >  		       adis16240_read_12bit_signed, NULL,
>> >  		       ADIS16240_XYZPEAK_OUT);
>> >
>> >
>>
>> --
>> You received this message because you are subscribed to the Google
>Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it,
>send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to
>outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit
>https://groups.google.com/d/msgid/outreachy-kernel/fc505638-1355-7a14-3853-32210e186df8%40kernel.org.
>> For more options, visit https://groups.google.com/d/optout.
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.