[Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree]

comedi_pci_auto_config() function prototype is exceeding more than
75 characters per line. Adjusted to 75 chars to improve readability

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---

changes in v7:
-Kernel cannot handle the wrapped lines.
-Modified the commit message.

changes in v6:
-Always commit on the base version.

changes in v5:
-Fixed Change log
-Change in subject line. Do not send as 'Re:'

changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
  to fix checkpatch Error.

changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
  Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
  75 characters per line. Adjust to 75 chars to improve
  readability and also adjust the arguments to match open
  parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
  characters. Modified contents to adjust 75 chars per line.

  drivers/staging/comedi/comedi_pci.h | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_pci.h 
b/drivers/staging/comedi/comedi_pci.h
index 4e069440cbdc..9c143953ea40 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -31,7 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
  void comedi_pci_disable(struct comedi_device *dev);
  void comedi_pci_detach(struct comedi_device *dev);
  -int comedi_pci_auto_config(struct pci_dev *pcidev, struct 
comedi_driver *driver,
+int comedi_pci_auto_config(struct pci_dev *pcidev,
+			   struct comedi_driver *driver,
  			   unsigned long context);
  void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
  -- 2.17.1

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Himanshu Jha]

On Sun, Oct 07, 2018 at 05:02:26PM +0530, Bhanusree wrote:
> comedi_pci_auto_config() function prototype is exceeding more than
> 75 characters per line. Adjusted to 75 chars to improve readability
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>

Put a space out after ':'

staging: comedi: comedi_pci.h: Prefer a maximum 75 chars per line

> diff --git a/drivers/staging/comedi/comedi_pci.h
> b/drivers/staging/comedi/comedi_pci.h
> index 4e069440cbdc..9c143953ea40 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -31,7 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
>  void comedi_pci_disable(struct comedi_device *dev);
>  void comedi_pci_detach(struct comedi_device *dev);
>  -int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver
> *driver,
> +int comedi_pci_auto_config(struct pci_dev *pcidev,
> +			   struct comedi_driver *driver,
>  			   unsigned long context);
>  void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
>  -- 2.17.1

Did you realise that you sent this through Thunderbird and
it somehow wrapped. These hacks can lead to corrupted patch
and wouldn't apply cleanly to the maintainers tree.

Just to check:
Make a new temp branch and then apply it using:

$ git am <your_patch.patch>

Use `git send-email` or mutt to send patches.
Personally, I suggest the former case.

There is no rush, Bhanusree!

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Ian Abbott]

On 07/10/18 12:32, Bhanusree wrote:
> comedi_pci_auto_config() function prototype is exceeding more than
> 75 characters per line. Adjusted to 75 chars to improve readability
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>

I've never heard of that preference for function prototypes to not 
exceed 75 columns.  Where does it come from?

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree]

On Monday 08 October 2018 03:39 PM, Ian Abbott wrote:
> On 07/10/18 12:32, Bhanusree wrote:
>> comedi_pci_auto_config() function prototype is exceeding more than
>> 75 characters per line. Adjusted to 75 chars to improve readability
>>
>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>
> I've never heard of that preference for function prototypes to not 
> exceed 75 columns.  Where does it come from?
It is the warning given by checkpatch. Earlier it used to show if 
characters exceeded 80 per line. But now when checkpatch is applied it 
is showing the following warning.

"Possible unwrapped commit description (prefer a maximum 75 chars per line)"

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Vaishali Thakkar]

Adding Greg, Ian and Hartley

On Mon, Oct 8, 2018 at 3:46 PM Bhanusree <bhanusreemahesh@gmail.com> wrote:
>

Bhanusree,

When you reply to email, keep everyone in the loop. Use reply-all
instead of replying in the mailing list only.

>
> On Monday 08 October 2018 03:39 PM, Ian Abbott wrote:
> > On 07/10/18 12:32, Bhanusree wrote:
> >> comedi_pci_auto_config() function prototype is exceeding more than
> >> 75 characters per line. Adjusted to 75 chars to improve readability
> >>
> >> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> >
> > I've never heard of that preference for function prototypes to not
> > exceed 75 columns.  Where does it come from?
> It is the warning given by checkpatch. Earlier it used to show if
> characters exceeded 80 per line. But now when checkpatch is applied it
> is showing the following warning.
>
> "Possible unwrapped commit description (prefer a maximum 75 chars per line)"
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/f8152fce-71dc-6771-a33e-bc9d95fcf46a%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Ian Abbott]

On 08/10/2018 11:40, Vaishali Thakkar wrote:
> Adding Greg, Ian and Hartley

Thanks.

> On Mon, Oct 8, 2018 at 3:46 PM Bhanusree <bhanusreemahesh@gmail.com> wrote:
>>
> 
> Bhanusree,
> 
> When you reply to email, keep everyone in the loop. Use reply-all
> instead of replying in the mailing list only.
> 
>>
>> On Monday 08 October 2018 03:39 PM, Ian Abbott wrote:
>>> On 07/10/18 12:32, Bhanusree wrote:
>>>> comedi_pci_auto_config() function prototype is exceeding more than
>>>> 75 characters per line. Adjusted to 75 chars to improve readability
>>>>
>>>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>>>
>>> I've never heard of that preference for function prototypes to not
>>> exceed 75 columns.  Where does it come from?
>> It is the warning given by checkpatch. Earlier it used to show if
>> characters exceeded 80 per line. But now when checkpatch is applied it
>> is showing the following warning.
>>
>> "Possible unwrapped commit description (prefer a maximum 75 chars per line)"

Bhanusree,

I see your misunderstanding.  That checkpatch warning is referring to 
the "commit description" (i.e. the descriptive text in the email about 
the purpose of the patch), not to the source code.  For source code, the 
strongly preferred limit is 80 columns.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree]

On Monday 08 October 2018 04:23 PM, Ian Abbott wrote:
> On 08/10/2018 11:40, Vaishali Thakkar wrote:
>> Adding Greg, Ian and Hartley
>
> Thanks.
>
>> On Mon, Oct 8, 2018 at 3:46 PM Bhanusree <bhanusreemahesh@gmail.com> 
>> wrote:
>>>
>>
>> Bhanusree,
>>
>> When you reply to email, keep everyone in the loop. Use reply-all
>> instead of replying in the mailing list only.
>>
>>>
>>> On Monday 08 October 2018 03:39 PM, Ian Abbott wrote:
>>>> On 07/10/18 12:32, Bhanusree wrote:
>>>>> comedi_pci_auto_config() function prototype is exceeding more than
>>>>> 75 characters per line. Adjusted to 75 chars to improve readability
>>>>>
>>>>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>>>>
>>>> I've never heard of that preference for function prototypes to not
>>>> exceed 75 columns.  Where does it come from?
>>> It is the warning given by checkpatch. Earlier it used to show if
>>> characters exceeded 80 per line. But now when checkpatch is applied it
>>> is showing the following warning.
>>>
>>> "Possible unwrapped commit description (prefer a maximum 75 chars 
>>> per line)"
>
> Bhanusree,
>
> I see your misunderstanding.  That checkpatch warning is referring to 
> the "commit description" (i.e. the descriptive text in the email about 
> the purpose of the patch), not to the source code. For source code, 
> the strongly preferred limit is 80 columns.
ok. Thanks for the clarification. I will try to chose some basic thing 
for the first commit.

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree]

On Monday 08 October 2018 04:10 PM, Vaishali Thakkar wrote:
> Adding Greg, Ian and Hartley
>
> On Mon, Oct 8, 2018 at 3:46 PM Bhanusree <bhanusreemahesh@gmail.com> wrote:
> Bhanusree,
>
> When you reply to email, keep everyone in the loop. Use reply-all
> instead of replying in the mailing list only.
I missed it some how. I will make sure not to repeat that.
>> On Monday 08 October 2018 03:39 PM, Ian Abbott wrote:
>>> On 07/10/18 12:32, Bhanusree wrote:
>>>> comedi_pci_auto_config() function prototype is exceeding more than
>>>> 75 characters per line. Adjusted to 75 chars to improve readability
>>>>
>>>> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>>> I've never heard of that preference for function prototypes to not
>>> exceed 75 columns.  Where does it come from?
>> It is the warning given by checkpatch. Earlier it used to show if
>> characters exceeded 80 per line. But now when checkpatch is applied it
>> is showing the following warning.
>>
>> "Possible unwrapped commit description (prefer a maximum 75 chars per line)"
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/f8152fce-71dc-6771-a33e-bc9d95fcf46a%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel][PATCH v7] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Greg KH]

On Sun, Oct 07, 2018 at 05:02:26PM +0530, Bhanusree wrote:
> comedi_pci_auto_config() function prototype is exceeding more than
> 75 characters per line. Adjusted to 75 chars to improve readability
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>

Your "From:" line on your email does not match this name :(