From: Andrew Cooper <amc96@srcf.net>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Hongyan Xia <hongyxia@amazon.com>,
Dmitry Isaikin <isaikin-dmitry@yandex.ru>,
Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"
Date: Tue, 9 Nov 2021 14:34:03 +0000 [thread overview]
Message-ID: <fc7465a7-6942-12ae-c3c1-0773c36c32f6@srcf.net> (raw)
In-Reply-To: <20211109143128.56089-1-roger.pau@citrix.com>
On 09/11/2021 14:31, Roger Pau Monne wrote:
> This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88.
>
> Performance analysis has shown that dropping the domctl lock during
> domain destruction greatly increases the contention in the heap_lock,
> thus making parallel destruction of domains slower.
>
> The following lockperf data shows the difference between the current
> code and the reverted one:
>
> lock: 3342357(2.268295505s), block: 3263853(18.556650797s)
> lock: 2788704(0.362311723s), block: 222681( 0.091152276s)
>
> Given the current point in the release, revert the commit and
> reinstate holding the domctl lock during domain destruction. Further
> work should be done in order to re-add more fine grained locking to
> the domain destruction path once a proper solution to avoid the
> heap_lock contention is found.
>
> Reported-by: Hongyan Xia <hongyxia@amazon.com>
> Reported-by: Dmitry Isaikin <isaikin-dmitry@yandex.ru>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2021-11-09 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 12:02 [PATCH for-4.16 v2] Revert "domctl: improve locking during domain destruction" Roger Pau Monne
2021-11-09 14:31 ` [PATCH for-4.16] " Roger Pau Monne
2021-11-09 14:34 ` Andrew Cooper [this message]
2021-11-09 14:42 ` Julien Grall
2021-11-09 14:55 ` Roger Pau Monné
2021-11-09 15:28 ` Julien Grall
2021-11-09 15:04 ` Ian Jackson
2021-11-09 15:15 ` Roger Pau Monné
2021-11-16 14:51 ` [PATCH for-4.16] Revert "domctl: improve locking during domain destruction" [and 2 more messages] Ian Jackson
2021-11-15 11:51 ` [PATCH for-4.16 v2] Revert "domctl: improve locking during domain destruction" Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7465a7-6942-12ae-c3c1-0773c36c32f6@srcf.net \
--to=amc96@srcf.net \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=hongyxia@amazon.com \
--cc=isaikin-dmitry@yandex.ru \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.