All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>,
	airlied@linux.ie, daniel@ffwll.ch
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <chenzhou10@huawei.com>
Subject: Re: [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
Date: Mon, 16 Nov 2020 09:09:14 +0800	[thread overview]
Message-ID: <fc7c7191-52d2-2a00-57b3-7b19f4e72955@huawei.com> (raw)
In-Reply-To: <6119042.uhm7frSX9h@jernej-laptop>

Hi!

On 2020/11/14 2:01, Jernej Škrabec wrote:
> Hi!
> 
> Thanks for the patch.
> 
> Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a):
>> Fix to return a negative error code from the error handling case instead
>> of 0 in function sun8i_dw_hdmi_bind().
>>
>> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>> ---
>>  drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644
>> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct
>> device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0);
>>  	if (!phy_node) {
>>  		dev_err(dev, "Can't found PHY phandle\n");
>> +		ret = -ENODEV;
> 
> That should be EINVAL because DT node doesn't have mandatory property.
> 
> With that fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks for your review! I will fix it in the next version.

Thanks,
Xiongfeng

> 
> Best regards,
> Jernej
> 
>>  		goto err_disable_clk_tmds;
>>  	}
> 
> 
> 
> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>,
	airlied@linux.ie, daniel@ffwll.ch
Cc: linux-arm-kernel@lists.infradead.org, chenzhou10@huawei.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
Date: Mon, 16 Nov 2020 09:09:14 +0800	[thread overview]
Message-ID: <fc7c7191-52d2-2a00-57b3-7b19f4e72955@huawei.com> (raw)
In-Reply-To: <6119042.uhm7frSX9h@jernej-laptop>

Hi!

On 2020/11/14 2:01, Jernej Škrabec wrote:
> Hi!
> 
> Thanks for the patch.
> 
> Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a):
>> Fix to return a negative error code from the error handling case instead
>> of 0 in function sun8i_dw_hdmi_bind().
>>
>> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>> ---
>>  drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644
>> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct
>> device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0);
>>  	if (!phy_node) {
>>  		dev_err(dev, "Can't found PHY phandle\n");
>> +		ret = -ENODEV;
> 
> That should be EINVAL because DT node doesn't have mandatory property.
> 
> With that fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks for your review! I will fix it in the next version.

Thanks,
Xiongfeng

> 
> Best regards,
> Jernej
> 
>>  		goto err_disable_clk_tmds;
>>  	}
> 
> 
> 
> 
> .
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>,
	airlied@linux.ie, daniel@ffwll.ch
Cc: linux-arm-kernel@lists.infradead.org, chenzhou10@huawei.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()
Date: Mon, 16 Nov 2020 09:09:14 +0800	[thread overview]
Message-ID: <fc7c7191-52d2-2a00-57b3-7b19f4e72955@huawei.com> (raw)
In-Reply-To: <6119042.uhm7frSX9h@jernej-laptop>

Hi!

On 2020/11/14 2:01, Jernej Škrabec wrote:
> Hi!
> 
> Thanks for the patch.
> 
> Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a):
>> Fix to return a negative error code from the error handling case instead
>> of 0 in function sun8i_dw_hdmi_bind().
>>
>> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>> ---
>>  drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644
>> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
>> @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct
>> device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0);
>>  	if (!phy_node) {
>>  		dev_err(dev, "Can't found PHY phandle\n");
>> +		ret = -ENODEV;
> 
> That should be EINVAL because DT node doesn't have mandatory property.
> 
> With that fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks for your review! I will fix it in the next version.

Thanks,
Xiongfeng

> 
> Best regards,
> Jernej
> 
>>  		goto err_disable_clk_tmds;
>>  	}
> 
> 
> 
> 
> .
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-16  1:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 13:14 [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() Xiongfeng Wang
2020-11-12 13:14 ` Xiongfeng Wang
2020-11-12 13:14 ` Xiongfeng Wang
2020-11-13 18:01 ` Jernej Škrabec
2020-11-13 18:01   ` Jernej Škrabec
2020-11-13 18:01   ` Jernej Škrabec
2020-11-16  1:09   ` Xiongfeng Wang [this message]
2020-11-16  1:09     ` Xiongfeng Wang
2020-11-16  1:09     ` Xiongfeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc7c7191-52d2-2a00-57b3-7b19f4e72955@huawei.com \
    --to=wangxiongfeng2@huawei.com \
    --cc=airlied@linux.ie \
    --cc=chenzhou10@huawei.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.