From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Roger Lu <roger.lu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Boichat <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
YT Lee <yt.lee@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine
Date: Fri, 24 Dec 2021 10:34:46 +0100 [thread overview]
Message-ID: <fc825af2-7331-fa05-26e0-f3054557333a@collabora.com> (raw)
In-Reply-To: <6cdc903250723a6c547bccf2546dd10091b76249.camel@mediatek.com>
Il 24/12/21 10:27, Roger Lu ha scritto:
> Hi AngeloGioacchino,
>
> Sorry for the late reply and thanks for all the advices.
>
> On Thu, 2021-10-21 at 10:46 +0200, AngeloGioacchino Del Regno wrote:
>> Il 28/04/21 08:54, Roger Lu ha scritto:
>>> The Smart Voltage Scaling(SVS) engine is a piece of hardware
>>> which calculates suitable SVS bank voltages to OPP voltage table.
>>> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
>>> when receiving OPP_EVENT_ADJUST_VOLTAGE.
>>>
>>> Signed-off-by: Roger Lu <roger.lu@mediatek.com>
>>> ---
>>> drivers/soc/mediatek/Kconfig | 10 +
>>> drivers/soc/mediatek/Makefile | 1 +
>>> drivers/soc/mediatek/mtk-svs.c | 1723 ++++++++++++++++++++++++++++++++
>>> 3 files changed, 1734 insertions(+)
>>> create mode 100644 drivers/soc/mediatek/mtk-svs.c
>
> [snip]
>
>>> +/* svs bank common setting */
>>> +#define SVSB_DET_CLK_EN BIT(31)
>>> +#define SVSB_TZONE_HIGH_TEMP_MAX U32_MAX
>>> +#define SVSB_RUNCONFIG_DEFAULT 0x80000000
>>> +#define SVSB_DC_SIGNED_BIT 0x8000
>>> +#define SVSB_INTEN_INIT0x 0x00005f01
>>> +#define SVSB_INTEN_MONVOPEN 0x00ff0000
>>> +#define SVSB_EN_OFF 0x0
>>> +#define SVSB_EN_MASK 0x7
>>> +#define SVSB_EN_INIT01 0x1
>>> +#define SVSB_EN_INIT02 0x5
>>> +#define SVSB_EN_MON 0x2
>>> +#define SVSB_INTSTS_MONVOP 0x00ff0000
>>> +#define SVSB_INTSTS_COMPLETE 0x1
>>> +#define SVSB_INTSTS_CLEAN 0x00ffffff
>>> +
>>> +static DEFINE_SPINLOCK(mtk_svs_lock);
>>> +
>>> +/*
>>
>> Thanks for using kernel-doc!! However, to be proper, this has to be
>> /**
>> * ..........
>
> Oh okay. Thanks. I will use /** to add multi-line comments. However, I checked
> kernel doc-guide and it uses indent as below. So, I'll follow it. If I'm doing
> it wrong, please correct me. Thanks a lot.
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
>
> /**
> * .........
>
You're welcome! By the way, yes, the indentation is as shown on the documentation.
Regards,
- Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Roger Lu <roger.lu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Boichat <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
YT Lee <yt.lee@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine
Date: Fri, 24 Dec 2021 10:34:46 +0100 [thread overview]
Message-ID: <fc825af2-7331-fa05-26e0-f3054557333a@collabora.com> (raw)
In-Reply-To: <6cdc903250723a6c547bccf2546dd10091b76249.camel@mediatek.com>
Il 24/12/21 10:27, Roger Lu ha scritto:
> Hi AngeloGioacchino,
>
> Sorry for the late reply and thanks for all the advices.
>
> On Thu, 2021-10-21 at 10:46 +0200, AngeloGioacchino Del Regno wrote:
>> Il 28/04/21 08:54, Roger Lu ha scritto:
>>> The Smart Voltage Scaling(SVS) engine is a piece of hardware
>>> which calculates suitable SVS bank voltages to OPP voltage table.
>>> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
>>> when receiving OPP_EVENT_ADJUST_VOLTAGE.
>>>
>>> Signed-off-by: Roger Lu <roger.lu@mediatek.com>
>>> ---
>>> drivers/soc/mediatek/Kconfig | 10 +
>>> drivers/soc/mediatek/Makefile | 1 +
>>> drivers/soc/mediatek/mtk-svs.c | 1723 ++++++++++++++++++++++++++++++++
>>> 3 files changed, 1734 insertions(+)
>>> create mode 100644 drivers/soc/mediatek/mtk-svs.c
>
> [snip]
>
>>> +/* svs bank common setting */
>>> +#define SVSB_DET_CLK_EN BIT(31)
>>> +#define SVSB_TZONE_HIGH_TEMP_MAX U32_MAX
>>> +#define SVSB_RUNCONFIG_DEFAULT 0x80000000
>>> +#define SVSB_DC_SIGNED_BIT 0x8000
>>> +#define SVSB_INTEN_INIT0x 0x00005f01
>>> +#define SVSB_INTEN_MONVOPEN 0x00ff0000
>>> +#define SVSB_EN_OFF 0x0
>>> +#define SVSB_EN_MASK 0x7
>>> +#define SVSB_EN_INIT01 0x1
>>> +#define SVSB_EN_INIT02 0x5
>>> +#define SVSB_EN_MON 0x2
>>> +#define SVSB_INTSTS_MONVOP 0x00ff0000
>>> +#define SVSB_INTSTS_COMPLETE 0x1
>>> +#define SVSB_INTSTS_CLEAN 0x00ffffff
>>> +
>>> +static DEFINE_SPINLOCK(mtk_svs_lock);
>>> +
>>> +/*
>>
>> Thanks for using kernel-doc!! However, to be proper, this has to be
>> /**
>> * ..........
>
> Oh okay. Thanks. I will use /** to add multi-line comments. However, I checked
> kernel doc-guide and it uses indent as below. So, I'll follow it. If I'm doing
> it wrong, please correct me. Thanks a lot.
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
>
> /**
> * .........
>
You're welcome! By the way, yes, the indentation is as shown on the documentation.
Regards,
- Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Roger Lu <roger.lu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Boichat <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
YT Lee <yt.lee@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine
Date: Fri, 24 Dec 2021 10:34:46 +0100 [thread overview]
Message-ID: <fc825af2-7331-fa05-26e0-f3054557333a@collabora.com> (raw)
In-Reply-To: <6cdc903250723a6c547bccf2546dd10091b76249.camel@mediatek.com>
Il 24/12/21 10:27, Roger Lu ha scritto:
> Hi AngeloGioacchino,
>
> Sorry for the late reply and thanks for all the advices.
>
> On Thu, 2021-10-21 at 10:46 +0200, AngeloGioacchino Del Regno wrote:
>> Il 28/04/21 08:54, Roger Lu ha scritto:
>>> The Smart Voltage Scaling(SVS) engine is a piece of hardware
>>> which calculates suitable SVS bank voltages to OPP voltage table.
>>> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
>>> when receiving OPP_EVENT_ADJUST_VOLTAGE.
>>>
>>> Signed-off-by: Roger Lu <roger.lu@mediatek.com>
>>> ---
>>> drivers/soc/mediatek/Kconfig | 10 +
>>> drivers/soc/mediatek/Makefile | 1 +
>>> drivers/soc/mediatek/mtk-svs.c | 1723 ++++++++++++++++++++++++++++++++
>>> 3 files changed, 1734 insertions(+)
>>> create mode 100644 drivers/soc/mediatek/mtk-svs.c
>
> [snip]
>
>>> +/* svs bank common setting */
>>> +#define SVSB_DET_CLK_EN BIT(31)
>>> +#define SVSB_TZONE_HIGH_TEMP_MAX U32_MAX
>>> +#define SVSB_RUNCONFIG_DEFAULT 0x80000000
>>> +#define SVSB_DC_SIGNED_BIT 0x8000
>>> +#define SVSB_INTEN_INIT0x 0x00005f01
>>> +#define SVSB_INTEN_MONVOPEN 0x00ff0000
>>> +#define SVSB_EN_OFF 0x0
>>> +#define SVSB_EN_MASK 0x7
>>> +#define SVSB_EN_INIT01 0x1
>>> +#define SVSB_EN_INIT02 0x5
>>> +#define SVSB_EN_MON 0x2
>>> +#define SVSB_INTSTS_MONVOP 0x00ff0000
>>> +#define SVSB_INTSTS_COMPLETE 0x1
>>> +#define SVSB_INTSTS_CLEAN 0x00ffffff
>>> +
>>> +static DEFINE_SPINLOCK(mtk_svs_lock);
>>> +
>>> +/*
>>
>> Thanks for using kernel-doc!! However, to be proper, this has to be
>> /**
>> * ..........
>
> Oh okay. Thanks. I will use /** to add multi-line comments. However, I checked
> kernel doc-guide and it uses indent as below. So, I'll follow it. If I'm doing
> it wrong, please correct me. Thanks a lot.
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
>
> /**
> * .........
>
You're welcome! By the way, yes, the indentation is as shown on the documentation.
Regards,
- Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-24 9:34 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 6:54 [PATCH v16 0/7] soc: mediatek: SVS: introduce MTK SVS Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` [PATCH v16 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` [PATCH v16 2/7] arm64: dts: mt8183: add svs device information Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-10-20 15:20 ` AngeloGioacchino Del Regno
2021-10-20 15:20 ` AngeloGioacchino Del Regno
2021-10-20 15:20 ` AngeloGioacchino Del Regno
2021-12-24 7:33 ` Roger Lu
2021-12-24 7:33 ` Roger Lu
2021-12-24 7:33 ` Roger Lu
2021-12-30 12:54 ` Matthias Brugger
2021-12-30 12:54 ` Matthias Brugger
2021-12-30 12:54 ` Matthias Brugger
2022-01-03 6:08 ` Roger Lu
2022-01-03 6:08 ` Roger Lu
2022-01-03 6:08 ` Roger Lu
2021-04-28 6:54 ` [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-05-06 4:51 ` Guenter Roeck
2021-05-06 4:51 ` Guenter Roeck
2021-05-06 4:51 ` Guenter Roeck
2021-05-14 3:10 ` Roger Lu
2021-05-14 3:10 ` Roger Lu
2021-05-14 3:10 ` Roger Lu
2021-05-14 3:33 ` Guenter Roeck
2021-05-14 3:33 ` Guenter Roeck
2021-05-14 3:33 ` Guenter Roeck
2021-05-14 5:58 ` Roger Lu
2021-05-14 5:58 ` Roger Lu
2021-05-14 5:58 ` Roger Lu
2021-10-21 8:46 ` AngeloGioacchino Del Regno
2021-10-21 8:46 ` AngeloGioacchino Del Regno
2021-10-21 8:46 ` AngeloGioacchino Del Regno
2021-12-24 9:27 ` Roger Lu
2021-12-24 9:27 ` Roger Lu
2021-12-24 9:27 ` Roger Lu
2021-12-24 9:34 ` AngeloGioacchino Del Regno [this message]
2021-12-24 9:34 ` AngeloGioacchino Del Regno
2021-12-24 9:34 ` AngeloGioacchino Del Regno
2021-04-28 6:54 ` [PATCH v16 4/7] soc: mediatek: SVS: add debug commands Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-10-21 8:52 ` AngeloGioacchino Del Regno
2021-10-21 8:52 ` AngeloGioacchino Del Regno
2021-10-21 8:52 ` AngeloGioacchino Del Regno
2021-12-24 9:38 ` Roger Lu
2021-12-24 9:38 ` Roger Lu
2021-12-24 9:38 ` Roger Lu
2021-04-28 6:54 ` [PATCH v16 5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` [PATCH v16 6/7] arm64: dts: mt8192: add svs device information Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-10-20 15:16 ` AngeloGioacchino Del Regno
2021-10-20 15:16 ` AngeloGioacchino Del Regno
2021-10-20 15:16 ` AngeloGioacchino Del Regno
2021-12-24 9:42 ` Roger Lu
2021-12-24 9:42 ` Roger Lu
2021-12-24 9:42 ` Roger Lu
2021-10-20 15:18 ` AngeloGioacchino Del Regno
2021-10-20 15:18 ` AngeloGioacchino Del Regno
2021-10-20 15:18 ` AngeloGioacchino Del Regno
2021-04-28 6:54 ` [PATCH v16 7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-04-28 6:54 ` Roger Lu
2021-05-14 3:20 ` YT Lee
2021-05-14 3:20 ` YT Lee
2021-05-14 3:20 ` YT Lee
2021-10-21 9:08 ` AngeloGioacchino Del Regno
2021-10-21 9:08 ` AngeloGioacchino Del Regno
2021-10-21 9:08 ` AngeloGioacchino Del Regno
2021-12-30 13:18 ` [PATCH v16 0/7] soc: mediatek: SVS: introduce MTK SVS Matthias Brugger
2021-12-30 13:18 ` Matthias Brugger
2021-12-30 13:18 ` Matthias Brugger
2022-01-03 7:43 ` Roger Lu
2022-01-03 7:43 ` Roger Lu
2022-01-03 7:43 ` Roger Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc825af2-7331-fa05-26e0-f3054557333a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Angus.Lin@mediatek.com \
--cc=Charles.Yang@mediatek.com \
--cc=HenryC.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Xiaoqing.Liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=sboyd@kernel.org \
--cc=yt.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.