All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Phillip Susi <psusi@ubuntu.com>
Cc: Debian m68k <debian-68k@lists.debian.org>,
	Linux/m68k <linux-m68k@vger.kernel.org>,
	Parted development <parted-devel@lists.alioth.debian.org>
Subject: Re: [parted-devel] Atari label false positives
Date: Sun, 13 May 2018 07:22:17 +1200	[thread overview]
Message-ID: <fc99627f-ebb7-d556-2f69-72b4f5a557ef@gmail.com> (raw)
In-Reply-To: <fee352b1-4dbc-b02e-65b1-f138e84a6042@physik.fu-berlin.de>

Hi Adrian,

Am 12.05.2018 um 23:24 schrieb John Paul Adrian Glaubitz:
> On 05/12/2018 10:41 AM, Michael Schmitz wrote:
>>>> Do you have a dump of the root sector (plus additional eventual
>>>> extended
>>>> partition root sector) from these bugs?
>>>
>>> This is a very good point. We should have a look at the probing code in
>>> the kernel because apparently the problem doesn't exist there.
>>
>> It may not exist because the MSDOS partition detection is specific
>> enough to reject Atari partition tables. But still, compare the kernel
>> partition parsers to see what may be missing.
> 
> Which would mean that the kernel probes for DOS partition tables before
> Atari partition tables, wouldn't it?

Yes, it does (as I had stated earlier - block/partitions/checks.c has
only a few rather more specific formats listed before MSDOS. Sorry if
that wasn't clear.).

> 
> Adrian
> 

  reply	other threads:[~2018-05-12 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2d6f5455-963d-b044-a64d-67634df46071@ubuntu.com>
     [not found] ` <2d6f5455-963d-b044-a64d-67634df46071-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-05-11 15:29   ` Atari label false positives John Paul Adrian Glaubitz
     [not found]     ` <35ad9889-bc13-56bd-7831-f7bb3eea2d1e-1Olz3AKvcsuAKZTfuerNgRvVK+yQ3ZXh@public.gmane.org>
2018-05-11 15:56       ` Phillip Susi
     [not found]         ` <874bf955-d5bc-5d9c-0f87-445da67f3bdd-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-05-11 16:10           ` John Paul Adrian Glaubitz
2018-05-11 18:30             ` [parted-devel] " Richard Z
2018-05-11 23:17         ` Michael Schmitz
     [not found]           ` <80a28dd6-ce19-e6ed-fc7a-c5561fecf989-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-12  7:59             ` John Paul Adrian Glaubitz
2018-05-12  8:41               ` [parted-devel] " Michael Schmitz
     [not found]                 ` <c1bf0748-f7e0-b109-8c9e-26f8a2c70bf3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-12 11:24                   ` John Paul Adrian Glaubitz
2018-05-12 19:22                     ` Michael Schmitz [this message]
2018-05-14 13:02                   ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc99627f-ebb7-d556-2f69-72b4f5a557ef@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=debian-68k@lists.debian.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-m68k@vger.kernel.org \
    --cc=parted-devel@lists.alioth.debian.org \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.