All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
	<lee.jones@linaro.org>, <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <romain.izard.pro@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP
Date: Fri, 9 Jul 2021 11:11:40 +0200	[thread overview]
Message-ID: <fcdd81f2-c52d-758f-9788-b5b471302f77@microchip.com> (raw)
In-Reply-To: <20210705113104.579535-2-claudiu.beznea@microchip.com>

On 05/07/2021 at 13:31, Claudiu Beznea wrote:
> Remove compilation flag and use __maybe_unused and pm_ptr instead.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/mfd/atmel-flexcom.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index d2f5c073fdf3..962f66dc8813 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -87,8 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = {
>   };
>   MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
>   
> -#ifdef CONFIG_PM_SLEEP
> -static int atmel_flexcom_resume(struct device *dev)
> +static int __maybe_unused atmel_flexcom_resume(struct device *dev)
>   {
>   	struct atmel_flexcom *ddata = dev_get_drvdata(dev);
>   	int err;
> @@ -105,7 +104,6 @@ static int atmel_flexcom_resume(struct device *dev)
>   
>   	return 0;
>   }
> -#endif
>   
>   static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL,
>   			 atmel_flexcom_resume);
> @@ -114,7 +112,7 @@ static struct platform_driver atmel_flexcom_driver = {
>   	.probe	= atmel_flexcom_probe,
>   	.driver	= {
>   		.name		= "atmel_flexcom",
> -		.pm		= &atmel_flexcom_pm_ops,
> +		.pm		= pm_ptr(&atmel_flexcom_pm_ops),
>   		.of_match_table	= atmel_flexcom_of_match,
>   	},
>   };
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
	<lee.jones@linaro.org>, <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <romain.izard.pro@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP
Date: Fri, 9 Jul 2021 11:11:40 +0200	[thread overview]
Message-ID: <fcdd81f2-c52d-758f-9788-b5b471302f77@microchip.com> (raw)
In-Reply-To: <20210705113104.579535-2-claudiu.beznea@microchip.com>

On 05/07/2021 at 13:31, Claudiu Beznea wrote:
> Remove compilation flag and use __maybe_unused and pm_ptr instead.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/mfd/atmel-flexcom.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index d2f5c073fdf3..962f66dc8813 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -87,8 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = {
>   };
>   MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
>   
> -#ifdef CONFIG_PM_SLEEP
> -static int atmel_flexcom_resume(struct device *dev)
> +static int __maybe_unused atmel_flexcom_resume(struct device *dev)
>   {
>   	struct atmel_flexcom *ddata = dev_get_drvdata(dev);
>   	int err;
> @@ -105,7 +104,6 @@ static int atmel_flexcom_resume(struct device *dev)
>   
>   	return 0;
>   }
> -#endif
>   
>   static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL,
>   			 atmel_flexcom_resume);
> @@ -114,7 +112,7 @@ static struct platform_driver atmel_flexcom_driver = {
>   	.probe	= atmel_flexcom_probe,
>   	.driver	= {
>   		.name		= "atmel_flexcom",
> -		.pm		= &atmel_flexcom_pm_ops,
> +		.pm		= pm_ptr(&atmel_flexcom_pm_ops),
>   		.of_match_table	= atmel_flexcom_of_match,
>   	},
>   };
> 


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-09  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:31 [PATCH 0/2] mfd: atmel-flexcom: add a fix and code cosmetics Claudiu Beznea
2021-07-05 11:31 ` Claudiu Beznea
2021-07-05 11:31 ` [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea
2021-07-05 11:31   ` Claudiu Beznea
2021-07-09  9:11   ` Nicolas Ferre [this message]
2021-07-09  9:11     ` Nicolas Ferre
2021-07-05 11:31 ` [PATCH 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea
2021-07-05 11:31   ` Claudiu Beznea
2021-07-09  9:09   ` Codrin.Ciubotariu
2021-07-09  9:09     ` Codrin.Ciubotariu
2021-07-09  9:12   ` Nicolas Ferre
2021-07-09  9:12     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcdd81f2-c52d-758f-9788-b5b471302f77@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=romain.izard.pro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.