From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Matan Azrad" <matan@mellanox.com>
Cc: dev@dpdk.org, Ophir Munk <ophirmu@mellanox.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup
Date: Tue, 22 May 2018 14:59:44 +0100 [thread overview]
Message-ID: <fce38aae-54ed-a578-4d36-deeb30793bf4@intel.com> (raw)
In-Reply-To: <20180522131459.3nvrgvkjbv6tlv52@bidouze.vm.6wind.com>
On 5/22/2018 2:14 PM, Gaëtan Rivet wrote:
> On Tue, May 22, 2018 at 12:38:46PM +0000, Matan Azrad wrote:
>> The fail-safe PMD registers to RMV event for each removable sub-device
>> port in order to cleanup the sub-device resources and switch the Tx
>> sub-device directly when it is plugged-out.
>>
>> During removal time, the fail-safe PMD stops and closes the sub-device
>> but it doesn't unregister the LSC and RMV callbacks of the sub-device
>> port.
>>
>> It can lead the callbacks to be called for a port which is no more
>> associated with the fail-safe sub-device, because there is not a
>> guarantee that a sub-device gets the same port ID for each plug-in
>> process. This port, for example, may belong to another sub-device of a
>> different fail-safe device.
>>
>> Unregister the LSC and RMV callbacks for sub-devices which are not
>> used.
>>
>> Fixes: 598fb8aec6f6 ("net/failsafe: support device removal")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-05-22 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 18:52 [PATCH 1/2] net/failsafe: fix removed sub-device cleanup Matan Azrad
2018-05-17 18:52 ` [PATCH 2/2] net/failsafe: fix duplicate event registraton Matan Azrad
2018-05-21 18:13 ` [PATCH 1/2] net/failsafe: fix removed sub-device cleanup Ophir Munk
2018-05-21 19:48 ` [PATCH v2 " Matan Azrad
2018-05-21 19:48 ` [PATCH v2 2/2] net/failsafe: fix duplicate event registration Matan Azrad
2018-05-22 8:56 ` [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup Gaëtan Rivet
2018-05-22 10:19 ` Matan Azrad
2018-05-22 11:53 ` Gaëtan Rivet
2018-05-22 12:09 ` Matan Azrad
2018-05-22 12:38 ` [PATCH v3 " Matan Azrad
2018-05-22 12:38 ` [PATCH v3 2/2] net/failsafe: fix duplicate event registration Matan Azrad
2018-05-22 13:15 ` Gaëtan Rivet
2018-05-22 13:14 ` [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup Gaëtan Rivet
2018-05-22 13:59 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce38aae-54ed-a578-4d36-deeb30793bf4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.