* [PATCH] staging: vt6656: Power save stop wake_up_count wrap around.
@ 2020-04-14 10:39 ` Malcolm Priestley
0 siblings, 0 replies; 4+ messages in thread
From: Malcolm Priestley @ 2020-04-14 10:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-wireless, stable
conf.listen_interval can sometimes be zero causing wake_up_count
to wrap around up to many beacons too late causing
CTRL-EVENT-BEACON-LOSS as in.
wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ]
Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
drivers/staging/vt6656/usbpipe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index eae211e5860f..91b62c3dff7b 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -207,7 +207,8 @@ static void vnt_int_process_data(struct vnt_private *priv)
priv->wake_up_count =
priv->hw->conf.listen_interval;
- --priv->wake_up_count;
+ if (priv->wake_up_count)
+ --priv->wake_up_count;
/* Turn on wake up to listen next beacon */
if (priv->wake_up_count == 1)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: vt6656: Power save stop wake_up_count wrap around.
@ 2020-04-14 10:39 ` Malcolm Priestley
0 siblings, 0 replies; 4+ messages in thread
From: Malcolm Priestley @ 2020-04-14 10:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-wireless, stable
conf.listen_interval can sometimes be zero causing wake_up_count
to wrap around up to many beacons too late causing
CTRL-EVENT-BEACON-LOSS as in.
wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ]
Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
drivers/staging/vt6656/usbpipe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index eae211e5860f..91b62c3dff7b 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -207,7 +207,8 @@ static void vnt_int_process_data(struct vnt_private *priv)
priv->wake_up_count =
priv->hw->conf.listen_interval;
- --priv->wake_up_count;
+ if (priv->wake_up_count)
+ --priv->wake_up_count;
/* Turn on wake up to listen next beacon */
if (priv->wake_up_count == 1)
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vt6656: Power save stop wake_up_count wrap around.
2020-04-14 10:39 ` Malcolm Priestley
@ 2020-04-21 19:56 ` Sasha Levin
-1 siblings, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2020-04-21 19:56 UTC (permalink / raw)
To: Sasha Levin, Malcolm Priestley, Greg Kroah-Hartman; +Cc: devel, stable, stable
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.").
The bot has tested the following trees: v5.6.5, v5.5.18, v5.4.33, v4.19.116, v4.14.176, v4.9.219, v4.4.219.
v5.6.5: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v5.5.18: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v5.4.33: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v4.19.116: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
v4.14.176: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
v4.9.219: Failed to apply! Possible dependencies:
0ef48913354e ("staging:vt6656:mac.c Aligned code to match open parenthesis")
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
812930665872 ("staging: vt6656: Alignment should match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
a4dc9bd6a35d ("staging: vt6656: convert spaces to tabs for rf.c")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument without identifier name issue")
v4.4.219: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
1322739849a8 ("staging:vt6656:baseband.h: Fix alignment issue")
555d7a3ada13 ("staging:vt6656:dpc.h:fix parantheses alignment")
5678824069d5 ("staging: vt6656: Add space to align functions")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
a9f47a456ae5 ("staging:vt6656:card.c:fix alignment checks")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument without identifier name issue")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vt6656: Power save stop wake_up_count wrap around.
@ 2020-04-21 19:56 ` Sasha Levin
0 siblings, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2020-04-21 19:56 UTC (permalink / raw)
To: Sasha Levin, Malcolm Priestley, Greg Kroah-Hartman; +Cc: devel, stable
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.").
The bot has tested the following trees: v5.6.5, v5.5.18, v5.4.33, v4.19.116, v4.14.176, v4.9.219, v4.4.219.
v5.6.5: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v5.5.18: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v5.4.33: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
v4.19.116: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
v4.14.176: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
v4.9.219: Failed to apply! Possible dependencies:
0ef48913354e ("staging:vt6656:mac.c Aligned code to match open parenthesis")
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
812930665872 ("staging: vt6656: Alignment should match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
a4dc9bd6a35d ("staging: vt6656: convert spaces to tabs for rf.c")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument without identifier name issue")
v4.4.219: Failed to apply! Possible dependencies:
10e9a359cea7 ("staging: vt6656: Delete int.c/h file and move functions to usbpipe")
1322739849a8 ("staging:vt6656:baseband.h: Fix alignment issue")
555d7a3ada13 ("staging:vt6656:dpc.h:fix parantheses alignment")
5678824069d5 ("staging: vt6656: Add space to align functions")
69cc1f925e1a ("staging: vt6656: limit reg output to block size")
6b4c6ce89204 ("staging: vt6656: add SPDX identifiers to all vt6656 driver files")
6ddcf34f113a ("staging: vt6656: Add missing identifier names")
7156f7d9c387 ("staging: vt6656: avoid discarding called function's return code")
759fc3c1e9b6 ("Staging: vt6656: Align lines to match open parenthesis")
9df8a97088f2 ("staging: vt6656: Fix styling of the comment related to SPDX-License-Identifier")
a9f47a456ae5 ("staging:vt6656:card.c:fix alignment checks")
e2aefba617e3 ("staging:vt6656:baseband.h: fix function definition argument without identifier name issue")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-21 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 10:39 [PATCH] staging: vt6656: Power save stop wake_up_count wrap around Malcolm Priestley
2020-04-14 10:39 ` Malcolm Priestley
2020-04-21 19:56 ` Sasha Levin
2020-04-21 19:56 ` Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.