From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Christoph Hellwig <hch@lst.de>, zhouchuangao <zhouchuangao@vivo.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/nvme/host: Use kobj_to_dev() API
Date: Mon, 21 Jun 2021 12:18:15 +0200 [thread overview]
Message-ID: <fd15a968-3d75-ba22-b0b0-4ed4d2a66372@metux.net> (raw)
In-Reply-To: <20210618141817.GA18781@lst.de>
On 18.06.21 16:18, Christoph Hellwig wrote:
> On Fri, Jun 18, 2021 at 07:10:58AM -0700, zhouchuangao wrote:
>> Use kobj_to_dev() API instead of container_of().
>
> Why? That just makes the code harder to read.
Why so ? Why to we have kobj_to_dev() at all ?
Do you suggest, we shall get rid of it (and all similar ones) ?
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
WARNING: multiple messages have this Message-ID (diff)
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Christoph Hellwig <hch@lst.de>, zhouchuangao <zhouchuangao@vivo.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/nvme/host: Use kobj_to_dev() API
Date: Mon, 21 Jun 2021 12:18:15 +0200 [thread overview]
Message-ID: <fd15a968-3d75-ba22-b0b0-4ed4d2a66372@metux.net> (raw)
In-Reply-To: <20210618141817.GA18781@lst.de>
On 18.06.21 16:18, Christoph Hellwig wrote:
> On Fri, Jun 18, 2021 at 07:10:58AM -0700, zhouchuangao wrote:
>> Use kobj_to_dev() API instead of container_of().
>
> Why? That just makes the code harder to read.
Why so ? Why to we have kobj_to_dev() at all ?
Do you suggest, we shall get rid of it (and all similar ones) ?
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-21 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 14:10 [PATCH] drivers/nvme/host: Use kobj_to_dev() API zhouchuangao
2021-06-18 14:10 ` zhouchuangao
2021-06-18 14:18 ` Christoph Hellwig
2021-06-18 14:18 ` Christoph Hellwig
2021-06-19 5:01 ` 周传高
2021-06-19 5:01 ` 周传高
2021-06-20 17:27 ` Keith Busch
2021-06-20 17:27 ` Keith Busch
2021-06-21 3:11 ` Chaitanya Kulkarni
2021-06-21 3:11 ` Chaitanya Kulkarni
2021-06-21 10:18 ` Enrico Weigelt, metux IT consult [this message]
2021-06-21 10:18 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd15a968-3d75-ba22-b0b0-4ed4d2a66372@metux.net \
--to=lkml@metux.net \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=zhouchuangao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.