From: Oleksandr <olekstysh@gmail.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>, Christoph Hellwig <hch@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property description for xen-virtio layer Date: Sun, 17 Apr 2022 20:24:07 +0300 [thread overview] Message-ID: <fd3a53da-e3a4-5503-30d7-07b180c6d227@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2204151300130.915916@ubuntu-linux-20-04-desktop> On 16.04.22 01:01, Stefano Stabellini wrote: Hello Stefano > On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> >> Introduce Xen specific binding for the virtio-mmio device to be used >> by Xen virtio support driver in a subsequent commit. >> >> This binding specifies the ID of Xen domain where the corresponding >> device (backend) resides. This is needed for the option to restrict >> memory access using Xen grant mappings to work. >> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> --- >> .../devicetree/bindings/virtio/xen,dev-domid.yaml | 39 ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> >> diff --git a/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> new file mode 100644 >> index 00000000..78be993 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> @@ -0,0 +1,39 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/virtio/xen,dev-domid.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific binding for the virtio device >> + >> +maintainers: >> + - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> + >> +select: true >> + >> +description: >> + This binding specifies the ID of Xen domain where the corresponding device >> + (backend) resides. This is needed for the option to restrict memory access >> + using Xen grant mappings to work. >> + >> + Note that current and generic "iommus" bindings are mutually exclusive, since >> + the restricted memory access model on Xen behaves as a kind of software IOMMU. > I don't think that this last statement is necessary or fully accurate, so > I would remove it. ok, will remove > Other than that, this looks good to me. thank you > > >> +properties: >> + xen,dev-domid: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Should contain the ID of device's domain. > Maybe better as: > "The domid (domain ID) of the domain where the device (backend) is running" ok, will change > > > >> +additionalProperties: true >> + >> +examples: >> + - | >> + virtio_block@3000 { >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The device is located in Xen domain with ID 1 */ >> + xen,dev-domid = <1>; >> + }; >> -- >> 2.7.4 >> -- Regards, Oleksandr Tyshchenko
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr <olekstysh@gmail.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>, Christoph Hellwig <hch@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property description for xen-virtio layer Date: Sun, 17 Apr 2022 20:24:07 +0300 [thread overview] Message-ID: <fd3a53da-e3a4-5503-30d7-07b180c6d227@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2204151300130.915916@ubuntu-linux-20-04-desktop> On 16.04.22 01:01, Stefano Stabellini wrote: Hello Stefano > On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> >> Introduce Xen specific binding for the virtio-mmio device to be used >> by Xen virtio support driver in a subsequent commit. >> >> This binding specifies the ID of Xen domain where the corresponding >> device (backend) resides. This is needed for the option to restrict >> memory access using Xen grant mappings to work. >> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> --- >> .../devicetree/bindings/virtio/xen,dev-domid.yaml | 39 ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> >> diff --git a/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> new file mode 100644 >> index 00000000..78be993 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/virtio/xen,dev-domid.yaml >> @@ -0,0 +1,39 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/virtio/xen,dev-domid.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific binding for the virtio device >> + >> +maintainers: >> + - Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> >> + >> +select: true >> + >> +description: >> + This binding specifies the ID of Xen domain where the corresponding device >> + (backend) resides. This is needed for the option to restrict memory access >> + using Xen grant mappings to work. >> + >> + Note that current and generic "iommus" bindings are mutually exclusive, since >> + the restricted memory access model on Xen behaves as a kind of software IOMMU. > I don't think that this last statement is necessary or fully accurate, so > I would remove it. ok, will remove > Other than that, this looks good to me. thank you > > >> +properties: >> + xen,dev-domid: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Should contain the ID of device's domain. > Maybe better as: > "The domid (domain ID) of the domain where the device (backend) is running" ok, will change > > > >> +additionalProperties: true >> + >> +examples: >> + - | >> + virtio_block@3000 { >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The device is located in Xen domain with ID 1 */ >> + xen,dev-domid = <1>; >> + }; >> -- >> 2.7.4 >> -- Regards, Oleksandr Tyshchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-17 17:24 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-14 19:19 [RFC PATCH 0/6] virtio: Solution to restrict memory access under Xen using xen-virtio DMA ops layer Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-14 19:19 ` [RFC PATCH 1/6] xen/grants: support allocating consecutive grants Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-14 19:19 ` [RFC PATCH 2/6] virtio: add option to restrict memory access under Xen Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-14 19:43 ` H. Peter Anvin 2022-04-15 15:20 ` Oleksandr 2022-04-15 15:20 ` Oleksandr 2022-04-15 22:01 ` Stefano Stabellini 2022-04-17 17:02 ` Oleksandr 2022-04-17 17:02 ` Oleksandr 2022-04-18 19:11 ` Stefano Stabellini 2022-04-18 19:11 ` Stefano Stabellini 2022-04-19 6:21 ` Juergen Gross 2022-04-19 6:21 ` Juergen Gross 2022-04-19 6:37 ` Oleksandr 2022-04-19 6:37 ` Oleksandr 2022-04-14 19:19 ` [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid property description for xen-virtio layer Oleksandr Tyshchenko 2022-04-14 19:19 ` [RFC PATCH 3/6] dt-bindings: xen: Add xen, dev-domid " Oleksandr Tyshchenko 2022-04-15 22:01 ` [RFC PATCH 3/6] dt-bindings: xen: Add xen,dev-domid " Stefano Stabellini 2022-04-15 22:01 ` Stefano Stabellini 2022-04-17 17:24 ` Oleksandr [this message] 2022-04-17 17:24 ` Oleksandr 2022-04-14 19:19 ` [RFC PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-15 22:02 ` Stefano Stabellini 2022-04-15 22:02 ` Stefano Stabellini 2022-04-17 18:21 ` Oleksandr 2022-04-17 18:21 ` Oleksandr 2022-04-18 19:11 ` Stefano Stabellini 2022-04-18 19:11 ` Stefano Stabellini 2022-04-19 6:58 ` Juergen Gross 2022-04-19 6:58 ` Juergen Gross 2022-04-19 7:07 ` Oleksandr 2022-04-19 7:07 ` Oleksandr 2022-04-16 6:05 ` Christoph Hellwig 2022-04-16 6:05 ` Christoph Hellwig 2022-04-17 18:39 ` Oleksandr 2022-04-17 18:39 ` Oleksandr 2022-04-14 19:19 ` [RFC PATCH 5/6] arm/xen: Introduce xen_setup_dma_ops() Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-15 22:02 ` Stefano Stabellini 2022-04-15 22:02 ` Stefano Stabellini 2022-04-17 18:43 ` Oleksandr 2022-04-17 18:43 ` Oleksandr 2022-04-14 19:19 ` [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests Oleksandr Tyshchenko 2022-04-14 19:19 ` Oleksandr Tyshchenko 2022-04-15 22:02 ` Stefano Stabellini 2022-04-15 22:02 ` Stefano Stabellini 2022-04-16 6:07 ` Christoph Hellwig 2022-04-16 6:07 ` Christoph Hellwig 2022-04-17 21:05 ` Oleksandr 2022-04-17 21:05 ` Oleksandr 2022-04-18 19:11 ` Stefano Stabellini 2022-04-18 19:11 ` Stefano Stabellini 2022-04-19 12:17 ` Oleksandr 2022-04-19 12:17 ` Oleksandr 2022-04-19 14:48 ` Juergen Gross 2022-04-19 14:48 ` Juergen Gross 2022-04-19 17:11 ` Oleksandr 2022-04-19 17:11 ` Oleksandr 2022-04-20 0:23 ` Stefano Stabellini 2022-04-20 0:23 ` Stefano Stabellini 2022-04-20 9:00 ` Oleksandr 2022-04-20 9:00 ` Oleksandr 2022-04-20 22:49 ` Stefano Stabellini 2022-04-20 22:49 ` Stefano Stabellini 2022-04-17 19:20 ` Oleksandr 2022-04-17 19:20 ` Oleksandr 2022-04-15 7:41 ` [RFC PATCH 0/6] virtio: Solution to restrict memory access under Xen using xen-virtio DMA ops layer Christoph Hellwig 2022-04-15 7:41 ` Christoph Hellwig 2022-04-15 7:41 ` Christoph Hellwig 2022-04-15 10:04 ` Oleksandr 2022-04-15 10:04 ` Oleksandr 2022-04-15 8:44 ` Michael S. Tsirkin 2022-04-15 8:44 ` Michael S. Tsirkin 2022-04-15 8:44 ` Michael S. Tsirkin 2022-04-15 15:29 ` Oleksandr 2022-04-15 15:29 ` Oleksandr
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fd3a53da-e3a4-5503-30d7-07b180c6d227@gmail.com \ --to=olekstysh@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=hch@infradead.org \ --cc=jasowang@redhat.com \ --cc=jgross@suse.com \ --cc=julien@xen.org \ --cc=krzk+dt@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=oleksandr_tyshchenko@epam.com \ --cc=robh+dt@kernel.org \ --cc=sstabellini@kernel.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.