All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY
@ 2023-10-17  8:03 Sakari Ailus
  2023-10-18 15:21 ` Randy Dunlap
  2023-10-23  6:29 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Sakari Ailus @ 2023-10-17  8:03 UTC (permalink / raw)
  To: linux-phy; +Cc: Vinod Koul, Kishon Vijay Abraham I

GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as
GENERIC_PHY has no dependencies. This way drivers that depend on
GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they
apparently often omit, too, which further leads to build failures.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index d1670bbe6d6b..787354b849c7 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -18,7 +18,7 @@ config GENERIC_PHY
 
 config GENERIC_PHY_MIPI_DPHY
 	bool
-	depends on GENERIC_PHY
+	select GENERIC_PHY
 	help
 	  Generic MIPI D-PHY support.
 
-- 
2.39.2


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY
  2023-10-17  8:03 [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY Sakari Ailus
@ 2023-10-18 15:21 ` Randy Dunlap
  2023-10-23  6:29 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-10-18 15:21 UTC (permalink / raw)
  To: Sakari Ailus, linux-phy; +Cc: Vinod Koul, Kishon Vijay Abraham I



On 10/17/23 01:03, Sakari Ailus wrote:
> GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as
> GENERIC_PHY has no dependencies. This way drivers that depend on
> GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they
> apparently often omit, too, which further leads to build failures.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index d1670bbe6d6b..787354b849c7 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -18,7 +18,7 @@ config GENERIC_PHY
>  
>  config GENERIC_PHY_MIPI_DPHY
>  	bool
> -	depends on GENERIC_PHY
> +	select GENERIC_PHY
>  	help
>  	  Generic MIPI D-PHY support.
>  

-- 
~Randy

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY
  2023-10-17  8:03 [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY Sakari Ailus
  2023-10-18 15:21 ` Randy Dunlap
@ 2023-10-23  6:29 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-10-23  6:29 UTC (permalink / raw)
  To: linux-phy, Sakari Ailus; +Cc: Kishon Vijay Abraham I


On Tue, 17 Oct 2023 11:03:54 +0300, Sakari Ailus wrote:
> GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as
> GENERIC_PHY has no dependencies. This way drivers that depend on
> GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they
> apparently often omit, too, which further leads to build failures.
> 
> 

Applied, thanks!

[1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY
      commit: d0ec7b9c3153c941f98226001d4019d9c03faf81

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-23  6:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17  8:03 [PATCH 1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY Sakari Ailus
2023-10-18 15:21 ` Randy Dunlap
2023-10-23  6:29 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.