* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-30 14:58 ` Grygorii Strashko
0 siblings, 0 replies; 14+ messages in thread
From: Grygorii Strashko @ 2016-08-30 14:58 UTC (permalink / raw)
To: Tony Lindgren
Cc: Sekhar Nori, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
J.D. Schroeder, Tero Kristo, Lokesh Vutla, Grygorii Strashko
From: "J.D. Schroeder" <jay.schroeder-UF6BFNFdnjXQT0dZR+AlfA@public.gmane.org>
This commit fixes the clock data inside the DRA7xx clocks device tree
structure for the gmac_gmii_ref_clk_div clock. This clock is actually
the GMAC_MAIN_CLK and has nothing to do with the register at address
0x4a0093d0. If CLKSEL_REF bit 24 inside of CM_GMAC_GMAC_CLKCTRL, is
set to 1 in order to use the GMAC_RMII_CLK instead of the
GMAC_RMII_HS_CLK, the kernel generates a clock divider warning:
WARNING: CPU: 0 PID: 0 at drivers/clk/clk-divider.c:129 clk_divider_recalc_rate+0xa8/0xe0()
gmac_gmii_ref_clk_div: Zero divisor and CLK_DIVIDER_ALLOW_ZERO not set
By properly configuring the gmac_gmii_ref_clk_div (GMAC_MAIN_CLK) to
have the parent of dpll_gmac_m2_ck always divided by 2 the warning is
resolved and the clock tree is fixed up.
Additionally, a new clock called rmii_50mhz_clk_mux is defined that
does utilize CM_GMAC_GMAC_CLKCTRL[24] CLKSEL_REF to configure the
source clock for the RMII_50MHZ_CLK.
Cc: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Cc: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
Signed-off-by: J.D. Schroeder <jay.schroeder-UF6BFNFdnjXQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Trenton Andres <trenton.andres-UF6BFNFdnjXQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
Hi Tony,
Originally this patch was posted (and acked) here
https://lkml.org/lkml/2016/4/27/272,
but it, unfortunatelly, has never been merged.
So re-send + minor subj change.
arch/arm/boot/dts/dra7xx-clocks.dtsi | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
index 8378b44..3f0c61d 100644
--- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
@@ -1718,13 +1718,20 @@
reg = <0x0c00>;
};
- gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div@13d0 {
+ rmii_50mhz_clk_mux: rmii_50mhz_clk_mux@13d0 {
#clock-cells = <0>;
- compatible = "ti,divider-clock";
- clocks = <&dpll_gmac_m2_ck>;
+ compatible = "ti,mux-clock";
+ clocks = <&dpll_gmac_h11x2_ck>, <&rmii_clk_ck>;
ti,bit-shift = <24>;
reg = <0x13d0>;
- ti,dividers = <2>;
+ };
+
+ gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div {
+ #clock-cells = <0>;
+ compatible = "fixed-factor-clock";
+ clocks = <&dpll_gmac_m2_ck>;
+ clock-mult = <1>;
+ clock-div = <2>;
};
gmac_rft_clk_mux: gmac_rft_clk_mux@13d0 {
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-30 14:58 ` Grygorii Strashko
0 siblings, 0 replies; 14+ messages in thread
From: Grygorii Strashko @ 2016-08-30 14:58 UTC (permalink / raw)
To: linux-arm-kernel
From: "J.D. Schroeder" <jay.schroeder@garmin.com>
This commit fixes the clock data inside the DRA7xx clocks device tree
structure for the gmac_gmii_ref_clk_div clock. This clock is actually
the GMAC_MAIN_CLK and has nothing to do with the register at address
0x4a0093d0. If CLKSEL_REF bit 24 inside of CM_GMAC_GMAC_CLKCTRL, is
set to 1 in order to use the GMAC_RMII_CLK instead of the
GMAC_RMII_HS_CLK, the kernel generates a clock divider warning:
WARNING: CPU: 0 PID: 0 at drivers/clk/clk-divider.c:129 clk_divider_recalc_rate+0xa8/0xe0()
gmac_gmii_ref_clk_div: Zero divisor and CLK_DIVIDER_ALLOW_ZERO not set
By properly configuring the gmac_gmii_ref_clk_div (GMAC_MAIN_CLK) to
have the parent of dpll_gmac_m2_ck always divided by 2 the warning is
resolved and the clock tree is fixed up.
Additionally, a new clock called rmii_50mhz_clk_mux is defined that
does utilize CM_GMAC_GMAC_CLKCTRL[24] CLKSEL_REF to configure the
source clock for the RMII_50MHZ_CLK.
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
Reviewed-by: Trenton Andres <trenton.andres@garmin.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Hi Tony,
Originally this patch was posted (and acked) here
https://lkml.org/lkml/2016/4/27/272,
but it, unfortunatelly, has never been merged.
So re-send + minor subj change.
arch/arm/boot/dts/dra7xx-clocks.dtsi | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
index 8378b44..3f0c61d 100644
--- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
@@ -1718,13 +1718,20 @@
reg = <0x0c00>;
};
- gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div at 13d0 {
+ rmii_50mhz_clk_mux: rmii_50mhz_clk_mux at 13d0 {
#clock-cells = <0>;
- compatible = "ti,divider-clock";
- clocks = <&dpll_gmac_m2_ck>;
+ compatible = "ti,mux-clock";
+ clocks = <&dpll_gmac_h11x2_ck>, <&rmii_clk_ck>;
ti,bit-shift = <24>;
reg = <0x13d0>;
- ti,dividers = <2>;
+ };
+
+ gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div {
+ #clock-cells = <0>;
+ compatible = "fixed-factor-clock";
+ clocks = <&dpll_gmac_m2_ck>;
+ clock-mult = <1>;
+ clock-div = <2>;
};
gmac_rft_clk_mux: gmac_rft_clk_mux at 13d0 {
--
2.9.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: dra7: cpsw: fix clocks tree
2016-08-30 14:58 ` Grygorii Strashko
@ 2016-08-30 14:58 ` Grygorii Strashko
-1 siblings, 0 replies; 14+ messages in thread
From: Grygorii Strashko @ 2016-08-30 14:58 UTC (permalink / raw)
To: Tony Lindgren
Cc: Sekhar Nori, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Grygorii Strashko, Tero Kristo, Mugunthan V N
Current clocks tree definition for CPSW/CPTS doesn't
correspond TRM for dra7/am57 SoCs.
CPTS: has to be sourced from gmac_rft_clk_mux clock
CPSW: DPLL_GMAC -> CLKOUT_M2 -> GMAC_250M_CLK -> 1/2 ->
-> GMAC_MAIN_CLK (125 MHZ)
Hence, correct clock tree for GMAC_MAIN_CLK and use proper
clock for CPTS. This also require updating of CPTS clock
multiplier.
Cc: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Cc: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/dra7.dtsi | 4 ++--
arch/arm/boot/dts/dra7xx-clocks.dtsi | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index d9bfb94..9f14eed 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1717,7 +1717,7 @@
mac: ethernet@48484000 {
compatible = "ti,dra7-cpsw","ti,cpsw";
ti,hwmods = "gmac";
- clocks = <&dpll_gmac_ck>, <&gmac_gmii_ref_clk_div>;
+ clocks = <&gmac_main_clk>, <&gmac_rft_clk_mux>;
clock-names = "fck", "cpts";
cpdma_channels = <8>;
ale_entries = <1024>;
@@ -1726,7 +1726,7 @@
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
- cpts_clock_mult = <0x80000000>;
+ cpts_clock_mult = <0x784CFE14>;
cpts_clock_shift = <29>;
reg = <0x48484000 0x1000
0x48485200 0x2E00>;
diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
index 3f0c61d..3330738e 100644
--- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
@@ -1003,6 +1003,14 @@
ti,index-power-of-two;
};
+ gmac_main_clk: gmac_main_clk {
+ #clock-cells = <0>;
+ compatible = "fixed-factor-clock";
+ clocks = <&gmac_250m_dclk_div>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+
l3init_480m_dclk_div: l3init_480m_dclk_div@1ac {
#clock-cells = <0>;
compatible = "ti,divider-clock";
@@ -1726,14 +1734,6 @@
reg = <0x13d0>;
};
- gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div {
- #clock-cells = <0>;
- compatible = "fixed-factor-clock";
- clocks = <&dpll_gmac_m2_ck>;
- clock-mult = <1>;
- clock-div = <2>;
- };
-
gmac_rft_clk_mux: gmac_rft_clk_mux@13d0 {
#clock-cells = <0>;
compatible = "ti,mux-clock";
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: dra7: cpsw: fix clocks tree
@ 2016-08-30 14:58 ` Grygorii Strashko
0 siblings, 0 replies; 14+ messages in thread
From: Grygorii Strashko @ 2016-08-30 14:58 UTC (permalink / raw)
To: linux-arm-kernel
Current clocks tree definition for CPSW/CPTS doesn't
correspond TRM for dra7/am57 SoCs.
CPTS: has to be sourced from gmac_rft_clk_mux clock
CPSW: DPLL_GMAC -> CLKOUT_M2 -> GMAC_250M_CLK -> 1/2 ->
-> GMAC_MAIN_CLK (125 MHZ)
Hence, correct clock tree for GMAC_MAIN_CLK and use proper
clock for CPTS. This also require updating of CPTS clock
multiplier.
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 4 ++--
arch/arm/boot/dts/dra7xx-clocks.dtsi | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index d9bfb94..9f14eed 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1717,7 +1717,7 @@
mac: ethernet at 48484000 {
compatible = "ti,dra7-cpsw","ti,cpsw";
ti,hwmods = "gmac";
- clocks = <&dpll_gmac_ck>, <&gmac_gmii_ref_clk_div>;
+ clocks = <&gmac_main_clk>, <&gmac_rft_clk_mux>;
clock-names = "fck", "cpts";
cpdma_channels = <8>;
ale_entries = <1024>;
@@ -1726,7 +1726,7 @@
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
- cpts_clock_mult = <0x80000000>;
+ cpts_clock_mult = <0x784CFE14>;
cpts_clock_shift = <29>;
reg = <0x48484000 0x1000
0x48485200 0x2E00>;
diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
index 3f0c61d..3330738e 100644
--- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
@@ -1003,6 +1003,14 @@
ti,index-power-of-two;
};
+ gmac_main_clk: gmac_main_clk {
+ #clock-cells = <0>;
+ compatible = "fixed-factor-clock";
+ clocks = <&gmac_250m_dclk_div>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+
l3init_480m_dclk_div: l3init_480m_dclk_div at 1ac {
#clock-cells = <0>;
compatible = "ti,divider-clock";
@@ -1726,14 +1734,6 @@
reg = <0x13d0>;
};
- gmac_gmii_ref_clk_div: gmac_gmii_ref_clk_div {
- #clock-cells = <0>;
- compatible = "fixed-factor-clock";
- clocks = <&dpll_gmac_m2_ck>;
- clock-mult = <1>;
- clock-div = <2>;
- };
-
gmac_rft_clk_mux: gmac_rft_clk_mux at 13d0 {
#clock-cells = <0>;
compatible = "ti,mux-clock";
--
2.9.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
2016-08-30 14:58 ` Grygorii Strashko
@ 2016-08-30 18:41 ` Tony Lindgren
-1 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2016-08-30 18:41 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Sekhar Nori, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
J.D. Schroeder, Tero Kristo, Lokesh Vutla
* Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [160830 07:58]:
>
> Originally this patch was posted (and acked) here
> https://lkml.org/lkml/2016/4/27/272,
> but it, unfortunatelly, has never been merged.
> So re-send + minor subj change.
OK yeah sorry about that. And thanks for the resend. If some patches
have pending discussion as I tend to tag threads that have pending
discussion as read and then forget them. And I miss patches in other
ways too..
Tero, care to take a look and ack?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-30 18:41 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2016-08-30 18:41 UTC (permalink / raw)
To: linux-arm-kernel
* Grygorii Strashko <grygorii.strashko@ti.com> [160830 07:58]:
>
> Originally this patch was posted (and acked) here
> https://lkml.org/lkml/2016/4/27/272,
> but it, unfortunatelly, has never been merged.
> So re-send + minor subj change.
OK yeah sorry about that. And thanks for the resend. If some patches
have pending discussion as I tend to tag threads that have pending
discussion as read and then forget them. And I miss patches in other
ways too..
Tero, care to take a look and ack?
Regards,
Tony
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
2016-08-30 18:41 ` Tony Lindgren
@ 2016-08-31 6:08 ` Tero Kristo
-1 siblings, 0 replies; 14+ messages in thread
From: Tero Kristo @ 2016-08-31 6:08 UTC (permalink / raw)
To: Tony Lindgren, Grygorii Strashko
Cc: Sekhar Nori, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
J.D. Schroeder, Lokesh Vutla
On 30/08/16 21:41, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [160830 07:58]:
>>
>> Originally this patch was posted (and acked) here
>> https://lkml.org/lkml/2016/4/27/272,
>> but it, unfortunatelly, has never been merged.
>> So re-send + minor subj change.
>
> OK yeah sorry about that. And thanks for the resend. If some patches
> have pending discussion as I tend to tag threads that have pending
> discussion as read and then forget them. And I miss patches in other
> ways too..
>
> Tero, care to take a look and ack?
For both patches:
Acked-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-31 6:08 ` Tero Kristo
0 siblings, 0 replies; 14+ messages in thread
From: Tero Kristo @ 2016-08-31 6:08 UTC (permalink / raw)
To: linux-arm-kernel
On 30/08/16 21:41, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [160830 07:58]:
>>
>> Originally this patch was posted (and acked) here
>> https://lkml.org/lkml/2016/4/27/272,
>> but it, unfortunatelly, has never been merged.
>> So re-send + minor subj change.
>
> OK yeah sorry about that. And thanks for the resend. If some patches
> have pending discussion as I tend to tag threads that have pending
> discussion as read and then forget them. And I miss patches in other
> ways too..
>
> Tero, care to take a look and ack?
For both patches:
Acked-by: Tero Kristo <t-kristo@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] ARM: dts: dra7: cpsw: fix clocks tree
2016-08-30 14:58 ` Grygorii Strashko
@ 2016-08-31 8:38 ` Mugunthan V N
-1 siblings, 0 replies; 14+ messages in thread
From: Mugunthan V N @ 2016-08-31 8:38 UTC (permalink / raw)
To: Grygorii Strashko, Tony Lindgren
Cc: Tero Kristo, devicetree, linux-omap, Sekhar Nori, linux-arm-kernel
On Tuesday 30 August 2016 08:28 PM, Grygorii Strashko wrote:
> Current clocks tree definition for CPSW/CPTS doesn't
> correspond TRM for dra7/am57 SoCs.
>
> CPTS: has to be sourced from gmac_rft_clk_mux clock
> CPSW: DPLL_GMAC -> CLKOUT_M2 -> GMAC_250M_CLK -> 1/2 ->
> -> GMAC_MAIN_CLK (125 MHZ)
>
> Hence, correct clock tree for GMAC_MAIN_CLK and use proper
> clock for CPTS. This also require updating of CPTS clock
> multiplier.
>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: dra7: cpsw: fix clocks tree
@ 2016-08-31 8:38 ` Mugunthan V N
0 siblings, 0 replies; 14+ messages in thread
From: Mugunthan V N @ 2016-08-31 8:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 30 August 2016 08:28 PM, Grygorii Strashko wrote:
> Current clocks tree definition for CPSW/CPTS doesn't
> correspond TRM for dra7/am57 SoCs.
>
> CPTS: has to be sourced from gmac_rft_clk_mux clock
> CPSW: DPLL_GMAC -> CLKOUT_M2 -> GMAC_250M_CLK -> 1/2 ->
> -> GMAC_MAIN_CLK (125 MHZ)
>
> Hence, correct clock tree for GMAC_MAIN_CLK and use proper
> clock for CPTS. This also require updating of CPTS clock
> multiplier.
>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
2016-08-31 6:08 ` Tero Kristo
@ 2016-08-31 14:39 ` Tony Lindgren
-1 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2016-08-31 14:39 UTC (permalink / raw)
To: Tero Kristo
Cc: Grygorii Strashko, Sekhar Nori,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
J.D. Schroeder, Lokesh Vutla
* Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org> [160830 23:09]:
> On 30/08/16 21:41, Tony Lindgren wrote:
> > * Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [160830 07:58]:
> > >
> > > Originally this patch was posted (and acked) here
> > > https://lkml.org/lkml/2016/4/27/272,
> > > but it, unfortunatelly, has never been merged.
> > > So re-send + minor subj change.
> >
> > OK yeah sorry about that. And thanks for the resend. If some patches
> > have pending discussion as I tend to tag threads that have pending
> > discussion as read and then forget them. And I miss patches in other
> > ways too..
> >
> > Tero, care to take a look and ack?
>
> For both patches:
>
> Acked-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Thanks applying both into omap-for-v4.9/dt as the Ethernet works
currently.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-31 14:39 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2016-08-31 14:39 UTC (permalink / raw)
To: linux-arm-kernel
* Tero Kristo <t-kristo@ti.com> [160830 23:09]:
> On 30/08/16 21:41, Tony Lindgren wrote:
> > * Grygorii Strashko <grygorii.strashko@ti.com> [160830 07:58]:
> > >
> > > Originally this patch was posted (and acked) here
> > > https://lkml.org/lkml/2016/4/27/272,
> > > but it, unfortunatelly, has never been merged.
> > > So re-send + minor subj change.
> >
> > OK yeah sorry about that. And thanks for the resend. If some patches
> > have pending discussion as I tend to tag threads that have pending
> > discussion as read and then forget them. And I miss patches in other
> > ways too..
> >
> > Tero, care to take a look and ack?
>
> For both patches:
>
> Acked-by: Tero Kristo <t-kristo@ti.com>
Thanks applying both into omap-for-v4.9/dt as the Ethernet works
currently.
Regards,
Tony
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
2016-08-31 14:39 ` Tony Lindgren
@ 2016-08-31 17:34 ` Tero Kristo
-1 siblings, 0 replies; 14+ messages in thread
From: Tero Kristo @ 2016-08-31 17:34 UTC (permalink / raw)
To: Tony Lindgren
Cc: Grygorii Strashko, Sekhar Nori,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
J.D. Schroeder, Lokesh Vutla
On 31/08/16 17:39, Tony Lindgren wrote:
> * Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org> [160830 23:09]:
>> On 30/08/16 21:41, Tony Lindgren wrote:
>>> * Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [160830 07:58]:
>>>>
>>>> Originally this patch was posted (and acked) here
>>>> https://lkml.org/lkml/2016/4/27/272,
>>>> but it, unfortunatelly, has never been merged.
>>>> So re-send + minor subj change.
>>>
>>> OK yeah sorry about that. And thanks for the resend. If some patches
>>> have pending discussion as I tend to tag threads that have pending
>>> discussion as read and then forget them. And I miss patches in other
>>> ways too..
>>>
>>> Tero, care to take a look and ack?
>>
>> For both patches:
>>
>> Acked-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
>
> Thanks applying both into omap-for-v4.9/dt as the Ethernet works
> currently.
>
> Regards,
>
> Tony
>
Yea I think the ethernet clock rate happens to be the same in the
existing setup, just the hierarchy is wrong. That is at least what I saw
with quick testing.
-Tero
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div
@ 2016-08-31 17:34 ` Tero Kristo
0 siblings, 0 replies; 14+ messages in thread
From: Tero Kristo @ 2016-08-31 17:34 UTC (permalink / raw)
To: linux-arm-kernel
On 31/08/16 17:39, Tony Lindgren wrote:
> * Tero Kristo <t-kristo@ti.com> [160830 23:09]:
>> On 30/08/16 21:41, Tony Lindgren wrote:
>>> * Grygorii Strashko <grygorii.strashko@ti.com> [160830 07:58]:
>>>>
>>>> Originally this patch was posted (and acked) here
>>>> https://lkml.org/lkml/2016/4/27/272,
>>>> but it, unfortunatelly, has never been merged.
>>>> So re-send + minor subj change.
>>>
>>> OK yeah sorry about that. And thanks for the resend. If some patches
>>> have pending discussion as I tend to tag threads that have pending
>>> discussion as read and then forget them. And I miss patches in other
>>> ways too..
>>>
>>> Tero, care to take a look and ack?
>>
>> For both patches:
>>
>> Acked-by: Tero Kristo <t-kristo@ti.com>
>
> Thanks applying both into omap-for-v4.9/dt as the Ethernet works
> currently.
>
> Regards,
>
> Tony
>
Yea I think the ethernet clock rate happens to be the same in the
existing setup, just the hierarchy is wrong. That is at least what I saw
with quick testing.
-Tero
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-08-31 17:34 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-30 14:58 [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div Grygorii Strashko
2016-08-30 14:58 ` Grygorii Strashko
[not found] ` <20160830145801.10364-1-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-08-30 14:58 ` [PATCH 2/2] ARM: dts: dra7: cpsw: fix clocks tree Grygorii Strashko
2016-08-30 14:58 ` Grygorii Strashko
2016-08-31 8:38 ` Mugunthan V N
2016-08-31 8:38 ` Mugunthan V N
2016-08-30 18:41 ` [RESEND PATCH 1/2] ARM: dts: dra7: Fix clock data for gmac_gmii_ref_clk_div Tony Lindgren
2016-08-30 18:41 ` Tony Lindgren
[not found] ` <20160830184158.xydy3ixy7c5b73le-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-08-31 6:08 ` Tero Kristo
2016-08-31 6:08 ` Tero Kristo
[not found] ` <fd7850dd-b7a2-e6ef-508f-8406c3f2cea9-l0cyMroinI0@public.gmane.org>
2016-08-31 14:39 ` Tony Lindgren
2016-08-31 14:39 ` Tony Lindgren
[not found] ` <20160831143928.vxuaznyws2pipohu-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-08-31 17:34 ` Tero Kristo
2016-08-31 17:34 ` Tero Kristo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.