[PATCH] amt: remove unnecessary type castings

[PATCH] amt: remove unnecessary type castings

[Yu Zhe]

remove unnecessary void* type castings.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
 drivers/net/amt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index be2719a3ba70..6b4402c26206 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -1373,11 +1373,11 @@ static void amt_add_srcs(struct amt_dev *amt, struct amt_tunnel_list *tunnel,
 	int i;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
-- 
2.11.0

Re: [PATCH] amt: remove unnecessary type castings

[Taehee Yoo]

Hi Yu,
Thanks for your work!

2022. 7. 6. 오전 10:14에 Yu Zhe 이(가) 쓴 글:
 > remove unnecessary void* type castings.
 >
 > Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
 > ---
 >   drivers/net/amt.c | 4 ++--
 >   1 file changed, 2 insertions(+), 2 deletions(-)
 >
 > diff --git a/drivers/net/amt.c b/drivers/net/amt.c
 > index be2719a3ba70..6b4402c26206 100644
 > --- a/drivers/net/amt.c
 > +++ b/drivers/net/amt.c
 > @@ -1373,11 +1373,11 @@ static void amt_add_srcs(struct amt_dev *amt, 
struct amt_tunnel_list *tunnel,
 >   	int i;
 >
 >   	if (!v6) {
 > -		igmp_grec = (struct igmpv3_grec *)grec;
 > +		igmp_grec = grec;
 >   		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 >   	} else {
 >   #if IS_ENABLED(CONFIG_IPV6)
 > -		mld_grec = (struct mld2_grec *)grec;
 > +		mld_grec = grec;
 >   		nsrcs = ntohs(mld_grec->grec_nsrcs);
 >   #else
 >   	return;

You already sent the same patch[1] and it is merged[2], it can't be applied.

[1] https://marc.info/?l=linux-netdev&m=165577785300445&w=2
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/amt.c?id=d13a3205a7175d673d5080ddf155dc69aad6085c

Thanks a lot!
Taehee Yoo