All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static
@ 2018-01-09 20:33 ` Brian Norris
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2018-01-09 20:33 UTC (permalink / raw)
  To: Archit Taneja, Andrzej Hajda, Laurent Pinchart
  Cc: David Airlie, Yannick Fertre, Philippe Cornu, Vincent Abriou,
	dri-devel, linux-kernel, Sean Paul, Nickey Yang, hl,
	linux-rockchip, mka, hoegsberg, zyw, xbl, Brian Norris

sparse complains:

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol
'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static?

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 90f13df6f106..d60a77e98b57 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -700,9 +700,9 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
 	pm_runtime_put(dsi->dev);
 }
 
-void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
-				 struct drm_display_mode *mode,
-				 struct drm_display_mode *adjusted_mode)
+static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
+					struct drm_display_mode *mode,
+					struct drm_display_mode *adjusted_mode)
 {
 	struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
 	const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
-- 
2.16.0.rc1.238.g530d649a79-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static
@ 2018-01-09 20:33 ` Brian Norris
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2018-01-09 20:33 UTC (permalink / raw)
  To: Archit Taneja, Andrzej Hajda, Laurent Pinchart
  Cc: hl, David Airlie, Brian Norris, hoegsberg, Philippe Cornu,
	dri-devel, linux-kernel, Yannick Fertre, linux-rockchip,
	Nickey Yang, mka, zyw, xbl, Vincent Abriou

sparse complains:

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol
'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static?

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 90f13df6f106..d60a77e98b57 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -700,9 +700,9 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
 	pm_runtime_put(dsi->dev);
 }
 
-void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
-				 struct drm_display_mode *mode,
-				 struct drm_display_mode *adjusted_mode)
+static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
+					struct drm_display_mode *mode,
+					struct drm_display_mode *adjusted_mode)
 {
 	struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
 	const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
-- 
2.16.0.rc1.238.g530d649a79-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static
  2018-01-09 20:33 ` Brian Norris
@ 2018-01-11 13:19   ` Philippe CORNU
  -1 siblings, 0 replies; 4+ messages in thread
From: Philippe CORNU @ 2018-01-11 13:19 UTC (permalink / raw)
  To: Brian Norris, Archit Taneja, Andrzej Hajda, Laurent Pinchart
  Cc: David Airlie, Yannick FERTRE, Vincent ABRIOU, dri-devel,
	linux-kernel, Sean Paul, Nickey Yang, hl, linux-rockchip, mka,
	hoegsberg, zyw, xbl

Hi Brian,

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>

Many thanks,
Philippe :-)

On 01/09/2018 09:33 PM, Brian Norris wrote:
> sparse complains:
> 
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol
> 'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static?
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 90f13df6f106..d60a77e98b57 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -700,9 +700,9 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
>   	pm_runtime_put(dsi->dev);
>   }
>   
> -void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> -				 struct drm_display_mode *mode,
> -				 struct drm_display_mode *adjusted_mode)
> +static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> +					struct drm_display_mode *mode,
> +					struct drm_display_mode *adjusted_mode)
>   {
>   	struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
>   	const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static
@ 2018-01-11 13:19   ` Philippe CORNU
  0 siblings, 0 replies; 4+ messages in thread
From: Philippe CORNU @ 2018-01-11 13:19 UTC (permalink / raw)
  To: Brian Norris, Archit Taneja, Andrzej Hajda, Laurent Pinchart
  Cc: hl, David Airlie, hoegsberg, linux-kernel, dri-devel,
	Yannick FERTRE, linux-rockchip, Nickey Yang, mka, zyw, xbl,
	Vincent ABRIOU

Hi Brian,

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>

Many thanks,
Philippe :-)

On 01/09/2018 09:33 PM, Brian Norris wrote:
> sparse complains:
> 
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol
> 'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static?
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 90f13df6f106..d60a77e98b57 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -700,9 +700,9 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
>   	pm_runtime_put(dsi->dev);
>   }
>   
> -void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> -				 struct drm_display_mode *mode,
> -				 struct drm_display_mode *adjusted_mode)
> +static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> +					struct drm_display_mode *mode,
> +					struct drm_display_mode *adjusted_mode)
>   {
>   	struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
>   	const struct dw_mipi_dsi_phy_ops *phy_ops = dsi->plat_data->phy_ops;
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-11 13:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 20:33 [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static Brian Norris
2018-01-09 20:33 ` Brian Norris
2018-01-11 13:19 ` Philippe CORNU
2018-01-11 13:19   ` Philippe CORNU

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.