* [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()
@ 2021-02-04 15:58 Andrew Cooper
2021-02-04 16:50 ` Oleksandr
2021-02-04 17:00 ` Ian Jackson
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cooper @ 2021-02-04 15:58 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Ian Jackson, Wei Liu, Julien Grall,
Oleksandr Tyshchenko, Stefano Stabellini, Wei Chen
It is not permitted to edit the VERS clause for a version in a release of Xen.
Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump the the
library minor version to .so.1.4 instead.
Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM op")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien.grall@arm.com>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Chen <Wei.Chen@arm.com>
Critical to include in 4.15, as this is an ABI breakage. Reverting the broken
change doesn't look to be a practical option.
---
tools/libs/devicemodel/Makefile | 2 +-
tools/libs/devicemodel/libxendevicemodel.map | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index 500de7adc5..3e50ff6d90 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
include $(XEN_ROOT)/tools/Rules.mk
MAJOR = 1
-MINOR = 3
+MINOR = 4
SRCS-y += core.c
SRCS-$(CONFIG_Linux) += common.c
diff --git a/tools/libs/devicemodel/libxendevicemodel.map b/tools/libs/devicemodel/libxendevicemodel.map
index a0c30125de..733549327b 100644
--- a/tools/libs/devicemodel/libxendevicemodel.map
+++ b/tools/libs/devicemodel/libxendevicemodel.map
@@ -32,10 +32,14 @@ VERS_1.2 {
global:
xendevicemodel_relocate_memory;
xendevicemodel_pin_memory_cacheattr;
- xendevicemodel_set_irq_level;
} VERS_1.1;
VERS_1.3 {
global:
xendevicemodel_modified_memory_bulk;
} VERS_1.2;
+
+VERS_1.4 {
+ global:
+ xendevicemodel_set_irq_level;
+} VERS_1.3;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()
2021-02-04 15:58 [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level() Andrew Cooper
@ 2021-02-04 16:50 ` Oleksandr
2021-02-04 17:23 ` Andrew Cooper
2021-02-04 17:00 ` Ian Jackson
1 sibling, 1 reply; 4+ messages in thread
From: Oleksandr @ 2021-02-04 16:50 UTC (permalink / raw)
To: Andrew Cooper
Cc: Xen-devel, Ian Jackson, Wei Liu, Julien Grall,
Oleksandr Tyshchenko, Stefano Stabellini, Wei Chen
On 04.02.21 17:58, Andrew Cooper wrote:
Hi Andrew
> It is not permitted to edit the VERS clause for a version in a release of Xen.
>
> Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump the the
> library minor version to .so.1.4 instead.
>
> Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM op")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Ian Jackson <iwj@xenproject.org>
> CC: Wei Liu <wl@xen.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Wei Chen <Wei.Chen@arm.com>
>
> Critical to include in 4.15, as this is an ABI breakage.
I am sorry for the breakage, I admit I didn't know that
"It is not permitted to edit the VERS clause for a version in a release
of Xen."
> Reverting the broken
> change doesn't look to be a practical option.
> ---
> tools/libs/devicemodel/Makefile | 2 +-
> tools/libs/devicemodel/libxendevicemodel.map | 6 +++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
> index 500de7adc5..3e50ff6d90 100644
> --- a/tools/libs/devicemodel/Makefile
> +++ b/tools/libs/devicemodel/Makefile
> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
> include $(XEN_ROOT)/tools/Rules.mk
>
> MAJOR = 1
> -MINOR = 3
> +MINOR = 4
>
> SRCS-y += core.c
> SRCS-$(CONFIG_Linux) += common.c
> diff --git a/tools/libs/devicemodel/libxendevicemodel.map b/tools/libs/devicemodel/libxendevicemodel.map
> index a0c30125de..733549327b 100644
> --- a/tools/libs/devicemodel/libxendevicemodel.map
> +++ b/tools/libs/devicemodel/libxendevicemodel.map
> @@ -32,10 +32,14 @@ VERS_1.2 {
> global:
> xendevicemodel_relocate_memory;
> xendevicemodel_pin_memory_cacheattr;
> - xendevicemodel_set_irq_level;
> } VERS_1.1;
>
> VERS_1.3 {
> global:
> xendevicemodel_modified_memory_bulk;
> } VERS_1.2;
> +
> +VERS_1.4 {
> + global:
> + xendevicemodel_set_irq_level;
> +} VERS_1.3;
--
Regards,
Oleksandr Tyshchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()
2021-02-04 16:50 ` Oleksandr
@ 2021-02-04 17:23 ` Andrew Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2021-02-04 17:23 UTC (permalink / raw)
To: Oleksandr
Cc: Xen-devel, Ian Jackson, Wei Liu, Julien Grall,
Oleksandr Tyshchenko, Stefano Stabellini, Wei Chen
On 04/02/2021 16:50, Oleksandr wrote:
>
> On 04.02.21 17:58, Andrew Cooper wrote:
>
> Hi Andrew
>
>> It is not permitted to edit the VERS clause for a version in a
>> release of Xen.
>>
>> Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump
>> the the
>> library minor version to .so.1.4 instead.
>>
>> Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM
>> op")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Ian Jackson <iwj@xenproject.org>
>> CC: Wei Liu <wl@xen.org>
>> CC: Julien Grall <julien.grall@arm.com>
>> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: Wei Chen <Wei.Chen@arm.com>
>>
>> Critical to include in 4.15, as this is an ABI breakage.
> I am sorry for the breakage, I admit I didn't know that
> "It is not permitted to edit the VERS clause for a version in a
> release of Xen."
To be honest, its not Xen specific. Its any shared object with a stable
API/ABI.
It is explicitly fine to bump the minor version to add new things, but
you must never change the ABI of one which has been released.
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()
2021-02-04 15:58 [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level() Andrew Cooper
2021-02-04 16:50 ` Oleksandr
@ 2021-02-04 17:00 ` Ian Jackson
1 sibling, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2021-02-04 17:00 UTC (permalink / raw)
To: Andrew Cooper
Cc: Xen-devel, Wei Liu, Julien Grall, Oleksandr Tyshchenko,
Stefano Stabellini, Wei Chen
Andrew Cooper writes ("[PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()"):
> It is not permitted to edit the VERS clause for a version in a release of Xen.
>
> Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump the the
> library minor version to .so.1.4 instead.
>
> Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM op")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Sorry for not spotting this earlier.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-04 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 15:58 [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level() Andrew Cooper
2021-02-04 16:50 ` Oleksandr
2021-02-04 17:23 ` Andrew Cooper
2021-02-04 17:00 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.