From: Jianxin Pan <jianxin.pan@amlogic.com>
To: Stephen Boyd <sboyd@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>, Yixun Lan <dlan@gentoo.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Rob Herring <robh@kernel.org>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Yixun Lan <yixun.lan@amlogic.com>, <linux-kernel@vger.kernel.org>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Carlo Caione <carlo@caione.org>,
<linux-amlogic@lists.infradead.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Qiufang Dai <qiufang.dai@amlogic.com>
Subject: Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller
Date: Sun, 4 Nov 2018 23:39:44 +0800 [thread overview]
Message-ID: <fe4b3d70-12ae-84ae-0451-f5d67aa99fcd@amlogic.com> (raw)
In-Reply-To: <154130064120.88331.5081431734592584205@swboyd.mtv.corp.google.com>
Hi Stephen,
Thank you for the review.
On 2018/11/4 11:04, Stephen Boyd wrote:
> Quoting Yixun Lan (2018-10-25 00:29:15)
>> yes, I think the documentation need to be fixed
>>
>> for the final solution, we decide to make 'mmc-clkc' an independent node
>> instead of being a sub-node of 'mmc', so both of them may exist in parallel..
>>
>> the DT part may like this:
>>
>> sd_emmc_c_clkc: clock-controller@7000 {
>> compatible = "amlogic,axg-mmc-clkc", "syscon";
>> reg = <0x0 0x7000 0x0 0x4>;
>> ...
>> };
>>
>> sd_emmc_c: mmc@7000 {
>> compatible = "amlogic,axg-mmc";
>> reg = <0x0 0x7000 0x0 0x800>;
>> ...
>> };
>
> That's improper usage of DT. We don't want two devices at the same
> register offset.
sd_emmc_c_clkc is shared by nand and sd_emmc_c controller, and this clock is part of the MMC controller's register space.
The idea of adding the clock-controller@7000is introduced during the discussion in the NAND driver mainline effort:
https://lkml.kernel.org/r/20180628090034.0637a062@xps13
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: jianxin.pan@amlogic.com (Jianxin Pan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller
Date: Sun, 4 Nov 2018 23:39:44 +0800 [thread overview]
Message-ID: <fe4b3d70-12ae-84ae-0451-f5d67aa99fcd@amlogic.com> (raw)
In-Reply-To: <154130064120.88331.5081431734592584205@swboyd.mtv.corp.google.com>
Hi Stephen,
Thank you for the review.
On 2018/11/4 11:04, Stephen Boyd wrote:
> Quoting Yixun Lan (2018-10-25 00:29:15)
>> yes, I think the documentation need to be fixed
>>
>> for the final solution, we decide to make 'mmc-clkc' an independent node
>> instead of being a sub-node of 'mmc', so both of them may exist in parallel..
>>
>> the DT part may like this:
>>
>> sd_emmc_c_clkc: clock-controller at 7000 {
>> compatible = "amlogic,axg-mmc-clkc", "syscon";
>> reg = <0x0 0x7000 0x0 0x4>;
>> ...
>> };
>>
>> sd_emmc_c: mmc at 7000 {
>> compatible = "amlogic,axg-mmc";
>> reg = <0x0 0x7000 0x0 0x800>;
>> ...
>> };
>
> That's improper usage of DT. We don't want two devices at the same
> register offset.
sd_emmc_c_clkc is shared by nand and sd_emmc_c controller, and this clock is part of the MMC controller's register space.
The idea of adding the clock-controller at 7000is introduced during the discussion in the NAND driver mainline effort:
https://lkml.kernel.org/r/20180628090034.0637a062 at xps13
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: jianxin.pan@amlogic.com (Jianxin Pan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller
Date: Sun, 4 Nov 2018 23:39:44 +0800 [thread overview]
Message-ID: <fe4b3d70-12ae-84ae-0451-f5d67aa99fcd@amlogic.com> (raw)
In-Reply-To: <154130064120.88331.5081431734592584205@swboyd.mtv.corp.google.com>
Hi Stephen,
Thank you for the review.
On 2018/11/4 11:04, Stephen Boyd wrote:
> Quoting Yixun Lan (2018-10-25 00:29:15)
>> yes, I think the documentation need to be fixed
>>
>> for the final solution, we decide to make 'mmc-clkc' an independent node
>> instead of being a sub-node of 'mmc', so both of them may exist in parallel..
>>
>> the DT part may like this:
>>
>> sd_emmc_c_clkc: clock-controller at 7000 {
>> compatible = "amlogic,axg-mmc-clkc", "syscon";
>> reg = <0x0 0x7000 0x0 0x4>;
>> ...
>> };
>>
>> sd_emmc_c: mmc at 7000 {
>> compatible = "amlogic,axg-mmc";
>> reg = <0x0 0x7000 0x0 0x800>;
>> ...
>> };
>
> That's improper usage of DT. We don't want two devices at the same
> register offset.
sd_emmc_c_clkc is shared by nand and sd_emmc_c controller, and this clock is part of the MMC controller's register space.
The idea of adding the clock-controller at 7000is introduced during the discussion in the NAND driver mainline effort:
https://lkml.kernel.org/r/20180628090034.0637a062 at xps13
>
> .
>
next prev parent reply other threads:[~2018-11-04 15:40 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 5:07 [PATCH v5 0/3] clk: meson: add a sub EMMC clock controller support Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` [PATCH v5 1/3] clk: meson: add emmc sub clock phase delay driver Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 17:14 ` Stephen Boyd
2018-10-18 17:14 ` Stephen Boyd
2018-10-18 17:14 ` Stephen Boyd
2018-10-18 17:14 ` Stephen Boyd
2018-10-24 8:58 ` Jerome Brunet
2018-10-24 8:58 ` Jerome Brunet
2018-10-24 8:58 ` Jerome Brunet
2018-10-24 10:57 ` Jianxin Pan
2018-10-24 10:57 ` Jianxin Pan
2018-10-24 10:57 ` Jianxin Pan
2018-10-24 10:57 ` Jianxin Pan
2018-10-18 5:07 ` [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 17:08 ` Stephen Boyd
2018-10-18 17:08 ` Stephen Boyd
2018-10-18 17:08 ` Stephen Boyd
2018-10-19 15:50 ` Jianxin Pan
2018-10-19 15:50 ` Jianxin Pan
2018-10-19 15:50 ` Jianxin Pan
2018-10-19 18:04 ` Stephen Boyd
2018-10-19 18:04 ` Stephen Boyd
2018-10-19 18:04 ` Stephen Boyd
2018-10-22 6:05 ` Jianxin Pan
2018-10-22 6:05 ` Jianxin Pan
2018-10-22 6:05 ` Jianxin Pan
2018-10-24 8:58 ` Jerome Brunet
2018-10-24 8:58 ` Jerome Brunet
2018-10-24 8:58 ` Jerome Brunet
2018-10-25 7:29 ` Yixun Lan
2018-10-25 7:29 ` Yixun Lan
2018-10-25 7:29 ` Yixun Lan
2018-10-25 11:50 ` Jianxin Pan
2018-10-25 11:50 ` Jianxin Pan
2018-10-25 11:50 ` Jianxin Pan
2018-11-04 3:04 ` Stephen Boyd
2018-11-04 3:04 ` Stephen Boyd
2018-11-04 3:04 ` Stephen Boyd
2018-11-04 15:39 ` Jianxin Pan [this message]
2018-11-04 15:39 ` Jianxin Pan
2018-11-04 15:39 ` Jianxin Pan
2018-10-18 5:07 ` [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 5:07 ` Jianxin Pan
2018-10-18 17:13 ` Stephen Boyd
2018-10-18 17:13 ` Stephen Boyd
2018-10-18 17:13 ` Stephen Boyd
2018-10-19 16:12 ` Jianxin Pan
2018-10-19 16:12 ` Jianxin Pan
2018-10-19 16:12 ` Jianxin Pan
2018-10-19 18:03 ` Stephen Boyd
2018-10-19 18:03 ` Stephen Boyd
2018-10-19 18:03 ` Stephen Boyd
2018-10-22 5:59 ` Jianxin Pan
2018-10-22 5:59 ` Jianxin Pan
2018-10-22 5:59 ` Jianxin Pan
2018-10-24 9:00 ` Jerome Brunet
2018-10-24 9:00 ` Jerome Brunet
2018-10-24 9:00 ` Jerome Brunet
2018-10-24 6:29 ` Jianxin Pan
2018-10-24 6:29 ` Jianxin Pan
2018-10-24 6:29 ` Jianxin Pan
2018-10-24 8:47 ` Stephen Boyd
2018-10-24 8:47 ` Stephen Boyd
2018-10-24 8:47 ` Stephen Boyd
2018-10-24 8:51 ` Jianxin Pan
2018-10-24 8:51 ` Jianxin Pan
2018-10-24 8:51 ` Jianxin Pan
2018-10-24 9:01 ` Jerome Brunet
2018-10-24 9:01 ` Jerome Brunet
2018-10-24 9:01 ` Jerome Brunet
2018-10-25 11:48 ` Jianxin Pan
2018-10-25 11:48 ` Jianxin Pan
2018-10-25 11:48 ` Jianxin Pan
2018-10-25 12:54 ` Jerome Brunet
2018-10-25 12:54 ` Jerome Brunet
2018-10-25 12:54 ` Jerome Brunet
2018-10-25 20:58 ` Martin Blumenstingl
2018-10-25 20:58 ` Martin Blumenstingl
2018-10-25 20:58 ` Martin Blumenstingl
2018-10-28 19:16 ` Jerome Brunet
2018-10-28 19:16 ` Jerome Brunet
2018-10-28 19:16 ` Jerome Brunet
2018-10-29 19:45 ` Martin Blumenstingl
2018-10-29 19:45 ` Martin Blumenstingl
2018-10-29 19:45 ` Martin Blumenstingl
2018-10-30 13:41 ` Jianxin Pan
2018-10-30 13:41 ` Jianxin Pan
2018-10-30 13:41 ` Jianxin Pan
2018-11-03 18:01 ` Jianxin Pan
2018-11-03 18:01 ` Jianxin Pan
2018-11-03 18:01 ` Jianxin Pan
2018-11-05 9:46 ` jbrunet
2018-11-05 9:46 ` jbrunet at baylibre.com
2018-11-05 9:46 ` jbrunet at baylibre.com
2018-11-05 11:29 ` Jianxin Pan
2018-11-05 11:29 ` Jianxin Pan
2018-11-05 11:29 ` Jianxin Pan
2018-10-28 15:12 ` Jianxin Pan
2018-10-28 15:12 ` Jianxin Pan
2018-10-28 15:12 ` Jianxin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4b3d70-12ae-84ae-0451-f5d67aa99fcd@amlogic.com \
--to=jianxin.pan@amlogic.com \
--cc=boris.brezillon@bootlin.com \
--cc=carlo@caione.org \
--cc=dlan@gentoo.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.