* [MPTCP] [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
@ 2020-08-03 13:00 ` Geliang Tang
0 siblings, 0 replies; 6+ messages in thread
From: Geliang Tang @ 2020-08-03 13:00 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Use mptcp_for_each_subflow in mptcp_stream_accept instead of
open-coding.
Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index d3fe7296e1c9..400824eabf73 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -2249,7 +2249,7 @@ static int mptcp_stream_accept(struct socket *sock, struct socket *newsock,
* This is needed so NOSPACE flag can be set from tcp stack.
*/
__mptcp_flush_join_list(msk);
- list_for_each_entry(subflow, &msk->conn_list, node) {
+ mptcp_for_each_subflow(msk, subflow) {
struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
if (!ssk->sk_socket)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
@ 2020-08-03 13:00 ` Geliang Tang
0 siblings, 0 replies; 6+ messages in thread
From: Geliang Tang @ 2020-08-03 13:00 UTC (permalink / raw)
To: Mat Martineau, Matthieu Baerts, David S. Miller, Jakub Kicinski
Cc: Geliang Tang, netdev, mptcp, linux-kernel
Use mptcp_for_each_subflow in mptcp_stream_accept instead of
open-coding.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index d3fe7296e1c9..400824eabf73 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -2249,7 +2249,7 @@ static int mptcp_stream_accept(struct socket *sock, struct socket *newsock,
* This is needed so NOSPACE flag can be set from tcp stack.
*/
__mptcp_flush_join_list(msk);
- list_for_each_entry(subflow, &msk->conn_list, node) {
+ mptcp_for_each_subflow(msk, subflow) {
struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
if (!ssk->sk_socket)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
2020-08-03 13:00 ` Geliang Tang
@ 2020-08-03 16:42 ` Paolo Abeni
-1 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2020-08-03 16:42 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Mon, 2020-08-03 at 21:00 +0800, Geliang Tang wrote:
> Use mptcp_for_each_subflow in mptcp_stream_accept instead of
> open-coding.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
> ---
> net/mptcp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index d3fe7296e1c9..400824eabf73 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -2249,7 +2249,7 @@ static int mptcp_stream_accept(struct socket *sock, struct socket *newsock,
> * This is needed so NOSPACE flag can be set from tcp stack.
> */
> __mptcp_flush_join_list(msk);
> - list_for_each_entry(subflow, &msk->conn_list, node) {
> + mptcp_for_each_subflow(msk, subflow) {
> struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
>
> if (!ssk->sk_socket)
Acked-by: Paolo Abeni <pabeni(a)redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
@ 2020-08-03 16:42 ` Paolo Abeni
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2020-08-03 16:42 UTC (permalink / raw)
To: Geliang Tang, Mat Martineau, Matthieu Baerts, David S. Miller,
Jakub Kicinski
Cc: netdev, mptcp, linux-kernel
On Mon, 2020-08-03 at 21:00 +0800, Geliang Tang wrote:
> Use mptcp_for_each_subflow in mptcp_stream_accept instead of
> open-coding.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> net/mptcp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index d3fe7296e1c9..400824eabf73 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -2249,7 +2249,7 @@ static int mptcp_stream_accept(struct socket *sock, struct socket *newsock,
> * This is needed so NOSPACE flag can be set from tcp stack.
> */
> __mptcp_flush_join_list(msk);
> - list_for_each_entry(subflow, &msk->conn_list, node) {
> + mptcp_for_each_subflow(msk, subflow) {
> struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
>
> if (!ssk->sk_socket)
Acked-by: Paolo Abeni <pabeni@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
2020-08-03 13:00 ` Geliang Tang
@ 2020-08-04 1:01 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-08-04 1:01 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
From: Geliang Tang <geliangtang(a)gmail.com>
Date: Mon, 3 Aug 2020 21:00:44 +0800
> Use mptcp_for_each_subflow in mptcp_stream_accept instead of
> open-coding.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept
@ 2020-08-04 1:01 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-08-04 1:01 UTC (permalink / raw)
To: geliangtang
Cc: mathew.j.martineau, matthieu.baerts, kuba, netdev, mptcp, linux-kernel
From: Geliang Tang <geliangtang@gmail.com>
Date: Mon, 3 Aug 2020 21:00:44 +0800
> Use mptcp_for_each_subflow in mptcp_stream_accept instead of
> open-coding.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-04 1:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 13:00 [MPTCP] [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept Geliang Tang
2020-08-03 13:00 ` Geliang Tang
2020-08-03 16:42 [MPTCP] " Paolo Abeni
2020-08-03 16:42 ` Paolo Abeni
2020-08-04 1:01 [MPTCP] " David Miller
2020-08-04 1:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.