[PATCH 1/2] net/sfc: invert positive errno used internally on return

[PATCH 1/2] net/sfc: invert positive errno used internally on return

[Andrew Rybchenko]

Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 5b089dc..bd09191 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -589,7 +589,8 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 unlock:
 	rte_spinlock_unlock(&port->mac_stats_lock);
-	return ret;
+	SFC_ASSERT(ret >= 0);
+	return -ret;
 }
 
 static void
-- 
2.7.4

[PATCH 2/2] test: fix broken build because of prototype mismatch

[Andrew Rybchenko]

Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 test/test/virtual_pmd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
index 6568cb5..09daf6c 100644
--- a/test/test/virtual_pmd.c
+++ b/test/test/virtual_pmd.c
@@ -211,13 +211,15 @@ virtual_ethdev_link_update_fail(struct rte_eth_dev *bonded_eth_dev __rte_unused,
 	return -1;
 }
 
-static void
+static int
 virtual_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
 	struct virtual_ethdev_private *dev_private = dev->data->dev_private;
 
 	if (stats)
 		rte_memcpy(stats, &dev_private->eth_stats, sizeof(*stats));
+
+	return 0;
 }
 
 static void
-- 
2.7.4

Re: [PATCH 1/2] net/sfc: invert positive errno used internally on return

[Ferruh Yigit]

On 10/11/2017 8:06 AM, Andrew Rybchenko wrote:
> Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Series squashed into relevant commit in next-net, thanks.