All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h
@ 2020-09-14 23:58 Heinrich Schuchardt
  2020-09-14 23:58 ` Heinrich Schuchardt
  0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-09-14 23:58 UTC (permalink / raw)
  To: u-boot

Functions that are used in multiple C modules should be defined in an
include.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/bootm.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/bootm.h b/include/bootm.h
index 0350c349f3..a812a6bf24 100644
--- a/include/bootm.h
+++ b/include/bootm.h
@@ -75,4 +75,14 @@ void board_quiesce_devices(void);
  */
 void switch_to_non_secure_mode(void);

+/**
+ * arch_preboot_os() - arch specific configuration before booting
+ */
+void arch_preboot_os(void);
+
+/**
+ * board_preboot_os() - board specific configuration before booting
+ */
+void board_preboot_os(void);
+
 #endif
--
2.28.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h
  2020-09-14 23:58 [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h Heinrich Schuchardt
@ 2020-09-14 23:58 ` Heinrich Schuchardt
  2020-09-15  7:38   ` Michael Walle
  2020-10-14 17:42   ` Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-09-14 23:58 UTC (permalink / raw)
  To: u-boot

Functions that are used in multiple C modules should be defined in an
include.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/bootm.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/bootm.h b/include/bootm.h
index 0350c349f3..a812a6bf24 100644
--- a/include/bootm.h
+++ b/include/bootm.h
@@ -75,4 +75,14 @@ void board_quiesce_devices(void);
  */
 void switch_to_non_secure_mode(void);

+/**
+ * arch_preboot_os() - arch specific configuration before booting
+ */
+void arch_preboot_os(void);
+
+/**
+ * board_preboot_os() - board specific configuration before booting
+ */
+void board_preboot_os(void);
+
 #endif
--
2.28.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h
  2020-09-14 23:58 ` Heinrich Schuchardt
@ 2020-09-15  7:38   ` Michael Walle
  2020-09-15  8:39     ` Heinrich Schuchardt
  2020-10-14 17:42   ` Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Michael Walle @ 2020-09-15  7:38 UTC (permalink / raw)
  To: u-boot

Am 2020-09-15 01:58, schrieb Heinrich Schuchardt:
> Functions that are used in multiple C modules should be defined in an
> include.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Michael Walle <michael@walle.cc>

I've noticed that the boards which use arch_preboot_os() (?!) or 
board_preboot_os() doesn't include this header, though.

-michael

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h
  2020-09-15  7:38   ` Michael Walle
@ 2020-09-15  8:39     ` Heinrich Schuchardt
  0 siblings, 0 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-09-15  8:39 UTC (permalink / raw)
  To: u-boot

On 15.09.20 09:38, Michael Walle wrote:
> Am 2020-09-15 01:58, schrieb Heinrich Schuchardt:
>> Functions that are used in multiple C modules should be defined in an
>> include.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Reviewed-by: Michael Walle <michael@walle.cc>
>
> I've noticed that the boards which use arch_preboot_os() (?!) or
> board_preboot_os() doesn't include this header, though.

Yes, this will require further patches.

Best regards

Heinrich

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h
  2020-09-14 23:58 ` Heinrich Schuchardt
  2020-09-15  7:38   ` Michael Walle
@ 2020-10-14 17:42   ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2020-10-14 17:42 UTC (permalink / raw)
  To: u-boot

On Tue, Sep 15, 2020 at 01:58:11AM +0200, Heinrich Schuchardt wrote:

> Functions that are used in multiple C modules should be defined in an
> include.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Michael Walle <michael@walle.cc>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201014/62f4dacc/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-14 17:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 23:58 [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h Heinrich Schuchardt
2020-09-14 23:58 ` Heinrich Schuchardt
2020-09-15  7:38   ` Michael Walle
2020-09-15  8:39     ` Heinrich Schuchardt
2020-10-14 17:42   ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.