From: "Andrew F. Davis" <afd@ti.com> To: Peter Rosin <peda@axentia.se>, <linux-kernel@vger.kernel.org> Cc: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@infradead.org>, Fabio Estevam <festevam@gmail.com>, <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH v3 0/2] iio: add unit converter Date: Wed, 11 Apr 2018 10:34:40 -0500 [thread overview] Message-ID: <fe90dc62-ef2b-d999-6841-2d9d5943654c@ti.com> (raw) In-Reply-To: <20180411141555.15044-1-peda@axentia.se> On 04/11/2018 09:15 AM, Peter Rosin wrote: > Hi! > > I'm now following up with one more binding for the unit-converter. > This time with a real IC, namely LT6106 from Analog Devices. This makes more sense to me, I wasn't thinking about more complex ICs like this when I made my "resistor being part of the sensing device" argument. I can see how having a new node will probably be needed. It just seems strange to ask a resistor for its current, although it is the "device" that "knows" how much current if flowing though it.. A case I'm more familiar with, fuel gauges, we have a gauge device that has a handle to the battery it is gauging [0], we still ask the "fuel-gauge" node to get out the state of charge, not the "battery" node, the battery is not a "device" from our perspective. Thinking more about that, I like your way better, so I recant my earlier objections. Andrew [0] Documentation/devicetree/bindings/power/supply/bq27xxx.txt > It's > a current sense amplifier. I was a but unsure if I should have > the Rin and Rout resistors in the binding or if I instead should > have used the "gain". In the end I went with the resistors since > while the normal case is an integer gain, that may not always be > the case. And when it's not, that could get tricky. But I'm open > for arguments on that. > > Cheers, > Peter > > Peter Rosin (2): > dt-bindings: iio: afe: add binding for adi,lt6106 > iio: afe: unit-converter: add support for adi,lt6106 > > .../devicetree/bindings/iio/afe/adi,lt6106.txt | 50 ++++++++++++++++++++ > MAINTAINERS | 1 + > drivers/iio/afe/Kconfig | 3 +- > drivers/iio/afe/iio-unit-converter.c | 54 ++++++++++++++++++++++ > 4 files changed, 107 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/iio/afe/adi,lt6106.txt >
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com> To: Peter Rosin <peda@axentia.se>, linux-kernel@vger.kernel.org Cc: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@infradead.org>, Fabio Estevam <festevam@gmail.com>, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 0/2] iio: add unit converter Date: Wed, 11 Apr 2018 10:34:40 -0500 [thread overview] Message-ID: <fe90dc62-ef2b-d999-6841-2d9d5943654c@ti.com> (raw) In-Reply-To: <20180411141555.15044-1-peda@axentia.se> On 04/11/2018 09:15 AM, Peter Rosin wrote: > Hi! > > I'm now following up with one more binding for the unit-converter. > This time with a real IC, namely LT6106 from Analog Devices. This makes more sense to me, I wasn't thinking about more complex ICs like this when I made my "resistor being part of the sensing device" argument. I can see how having a new node will probably be needed. It just seems strange to ask a resistor for its current, although it is the "device" that "knows" how much current if flowing though it.. A case I'm more familiar with, fuel gauges, we have a gauge device that has a handle to the battery it is gauging [0], we still ask the "fuel-gauge" node to get out the state of charge, not the "battery" node, the battery is not a "device" from our perspective. Thinking more about that, I like your way better, so I recant my earlier objections. Andrew [0] Documentation/devicetree/bindings/power/supply/bq27xxx.txt > It's > a current sense amplifier. I was a but unsure if I should have > the Rin and Rout resistors in the binding or if I instead should > have used the "gain". In the end I went with the resistors since > while the normal case is an integer gain, that may not always be > the case. And when it's not, that could get tricky. But I'm open > for arguments on that. > > Cheers, > Peter > > Peter Rosin (2): > dt-bindings: iio: afe: add binding for adi,lt6106 > iio: afe: unit-converter: add support for adi,lt6106 > > .../devicetree/bindings/iio/afe/adi,lt6106.txt | 50 ++++++++++++++++++++ > MAINTAINERS | 1 + > drivers/iio/afe/Kconfig | 3 +- > drivers/iio/afe/iio-unit-converter.c | 54 ++++++++++++++++++++++ > 4 files changed, 107 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/iio/afe/adi,lt6106.txt >
next prev parent reply other threads:[~2018-04-11 15:34 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-10 15:28 [PATCH v3 0/2] iio: add unit converter Peter Rosin 2018-04-10 15:28 ` [PATCH v3 1/2] dt-bindings: iio: afe: add current-sense-shunt and voltage-divider Peter Rosin 2018-04-13 21:42 ` Rob Herring 2018-04-16 14:00 ` Peter Rosin 2018-04-21 14:34 ` Jonathan Cameron 2018-04-10 15:28 ` [PATCH v3 2/2] iio: afe: unit-converter: new driver Peter Rosin 2018-04-15 17:31 ` Jonathan Cameron 2018-04-16 7:12 ` Peter Rosin 2018-04-18 9:37 ` Jonathan Cameron 2018-04-18 9:37 ` Jonathan Cameron 2018-04-11 14:15 ` [PATCH v3 0/2] iio: add unit converter Peter Rosin 2018-04-11 14:15 ` [PATCH 1/2] dt-bindings: iio: afe: add binding for adi,lt6106 Peter Rosin 2018-04-16 18:44 ` Rob Herring 2018-04-11 14:15 ` [PATCH 2/2] iio: afe: unit-converter: add support " Peter Rosin 2018-04-11 15:43 ` Andrew F. Davis 2018-04-11 15:43 ` Andrew F. Davis 2018-04-11 15:51 ` Lars-Peter Clausen 2018-04-11 16:13 ` Andrew F. Davis 2018-04-11 16:13 ` Andrew F. Davis 2018-04-12 14:29 ` Peter Rosin 2018-04-12 15:35 ` Andrew F. Davis 2018-04-12 15:35 ` Andrew F. Davis 2018-04-12 22:31 ` Peter Rosin 2018-04-13 8:11 ` Lars-Peter Clausen 2018-04-16 7:29 ` Peter Rosin 2018-04-13 14:47 ` Andrew F. Davis 2018-04-13 14:47 ` Andrew F. Davis 2018-04-16 7:17 ` Peter Rosin 2018-04-12 14:04 ` Peter Rosin 2018-04-11 15:34 ` Andrew F. Davis [this message] 2018-04-11 15:34 ` [PATCH v3 0/2] iio: add unit converter Andrew F. Davis 2018-04-15 17:41 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fe90dc62-ef2b-d999-6841-2d9d5943654c@ti.com \ --to=afd@ti.com \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linus.walleij@linaro.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=peda@axentia.se \ --cc=pmeerw@pmeerw.net \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.