[igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups.

[igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups.

[Maarten Lankhorst]

The tests were running on each output on each pipe, and did some cleanup
that should be done in igt_display_reset(). Fix the test to use igt_kms
calls all the time, and remove all hand-rolled cleanup.

As a bonus, we can now run the same test on an overlay plane with a
s/CURSOR/OVERLAY/ as a sanity check that the test themselves are correct.

Maarten Lankhorst (4):
  tests/kms_cursor_crc: Run tests once per pipe
  tests/kms_cursor_crc: Handle display cleanup in init
  lib/igt_kms: Update cursor when fb width/height changes too.
  tests/kms_cursor_crc: Use igt_kms calls for everything.

 lib/igt_kms.c          |   4 +-
 tests/kms_cursor_crc.c | 238 +++++++++++++++++++----------------------
 2 files changed, 114 insertions(+), 128 deletions(-)

-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/4] tests/kms_cursor_crc: Run tests once per pipe

[Maarten Lankhorst]

Instead of running tests on all pipes and all outputs,
change the tests to only run once on each pipe, with
igt_get_single_output_for_pipe() to select an output.

This way we'll test all pipes and all outputs at least once,
but not all combinations. This reduces the amount of time
required for each test with dual/triple outputs.

In order to reduce the test time further, only run the
DPMS/suspend tests once for each pipe. They should not
be dependent on cursor size.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_cursor_crc.c | 125 +++++++++++++++++++----------------------
 1 file changed, 57 insertions(+), 68 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index fd74fda5c5f0..7e6c522c438b 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -462,42 +462,11 @@ static void test_cursor_opaque(data_t *data)
 	test_cursor_alpha(data, 1.0);
 }
 
-
 static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w, int cursor_h)
 {
-	igt_display_t *display = &data->display;
-	igt_output_t *output;
-	enum pipe p;
-	int valid_tests = 0;
-
-	igt_require(cursor_w <= data->cursor_max_w &&
-		    cursor_h <= data->cursor_max_h);
-
-	for_each_pipe_with_valid_output(display, p, output) {
-		data->output = output;
-		data->pipe = p;
-
-		prepare_crtc(data, output, cursor_w, cursor_h);
-
-		valid_tests++;
-
-		igt_info("Beginning %s on pipe %s, connector %s\n",
-			  igt_subtest_name(),
-			  kmstest_pipe_name(data->pipe),
-			  igt_output_name(output));
-
-		testfunc(data);
-
-		igt_info("\n%s on pipe %s, connector %s: PASSED\n\n",
-			  igt_subtest_name(),
-			  kmstest_pipe_name(data->pipe),
-			  igt_output_name(output));
-
-		/* cleanup what prepare_crtc() has done */
-		cleanup_crtc(data, output);
-	}
-
-	igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
+	prepare_crtc(data, data->output, cursor_w, cursor_h);
+	testfunc(data);
+	cleanup_crtc(data, data->output);
 }
 
 static void create_cursor_fb(data_t *data, int cur_w, int cur_h)
@@ -639,38 +608,66 @@ static void test_rapid_movement(data_t *data)
 
 }
 
-static void run_test_generic(data_t *data)
+static void run_tests_on_pipe(data_t *data, enum pipe pipe)
 {
 	int cursor_size;
+
+	igt_fixture {
+		data->pipe = pipe;
+		data->output = igt_get_single_output_for_pipe(&data->display, pipe);
+		igt_require(data->output);
+	}
+
+	igt_subtest_f("pipe-%s-cursor-size-change", kmstest_pipe_name(pipe))
+		run_test(data, test_cursor_size,
+			 data->cursor_max_w, data->cursor_max_h);
+
+	igt_subtest_f("pipe-%s-cursor-alpha-opaque", kmstest_pipe_name(pipe))
+		run_test(data, test_cursor_opaque, data->cursor_max_w, data->cursor_max_h);
+
+	igt_subtest_f("pipe-%s-cursor-alpha-transparent", kmstest_pipe_name(pipe))
+		run_test(data, test_cursor_transparent, data->cursor_max_w, data->cursor_max_h);
+
+	igt_fixture
+		create_cursor_fb(data, data->cursor_max_w, data->cursor_max_h);
+
+	igt_subtest_f("pipe-%s-cursor-dpms", kmstest_pipe_name(pipe)) {
+		data->flags = TEST_DPMS;
+		run_test(data, test_crc_random, data->cursor_max_w, data->cursor_max_h);
+	}
+	data->flags = 0;
+
+	igt_subtest_f("pipe-%s-cursor-suspend", kmstest_pipe_name(pipe)) {
+		data->flags = TEST_SUSPEND;
+		run_test(data, test_crc_random, data->cursor_max_w, data->cursor_max_h);
+	}
+	data->flags = 0;
+
+	igt_fixture
+		igt_remove_fb(data->drm_fd, &data->fb);
+
 	for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
 		int w = cursor_size;
 		int h = cursor_size;
 
-		igt_fixture
+		igt_fixture {
+			igt_require(w <= data->cursor_max_w &&
+				    h <= data->cursor_max_h);
+
 			create_cursor_fb(data, w, h);
+		}
 
 		/* Using created cursor FBs to test cursor support */
-		igt_subtest_f("cursor-%dx%d-onscreen", w, h)
+		igt_subtest_f("pipe-%s-cursor-%dx%d-onscreen", kmstest_pipe_name(pipe), w, h)
 			run_test(data, test_crc_onscreen, w, h);
-		igt_subtest_f("cursor-%dx%d-offscreen", w, h)
+		igt_subtest_f("pipe-%s-cursor-%dx%d-offscreen", kmstest_pipe_name(pipe), w, h)
 			run_test(data, test_crc_offscreen, w, h);
-		igt_subtest_f("cursor-%dx%d-sliding", w, h)
+		igt_subtest_f("pipe-%s-cursor-%dx%d-sliding", kmstest_pipe_name(pipe), w, h)
 			run_test(data, test_crc_sliding, w, h);
-		igt_subtest_f("cursor-%dx%d-random", w, h)
+		igt_subtest_f("pipe-%s-cursor-%dx%d-random", kmstest_pipe_name(pipe), w, h)
 			run_test(data, test_crc_random, w, h);
-		igt_subtest_f("cursor-%dx%d-dpms", w, h) {
-			data->flags = TEST_DPMS;
-			run_test(data, test_crc_random, w, h);
-			data->flags = 0;
-		}
-
-		igt_subtest_f("cursor-%dx%d-suspend", w, h) {
-			data->flags = TEST_SUSPEND;
-			run_test(data, test_crc_random, w, h);
-			data->flags = 0;
-		}
 
-		igt_subtest_f("cursor-%dx%d-rapid-movement", w, h) {
+		igt_subtest_f("pipe-%s-cursor-%dx%d-rapid-movement", kmstest_pipe_name(pipe), w, h) {
 			run_test(data, test_rapid_movement, w, h);
 		}
 
@@ -688,19 +685,19 @@ static void run_test_generic(data_t *data)
 			create_cursor_fb(data, w, h);
 
 		/* Using created cursor FBs to test cursor support */
-		igt_subtest_f("cursor-%dx%d-onscreen", w, h) {
+		igt_subtest_f("pipe-%s-cursor-%dx%d-onscreen", kmstest_pipe_name(pipe), w, h) {
 			igt_require(has_nonsquare_cursors(data));
 			run_test(data, test_crc_onscreen, w, h);
 		}
-		igt_subtest_f("cursor-%dx%d-offscreen", w, h) {
+		igt_subtest_f("pipe-%s-cursor-%dx%d-offscreen", kmstest_pipe_name(pipe), w, h) {
 			igt_require(has_nonsquare_cursors(data));
 			run_test(data, test_crc_offscreen, w, h);
 		}
-		igt_subtest_f("cursor-%dx%d-sliding", w, h) {
+		igt_subtest_f("pipe-%s-cursor-%dx%d-sliding", kmstest_pipe_name(pipe), w, h) {
 			igt_require(has_nonsquare_cursors(data));
 			run_test(data, test_crc_sliding, w, h);
 		}
-		igt_subtest_f("cursor-%dx%d-random", w, h) {
+		igt_subtest_f("pipe-%s-cursor-%dx%d-random", kmstest_pipe_name(pipe), w, h) {
 			igt_require(has_nonsquare_cursors(data));
 			run_test(data, test_crc_random, w, h);
 		}
@@ -716,6 +713,7 @@ igt_main
 {
 	uint64_t cursor_width = 64, cursor_height = 64;
 	int ret;
+	enum pipe pipe;
 
 	igt_skip_on_simulation();
 
@@ -741,18 +739,9 @@ igt_main
 	data.cursor_max_w = cursor_width;
 	data.cursor_max_h = cursor_height;
 
-	igt_subtest_f("cursor-size-change")
-		run_test(&data, test_cursor_size, cursor_width, cursor_height);
-
-	igt_subtest_f("cursor-alpha-opaque") {
-		run_test(&data, test_cursor_opaque, cursor_width, cursor_height);
-	 }
-
-	igt_subtest_f("cursor-alpha-transparent") {
-		run_test(&data, test_cursor_transparent, cursor_width, cursor_height);
-	 }
-
-	run_test_generic(&data);
+	for_each_pipe_static(pipe)
+		igt_subtest_group
+			run_tests_on_pipe(&data, pipe);
 
 	igt_fixture {
 		igt_display_fini(&data.display);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/4] tests/kms_cursor_crc: Handle display cleanup in init

[Maarten Lankhorst]

By handling display cleanup in init, we recover better when subtests fail.
With igt_display_reset, a lot of custom cleanup is now gone,
and we don't have to half-heartedly clean up at the end of every subtest.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_cursor_crc.c | 44 ++++++++++++++----------------------------
 1 file changed, 14 insertions(+), 30 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 7e6c522c438b..ed44a2ab803e 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -337,6 +337,18 @@ static void test_crc_random(data_t *data)
 	}
 }
 
+static void cleanup_crtc(data_t *data)
+{
+	igt_display_t *display = &data->display;
+
+	igt_pipe_crc_free(data->pipe_crc);
+	data->pipe_crc = NULL;
+
+	igt_remove_fb(data->drm_fd, &data->primary_fb);
+
+	igt_display_reset(display);
+}
+
 static void prepare_crtc(data_t *data, igt_output_t *output,
 			 int cursor_w, int cursor_h)
 {
@@ -344,9 +356,10 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_t *display = &data->display;
 	igt_plane_t *primary;
 
+	cleanup_crtc(data);
+
 	/* select the pipe we want to use */
 	igt_output_set_pipe(output, data->pipe);
-	cursor_disable(data);
 
 	/* create and set the primary plane fb */
 	mode = igt_output_get_mode(output);
@@ -362,9 +375,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_commit(display);
 
 	/* create the pipe_crc object for this pipe */
-	if (data->pipe_crc)
-		igt_pipe_crc_free(data->pipe_crc);
-
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);
 
@@ -379,31 +389,10 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	data->curh = cursor_h;
 	data->refresh = mode->vrefresh;
 
-	/* make sure cursor is disabled */
-	cursor_disable(data);
-	igt_wait_for_vblank(data->drm_fd, data->pipe);
-
 	/* get reference crc w/o cursor */
 	igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
 }
 
-static void cleanup_crtc(data_t *data, igt_output_t *output)
-{
-	igt_display_t *display = &data->display;
-	igt_plane_t *primary;
-
-	igt_pipe_crc_free(data->pipe_crc);
-	data->pipe_crc = NULL;
-
-	igt_remove_fb(data->drm_fd, &data->primary_fb);
-
-	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-	igt_plane_set_fb(primary, NULL);
-
-	igt_output_set_pipe(output, PIPE_ANY);
-	igt_display_commit(display);
-}
-
 static void test_cursor_alpha(data_t *data, double a)
 {
 	igt_display_t *display = &data->display;
@@ -466,7 +455,6 @@ static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w, int
 {
 	prepare_crtc(data, data->output, cursor_w, cursor_h);
 	testfunc(data);
-	cleanup_crtc(data, data->output);
 }
 
 static void create_cursor_fb(data_t *data, int cur_w, int cur_h)
@@ -602,10 +590,6 @@ static void test_rapid_movement(data_t *data)
 	timersub(&end, &start, &delta);
 	usec = delta.tv_usec + 1000000 * delta.tv_sec;
 	igt_assert_lt(usec, 0.9 * 400 * 1000000 / data->refresh);
-
-	igt_assert_eq(drmModeSetCursor(data->drm_fd, crtc_id,
-			       0, data->curw, data->curh), 0);
-
 }
 
 static void run_tests_on_pipe(data_t *data, enum pipe pipe)
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/4] lib/igt_kms: Update cursor when fb width/height changes too.

[Maarten Lankhorst]

Call SetCursor on w/h size change as well, this fixes a test
failure when using kms calls to change cursor size.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 lib/igt_kms.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4eb432917307..1b3483439474 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2749,7 +2749,9 @@ static int igt_cursor_commit_legacy(igt_plane_t *cursor,
 	uint32_t crtc_id = pipe->crtc_id;
 	int ret;
 
-	if (igt_plane_is_prop_changed(cursor, IGT_PLANE_FB_ID)) {
+	if (igt_plane_is_prop_changed(cursor, IGT_PLANE_FB_ID) ||
+	    igt_plane_is_prop_changed(cursor, IGT_PLANE_CRTC_W) ||
+	    igt_plane_is_prop_changed(cursor, IGT_PLANE_CRTC_H)) {
 		if (cursor->gem_handle)
 			LOG(display,
 			    "SetCursor pipe %s, fb %u %dx%d\n",
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 4/4] tests/kms_cursor_crc: Use igt_kms calls for everything.

[Maarten Lankhorst]

Instead of doing direct drm calls, we can use the core to do it for
us. This can be used to increase logging verbosity, but it will also
allow us to test on overlay planes by changing all references from
DRM_PLANE_TYPE_CURSOR to DRM_PLANE_TYPE_OVERLAY.

This fails on gen9-10 because of the alpha rounding error bug, but it
can be useful for testing if the tests themselves are broken.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_cursor_crc.c | 71 ++++++++++++++++++++++++------------------
 1 file changed, 41 insertions(+), 30 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index ed44a2ab803e..d0fb8f1d156e 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -89,20 +89,22 @@ static void draw_cursor(cairo_t *cr, int x, int y, int cw, int ch, double a)
 static void cursor_enable(data_t *data)
 {
 	igt_output_t *output = data->output;
-	igt_plane_t *cursor;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(output, DRM_PLANE_TYPE_CURSOR);
 
-	cursor = igt_output_get_plane_type(output, DRM_PLANE_TYPE_CURSOR);
 	igt_plane_set_fb(cursor, &data->fb);
 	igt_plane_set_size(cursor, data->curw, data->curh);
+	igt_fb_set_size(&data->fb, cursor, data->curw, data->curh);
 }
 
 static void cursor_disable(data_t *data)
 {
 	igt_output_t *output = data->output;
-	igt_plane_t *cursor;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(output, DRM_PLANE_TYPE_CURSOR);
 
-	cursor = igt_output_get_plane_type(output, DRM_PLANE_TYPE_CURSOR);
 	igt_plane_set_fb(cursor, NULL);
+	igt_plane_set_position(cursor, 0, 0);
 }
 
 static bool chv_cursor_broken(data_t *data, int x)
@@ -146,7 +148,8 @@ static void do_single_test(data_t *data, int x, int y)
 	igt_display_t *display = &data->display;
 	igt_pipe_crc_t *pipe_crc = data->pipe_crc;
 	igt_crc_t crc, ref_crc;
-	igt_plane_t *cursor;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 	cairo_t *cr;
 	int ret = 0;
 
@@ -158,7 +161,6 @@ static void do_single_test(data_t *data, int x, int y)
 	igt_put_cairo_ctx(data->drm_fd, &data->primary_fb, cr);
 
 	cursor_enable(data);
-	cursor = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 	igt_plane_set_position(cursor, x, y);
 
 	if (chv_cursor_broken(data, x) && cursor_visible(data, x, y)) {
@@ -217,7 +219,8 @@ static void do_single_test(data_t *data, int x, int y)
 static void do_fail_test(data_t *data, int x, int y, int expect)
 {
 	igt_display_t *display = &data->display;
-	igt_plane_t *cursor;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 	cairo_t *cr;
 	int ret;
 
@@ -229,7 +232,6 @@ static void do_fail_test(data_t *data, int x, int y, int expect)
 	igt_put_cairo_ctx(data->drm_fd, &data->primary_fb, cr);
 
 	cursor_enable(data);
-	cursor = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 	igt_plane_set_position(cursor, x, y);
 	ret = igt_display_try_commit2(display, COMMIT_LEGACY);
 
@@ -402,7 +404,6 @@ static void test_cursor_alpha(data_t *data, double a)
 	uint32_t fb_id;
 	int curw = data->curw;
 	int curh = data->curh;
-	int ret;
 
 	/*alpha cursor fb*/
 	fb_id = igt_create_fb(data->drm_fd, curw, curh,
@@ -416,8 +417,7 @@ static void test_cursor_alpha(data_t *data, double a)
 
 	/*Hardware Test*/
 	cursor_enable(data);
-	ret = drmModeSetCursor(data->drm_fd, data->output->config.crtc->crtc_id, data->fb.gem_handle, curw, curh);
-	igt_assert_eq(ret, 0);
+	igt_display_commit(display);
 	igt_wait_for_vblank(data->drm_fd, data->pipe);
 	igt_pipe_crc_collect_crc(pipe_crc, &crc);
 	cursor_disable(data);
@@ -512,7 +512,8 @@ static void test_cursor_size(data_t *data)
 	uint32_t fb_id;
 	int i, size;
 	int cursor_max_size = data->cursor_max_w;
-	int ret;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 
 	/* Create a maximum size cursor, then change the size in flight to
 	 * smaller ones to see that the size is applied correctly
@@ -529,17 +530,16 @@ static void test_cursor_size(data_t *data)
 
 	/* Hardware test loop */
 	cursor_enable(data);
-	ret = drmModeMoveCursor(data->drm_fd, data->output->config.crtc->crtc_id, 0, 0);
-	igt_assert_eq(ret, 0);
 	for (i = 0, size = cursor_max_size; size >= 64; size /= 2, i++) {
 		/* Change size in flight: */
-		ret = drmModeSetCursor(data->drm_fd, data->output->config.crtc->crtc_id,
-				       data->fb.gem_handle, size, size);
-		igt_assert_eq(ret, 0);
+		igt_plane_set_size(cursor, size, size);
+		igt_fb_set_size(&data->fb, cursor, size, size);
+		igt_display_commit(display);
 		igt_wait_for_vblank(data->drm_fd, data->pipe);
 		igt_pipe_crc_collect_crc(pipe_crc, &crc[i]);
 	}
 	cursor_disable(data);
+	igt_display_commit(display);
 	igt_remove_fb(data->drm_fd, &data->fb);
 	/* Software test loop */
 	for (i = 0, size = cursor_max_size; size >= 64; size /= 2, i++) {
@@ -565,20 +565,29 @@ static void test_rapid_movement(data_t *data)
 	struct timeval start, end, delta;
 	int x = 0, y = 0;
 	long usec;
-	int crtc_id = data->output->config.crtc->crtc_id;
+	igt_display_t *display = &data->display;
+	igt_plane_t *cursor =
+		igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_CURSOR);
 
-	igt_assert_eq(drmModeSetCursor(data->drm_fd, crtc_id,
-			       data->fb.gem_handle, data->curw, data->curh), 0);
+	cursor_enable(data);
 
 	gettimeofday(&start, NULL);
-	for ( ; x < 100; x++)
-		igt_assert_eq(drmModeMoveCursor(data->drm_fd, crtc_id, x, y), 0);
-	for ( ; y < 100; y++)
-		igt_assert_eq(drmModeMoveCursor(data->drm_fd, crtc_id, x, y), 0);
-	for ( ; x > 0; x--)
-		igt_assert_eq(drmModeMoveCursor(data->drm_fd, crtc_id, x, y), 0);
-	for ( ; y > 0; y--)
-		igt_assert_eq(drmModeMoveCursor(data->drm_fd, crtc_id, x, y), 0);
+	for ( ; x < 100; x++) {
+		igt_plane_set_position(cursor, x, y);
+		igt_display_commit(display);
+	}
+	for ( ; y < 100; y++) {
+		igt_plane_set_position(cursor, x, y);
+		igt_display_commit(display);
+	}
+	for ( ; x > 0; x--) {
+		igt_plane_set_position(cursor, x, y);
+		igt_display_commit(display);
+	}
+	for ( ; y > 0; y--) {
+		igt_plane_set_position(cursor, x, y);
+		igt_display_commit(display);
+	}
 	gettimeofday(&end, NULL);
 
 	/*
@@ -665,8 +674,10 @@ static void run_tests_on_pipe(data_t *data, enum pipe pipe)
 		 */
 		h /= 3;
 
-		igt_fixture
-			create_cursor_fb(data, w, h);
+		igt_fixture {
+			if (has_nonsquare_cursors(data))
+				create_cursor_fb(data, w, h);
+		}
 
 		/* Using created cursor FBs to test cursor support */
 		igt_subtest_f("pipe-%s-cursor-%dx%d-onscreen", kmstest_pipe_name(pipe), w, h) {
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for kms_cursor_crc test improvements and cleanups.

[Patchwork]

== Series Details ==

Series: kms_cursor_crc test improvements and cleanups.
URL   : https://patchwork.freedesktop.org/series/60069/
State : success

== Summary ==

CI Bug Log - changes from IGT_4970 -> IGTPW_2933
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/60069/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2933 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-icl-y:           [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/fi-icl-y/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/fi-icl-y/igt@i915_selftest@live_contexts.html

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - {fi-icl-u2}:        [INCOMPLETE][3] ([fdo#107713] / [fdo#109100]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/fi-icl-u2/igt@gem_ctx_create@basic-files.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/fi-icl-u2/igt@gem_ctx_create@basic-files.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][7] ([fdo#108511]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-guc:         [INCOMPLETE][9] ([fdo#107807]) -> [SKIP][10] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271


Participating hosts (45 -> 46)
------------------------------

  Additional (6): fi-bsw-n3050 fi-byt-j1900 fi-hsw-peppy fi-hsw-4770 fi-byt-n2820 fi-byt-clapper 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4970 -> IGTPW_2933

  CI_DRM_6012: e4882f199157e3fb73d1791352931096f6ecfcfd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2933: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/
  IGT_4970: ab54de9937678583437eee4546bc25a9885b87a6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+++ 246 lines
--- 47 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for kms_cursor_crc test improvements and cleanups.

[Patchwork]

== Series Details ==

Series: kms_cursor_crc test improvements and cleanups.
URL   : https://patchwork.freedesktop.org/series/60069/
State : success

== Summary ==

CI Bug Log - changes from IGT_4970_full -> IGTPW_2933_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/60069/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2933_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding} (NEW):
    - shard-iclb:         NOTRUN -> [SKIP][1] +25 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html

  * {igt@kms_cursor_crc@pipe-a-cursor-64x21-random} (NEW):
    - shard-kbl:          NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
    - shard-apl:          NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html

  * {igt@kms_cursor_crc@pipe-a-cursor-dpms} (NEW):
    - shard-glk:          NOTRUN -> [FAIL][4] +59 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-glk8/igt@kms_cursor_crc@pipe-a-cursor-dpms.html

  * {igt@kms_cursor_crc@pipe-b-cursor-suspend} (NEW):
    - shard-apl:          NOTRUN -> [DMESG-WARN][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-apl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  
New tests
---------

  New tests have been introduced between IGT_4970_full and IGTPW_2933_full:

### New IGT tests (123) ###

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [10.51, 13.87] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.87, 6.76] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.64, 11.82] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.14, 0.42] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.64, 11.40] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.18] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.70] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 12.19] s

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.40] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [10.55, 13.13] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.65, 6.73] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
    - Statuses : 1 fail(s) 4 pass(s)
    - Exec time: [0.85, 11.79] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.14, 0.43] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.80, 10.84] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 12.98] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 7.81] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.74] s

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 10.61] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.24] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.52] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
    - Statuses : 3 fail(s) 2 pass(s) 1 skip(s)
    - Exec time: [0.0, 10.19] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.31] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [10.50, 13.22] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.63, 7.55] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.65, 11.75] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.14, 0.42] s

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.72, 11.10] s

  * igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
    - Statuses : 6 pass(s)
    - Exec time: [0.35, 0.60] s

  * igt@kms_cursor_crc@pipe-a-cursor-alpha-transparent:
    - Statuses : 6 pass(s)
    - Exec time: [0.34, 0.59] s

  * igt@kms_cursor_crc@pipe-a-cursor-dpms:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.91, 3.05] s

  * igt@kms_cursor_crc@pipe-a-cursor-size-change:
    - Statuses : 6 pass(s)
    - Exec time: [0.78, 1.01] s

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [2.08, 34.29] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [10.57, 12.55] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
    - Statuses : 1 fail(s) 3 pass(s)
    - Exec time: [0.65, 6.80] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
    - Statuses : 1 fail(s) 4 pass(s)
    - Exec time: [0.64, 11.85] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.23, 1.28] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [1.11, 11.50] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.26] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.93] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.93] s

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.19] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [11.87, 13.29] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.72, 6.92] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.91, 11.78] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.21, 1.56] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.63, 11.47] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 12.88] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.40] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.92] s

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.50] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
    - Statuses : 5 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.02] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 7.13] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.80] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.46] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
    - Statuses : 6 pass(s)
    - Exec time: [10.56, 13.29] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.65, 6.92] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.64, 11.63] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement:
    - Statuses : 6 pass(s)
    - Exec time: [0.22, 1.29] s

  * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding:
    - Statuses : 1 fail(s) 4 pass(s)
    - Exec time: [0.75, 10.72] s

  * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
    - Statuses : 6 pass(s)
    - Exec time: [0.42, 1.46] s

  * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
    - Statuses : 6 pass(s)
    - Exec time: [0.43, 1.50] s

  * igt@kms_cursor_crc@pipe-b-cursor-dpms:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.90, 4.21] s

  * igt@kms_cursor_crc@pipe-b-cursor-size-change:
    - Statuses : 6 pass(s)
    - Exec time: [0.82, 1.90] s

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - Statuses : 1 dmesg-warn(s) 1 fail(s) 4 pass(s)
    - Exec time: [1.96, 36.98] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.37] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.94] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.87] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.31] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.48] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 12.65] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.93] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-random:
    - Statuses : 1 fail(s) 4 pass(s)
    - Exec time: [1.47, 13.57] s

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.49] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.21] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.41] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.31] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-rapid-movement:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.31] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.45] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.35] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.92] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.47] s

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 10.90] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-offscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.29] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.91] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 12.01] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.33] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 13.41] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 6.83] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 11.75] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-rapid-movement:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.31] s

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-sliding:
    - Statuses : 1 fail(s) 4 pass(s)
    - Exec time: [0.79, 11.39] s

  * igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.52] s

  * igt@kms_cursor_crc@pipe-c-cursor-alpha-transparent:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.51] s

  * igt@kms_cursor_crc@pipe-c-cursor-dpms:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 4.15] s

  * igt@kms_cursor_crc@pipe-c-cursor-size-change:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0, 1.90] s

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - Statuses : 1 fail(s) 4 pass(s) 1 skip(s)
    - Exec time: [0.0, 38.63] s

  

Known issues
------------

  Here are the changes found in IGTPW_2933_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_blt@dumb-buf:
    - shard-hsw:          [PASS][6] -> [INCOMPLETE][7] ([fdo#103540]) +1 similar issue
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-hsw5/igt@gem_exec_blt@dumb-buf.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-hsw2/igt@gem_exec_blt@dumb-buf.html

  * igt@gem_linear_blits@normal:
    - shard-iclb:         [PASS][8] -> [INCOMPLETE][9] ([fdo#107713])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-iclb2/igt@gem_linear_blits@normal.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-iclb7/igt@gem_linear_blits@normal.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [PASS][10] -> [DMESG-WARN][11] ([fdo#108566]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-kbl:          [PASS][12] -> [FAIL][13] ([fdo#104782])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-kbl6/igt@kms_color@pipe-b-legacy-gamma.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-kbl3/igt@kms_color@pipe-b-legacy-gamma.html

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
    - shard-hsw:          [PASS][14] -> [FAIL][15] ([fdo#103355])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html

  * igt@kms_flip@2x-flip-vs-suspend-interruptible:
    - shard-glk:          [PASS][16] -> [INCOMPLETE][17] ([fdo#103359] / [k.org#198133]) +1 similar issue
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-glk4/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-glk9/igt@kms_flip@2x-flip-vs-suspend-interruptible.html

  * igt@kms_flip@dpms-vs-vblank-race-interruptible:
    - shard-glk:          [PASS][18] -> [FAIL][19] ([fdo#103060])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-glk4/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-glk8/igt@kms_flip@dpms-vs-vblank-race-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [PASS][20] -> [FAIL][21] ([fdo#103167])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-iclb:         [PASS][22] -> [FAIL][23] ([fdo#103167]) +8 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4970/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [23]: https

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2933/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups.

[Juha-Pekka Heikkilä]

This set look all good to me, I didn't notice anything I'd comment about 
other than:

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Maarten Lankhorst kirjoitti 29.4.2019 klo 19.05:
> The tests were running on each output on each pipe, and did some cleanup
> that should be done in igt_display_reset(). Fix the test to use igt_kms
> calls all the time, and remove all hand-rolled cleanup.
> 
> As a bonus, we can now run the same test on an overlay plane with a
> s/CURSOR/OVERLAY/ as a sanity check that the test themselves are correct.
> 
> Maarten Lankhorst (4):
>    tests/kms_cursor_crc: Run tests once per pipe
>    tests/kms_cursor_crc: Handle display cleanup in init
>    lib/igt_kms: Update cursor when fb width/height changes too.
>    tests/kms_cursor_crc: Use igt_kms calls for everything.
> 
>   lib/igt_kms.c          |   4 +-
>   tests/kms_cursor_crc.c | 238 +++++++++++++++++++----------------------
>   2 files changed, 114 insertions(+), 128 deletions(-)
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/4] kms_cursor_crc test improvements and cleanups.

[Maarten Lankhorst]

Op 11-05-2019 om 17:17 schreef Juha-Pekka Heikkilä:
> This set look all good to me, I didn't notice anything I'd comment about other than:
>
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>
> Maarten Lankhorst kirjoitti 29.4.2019 klo 19.05:
>> The tests were running on each output on each pipe, and did some cleanup
>> that should be done in igt_display_reset(). Fix the test to use igt_kms
>> calls all the time, and remove all hand-rolled cleanup.
>>
>> As a bonus, we can now run the same test on an overlay plane with a
>> s/CURSOR/OVERLAY/ as a sanity check that the test themselves are correct.
>>
>> Maarten Lankhorst (4):
>>    tests/kms_cursor_crc: Run tests once per pipe
>>    tests/kms_cursor_crc: Handle display cleanup in init
>>    lib/igt_kms: Update cursor when fb width/height changes too.
>>    tests/kms_cursor_crc: Use igt_kms calls for everything.
>>
>>   lib/igt_kms.c          |   4 +-
>>   tests/kms_cursor_crc.c | 238 +++++++++++++++++++----------------------
>>   2 files changed, 114 insertions(+), 128 deletions(-)
>>
Thanks, pushed. :)

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev