All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	u-boot@lists.denx.de, Alexander Graf <agraf@csgraf.de>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 1/1] efi_loader: require CONFIG_BLK
Date: Wed, 8 Sep 2021 01:30:16 +0200	[thread overview]
Message-ID: <feade4fb-9e2c-7409-f626-b82d1725c17c@gmx.de> (raw)
In-Reply-To: <20210907112517.GB49004@laputa>

On 9/7/21 1:25 PM, AKASHI Takahiro wrote:
> On Tue, Sep 07, 2021 at 09:01:08AM +0200, Heinrich Schuchardt wrote:
>> The move to driver model should by now be completed. To be able to remove
>> pre-driver model code from our block IO code require CONFIG_BLK=y for UEFI
>> support.
>
> If so, we can safely remove !CONFIG_BLK-related code
> from efi_disk.c and efi_device_path.c.

Yes, that was my intent. As we want to improve the integration with the
driver model we should get rid of the outdated non-BLK code. Let's merge
that into the next branch.

Best regards

Heinrich

>
> -Takahiro Akashi
>
>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   lib/efi_loader/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index dacc3b5881..692cf5ced0 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -10,6 +10,7 @@ config EFI_LOADER
>>   	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
>>   	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
>>   	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
>> +	depends on BLK
>>   	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>   	select LIB_UUID
>>   	select PARTITION_UUIDS
>> --
>> 2.30.2
>>


  reply	other threads:[~2021-09-07 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  7:01 [PATCH 1/1] efi_loader: require CONFIG_BLK Heinrich Schuchardt
2021-09-07 11:25 ` AKASHI Takahiro
2021-09-07 23:30   ` Heinrich Schuchardt [this message]
2021-09-08 12:06     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feade4fb-9e2c-7409-f626-b82d1725c17c@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=agraf@csgraf.de \
    --cc=sjg@chromium.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.