From: Jens Axboe <axboe@fb.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] lightnvm: Remove an unused variable
Date: Tue, 09 May 2017 14:50:17 +0000 [thread overview]
Message-ID: <ff06f5a2-bff2-a366-34d4-53b993c13602@fb.com> (raw)
In-Reply-To: <79988EFB-7909-4234-B4D9-435AAFAE2E07@lightnvm.io>
On 05/09/2017 04:19 AM, Javier González wrote:
>> On 9 May 2017, at 11.34, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> "rq" is never used in nvme_nvm_rqtocmd(). We also recently shifted some
>> code around so it's uninitialized and causes a static checker warning.
>> Let's just remove it.
>>
>
> Looks good. I didn't see it when I refactored that part.
> Matias: If it is ok with you, can you pick it up?
>
> Reviewed-by: Javier González <javier@cnexlabs.com>
Geert sent in a similar fix two days ago, it's already queued up:
commit 629b1b2e0e6c8285fdc21624af60e8190fa4417e
Author: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun May 7 16:14:44 2017 +0200
lightnvm: remove unused rq parameter of nvme_nvm_rqtocmd() to kill warning
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] lightnvm: Remove an unused variable
Date: Tue, 9 May 2017 08:50:17 -0600 [thread overview]
Message-ID: <ff06f5a2-bff2-a366-34d4-53b993c13602@fb.com> (raw)
In-Reply-To: <79988EFB-7909-4234-B4D9-435AAFAE2E07@lightnvm.io>
On 05/09/2017 04:19 AM, Javier Gonz?lez wrote:
>> On 9 May 2017,@11.34, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> "rq" is never used in nvme_nvm_rqtocmd(). We also recently shifted some
>> code around so it's uninitialized and causes a static checker warning.
>> Let's just remove it.
>>
>
> Looks good. I didn't see it when I refactored that part.
> Matias: If it is ok with you, can you pick it up?
>
> Reviewed-by: Javier Gonz?lez <javier at cnexlabs.com>
Geert sent in a similar fix two days ago, it's already queued up:
commit 629b1b2e0e6c8285fdc21624af60e8190fa4417e
Author: Geert Uytterhoeven <geert at linux-m68k.org>
Date: Sun May 7 16:14:44 2017 +0200
lightnvm: remove unused rq parameter of nvme_nvm_rqtocmd() to kill warning
--
Jens Axboe
next prev parent reply other threads:[~2017-05-09 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 9:34 [PATCH] lightnvm: Remove an unused variable Dan Carpenter
2017-05-09 9:34 ` Dan Carpenter
2017-05-09 10:19 ` Javier González
2017-05-09 10:19 ` Javier González
2017-05-09 14:50 ` Jens Axboe [this message]
2017-05-09 14:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff06f5a2-bff2-a366-34d4-53b993c13602@fb.com \
--to=axboe@fb.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.