From: Samuel Holland <samuel@sholland.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Date: Sat, 23 Apr 2022 14:39:45 -0500 [thread overview] Message-ID: <ff0ae741-efc4-ba6f-d869-4cb8fb7149ad@sholland.org> (raw) In-Reply-To: <ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr> On 4/21/22 9:35 AM, Christophe JAILLET wrote: > This code is really spurious. > It always returns an ERR_PTR, even when err is known to be 0 and calls > put_device() after a successful device_register() call. > > It is likely that the return statement in the normal path is missing. > Add 'return rdev;' to fix it. Thanks for the patch. This definitely looks to be the case. > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Samuel Holland <samuel@sholland.org> Tested-by: Samuel Holland <samuel@sholland.org>
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Date: Sat, 23 Apr 2022 14:39:45 -0500 [thread overview] Message-ID: <ff0ae741-efc4-ba6f-d869-4cb8fb7149ad@sholland.org> (raw) In-Reply-To: <ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr> On 4/21/22 9:35 AM, Christophe JAILLET wrote: > This code is really spurious. > It always returns an ERR_PTR, even when err is known to be 0 and calls > put_device() after a successful device_register() call. > > It is likely that the return statement in the normal path is missing. > Add 'return rdev;' to fix it. Thanks for the patch. This definitely looks to be the case. > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Samuel Holland <samuel@sholland.org> Tested-by: Samuel Holland <samuel@sholland.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-23 19:39 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 14:35 [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Christophe JAILLET 2022-04-21 14:35 ` Christophe JAILLET 2022-04-23 19:39 ` Samuel Holland [this message] 2022-04-23 19:39 ` Samuel Holland 2022-04-25 17:31 ` Jernej Škrabec 2022-04-25 17:31 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ff0ae741-efc4-ba6f-d869-4cb8fb7149ad@sholland.org \ --to=samuel@sholland.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=christophe.jaillet@wanadoo.fr \ --cc=jernej.skrabec@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mripard@kernel.org \ --cc=olof@lixom.net \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.