[MPTCP] Re: [PATCH 1/6] mptcp: Reference af_ops routines through struct ipv4_specific

[MPTCP] Re: [PATCH 1/6] mptcp: Reference af_ops routines through struct ipv4_specific

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> Make this look similar to how it will have to be done for IPv6,
> as the IPv6 routines are declared static and thus not visible.
> 
> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>

I think:

- 'subflow_finish_connect()' and 'inet_connection_sock_af_ops
subflow_specific;' changes should be squashed into "mptcp: Handle
MP_CAPABLE options for outgoing connections"

- 'subflow_syn_recv_sock()' into "mptcp: Create SUBFLOW socket for
incoming connections"

- 'inet_sk_rebuild_head()' into "mptcp: Add key generation and token
tree"

right?

/P

[MPTCP] Re: [PATCH 1/6] mptcp: Reference af_ops routines through struct ipv4_specific

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Thu, 2019-10-31 at 09:33 +0100, Paolo Abeni wrote:
> On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> > Make this look similar to how it will have to be done for IPv6,
> > as the IPv6 routines are declared static and thus not visible.
> > 
> > Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
> 
> I think:
> 
> - 'subflow_finish_connect()' and 'inet_connection_sock_af_ops
> subflow_specific;' changes should be squashed into "mptcp: Handle
> MP_CAPABLE options for outgoing connections"
> 
> - 'subflow_syn_recv_sock()' into "mptcp: Create SUBFLOW socket for
> incoming connections"
> 
> - 'inet_sk_rebuild_head()' into "mptcp: Add key generation and token
> tree"
> 
> right?
> 
> /P
> 

In the v2 patchset I am going to modify this change. We will save a pointer
to the original af_icsk_ops structure and call the inet_xxx routines through
it. This will save a lot of code duplication for IPv6.

The change will squash to the same commits you identify above.

Peter.