Re: [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

From: Javier Martinez Canillas <javierm@redhat.com>
To: "Maíra Canal" <maira.canal@usp.br>,
	"Isabella Basso" <isabbasso@riseup.net>,
	magalilemes00@gmail.com, tales.aparecida@gmail.com,
	mwen@igalia.com, andrealmeid@riseup.net,
	siqueirajordao@riseup.net, "Trevor Woerner" <twoerner@gmail.com>,
	leandro.ribeiro@collabora.com, n@nfraprado.net,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"David Airlie" <airlied@linux.ie>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	michal.winiarski@intel.com,
	"José Expósito" <jose.exposito89@gmail.com>,
	"David Gow" <davidgow@google.com>,
	"Daniel Latypov" <dlatypov@google.com>,
	brendanhiggins@google.com
Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Arthur Grillo <arthur.grillo@usp.br>
Subject: Re: [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit
Date: Sat, 2 Jul 2022 13:32:52 +0200	[thread overview]
Message-ID: <ff375c95-96e9-6bcf-66ea-f70a44d0a5d1@redhat.com> (raw)
In-Reply-To: <20220630004611.114441-2-maira.canal@usp.br>

Hello Maíra,

Thanks a lot for your patch.

On 6/30/22 02:46, Maíra Canal wrote:
> Considering the current adoption of the KUnit framework, convert the
> DRM damage helper selftest to the KUnit API.
> 
> Acked-by: Daniel Latypov <dlatypov@google.com>
> Tested-by: David Gow <davidgow@google.com>
> Co-developed-by: Arthur Grillo <arthur.grillo@usp.br>
> Signed-off-by: Arthur Grillo <arthur.grillo@usp.br>
> Signed-off-by: Maíra Canal <maira.canal@usp.br>

I believe the order of the tags should be chronological. That is, Daniel and
David tags should be after your Co-developed-by and Signed-off-by tags.

[...]

> +++ b/drivers/gpu/drm/tests/drm_damage_helper_test.c
> @@ -0,0 +1,634 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Test case for drm_damage_helper functions
> + */
> +
> +#include <kunit/test.h>

Please add a blank line here to separate non-DRM headers include from DRM headers.

> +#include <drm/drm_damage_helper.h>
> +#include <drm/drm_framebuffer.h>
> +#include <drm/drm_plane.h>
> +#include <drm/drm_drv.h>
> +

I haven't looked at the KUnits tests in detail since Daniel and David already
reviewed them. But from a quick glance, the tests look good to me as well.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat