* [PATCH] fastboot: fix fastboot_set_reboot_flag()
@ 2021-05-08 22:25 Roman Stratiienko
2021-11-03 16:22 ` Sean Anderson
2022-01-28 20:15 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Roman Stratiienko @ 2021-05-08 22:25 UTC (permalink / raw)
To: u-boot
In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition
is not met and fastboot_set_reboot_flag() fails.
Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag")
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
---
drivers/fastboot/fb_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
index cbcc3683c47..ef399d0c4ab 100644
--- a/drivers/fastboot/fb_common.c
+++ b/drivers/fastboot/fb_common.c
@@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response)
*/
int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
{
-#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV)
+#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
static const char * const boot_cmds[] = {
[FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader",
[FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot",
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()
2021-05-08 22:25 [PATCH] fastboot: fix fastboot_set_reboot_flag() Roman Stratiienko
@ 2021-11-03 16:22 ` Sean Anderson
2021-11-18 14:20 ` Mattijs Korpershoek
2022-01-28 20:15 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Sean Anderson @ 2021-11-03 16:22 UTC (permalink / raw)
To: Roman Stratiienko, u-boot; +Cc: sjg, roman.kovalivskyi, erosca
On 5/8/21 6:25 PM, Roman Stratiienko wrote:
> In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition
> is not met and fastboot_set_reboot_flag() fails.
>
> Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag")
> Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
> ---
> drivers/fastboot/fb_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index cbcc3683c47..ef399d0c4ab 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response)
> */
> int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
> {
> -#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV)
> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
> static const char * const boot_cmds[] = {
> [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader",
> [FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot",
>
Reviewed-by: Sean Anderson <seanga2@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()
2021-11-03 16:22 ` Sean Anderson
@ 2021-11-18 14:20 ` Mattijs Korpershoek
0 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2021-11-18 14:20 UTC (permalink / raw)
To: Sean Anderson, Roman Stratiienko, u-boot; +Cc: sjg, roman.kovalivskyi, erosca
Hi Roman,
Thank you for your patch.
Sean Anderson <seanga2@gmail.com> writes:
> On 5/8/21 6:25 PM, Roman Stratiienko wrote:
>> In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition
>> is not met and fastboot_set_reboot_flag() fails.
>>
>> Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag")
>> Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
>> ---
>> drivers/fastboot/fb_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
>> index cbcc3683c47..ef399d0c4ab 100644
>> --- a/drivers/fastboot/fb_common.c
>> +++ b/drivers/fastboot/fb_common.c
>> @@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response)
>> */
>> int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
>> {
>> -#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV)
>> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
>> static const char * const boot_cmds[] = {
>> [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader",
>> [FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot",
>>
>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
I'm using this in the (out of tree) U-Boot for khadas VIM3L/VIM3 boards:
https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()
2021-05-08 22:25 [PATCH] fastboot: fix fastboot_set_reboot_flag() Roman Stratiienko
2021-11-03 16:22 ` Sean Anderson
@ 2022-01-28 20:15 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-01-28 20:15 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: u-boot, sjg, roman.kovalivskyi, erosca
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Sun, May 09, 2021 at 01:25:24AM +0300, Roman Stratiienko wrote:
> In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition
> is not met and fastboot_set_reboot_flag() fails.
>
> Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag")
> Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
> Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-28 20:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 22:25 [PATCH] fastboot: fix fastboot_set_reboot_flag() Roman Stratiienko
2021-11-03 16:22 ` Sean Anderson
2021-11-18 14:20 ` Mattijs Korpershoek
2022-01-28 20:15 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.