From: "Sven Peter" <sven@svenpeter.dev> To: "Alyssa Rosenzweig" <alyssa@rosenzweig.io> Cc: "Jassi Brar" <jassisinghbrar@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Hector Martin" <marcan@marcan.st>, "Mohamed Mediouni" <mohamed.mediouni@caramail.com>, "Stan Skowronek" <stan@corellium.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: mailbox: Add Apple mailbox bindings Date: Tue, 07 Sep 2021 22:26:17 +0200 [thread overview] Message-ID: <ff66c30d-1b43-43d3-a4b0-02fe7d346118@www.fastmail.com> (raw) In-Reply-To: <YTe17jGBobarePaK@sunset> Hi, On Tue, Sep 7, 2021, at 20:56, Alyssa Rosenzweig wrote: > > + - description: > > + M3 mailboxes are an older variant with a slightly different MMIO > > + interface still found on the M1. > > + items: > > + - const: apple,t8103-m3-mailbox > > Would be nice to document an example of where an M3 mailbox is found. Sure, I can add a comment that this is used for the coprocessor controlling Thunderbolt. > > > + interrupts: > > + minItems: 4 > > + items: > > + - description: send fifo is empty interrupt > > + - description: send fifo is not empty interrupt > > + - description: receive fifo is empty interrupt > > + - description: receive fifo is not empty interrupt > > + > > + interrupt-names: > > + minItems: 4 > > + items: > > + - const: send-empty > > + - const: send-not-empty > > + - const: recv-empty > > + - const: recv-not-empty > > If the names became not-constant the asprintf thing goes away, not sure > that's better or worse. I'm not sure I understand your comment here. This property just gives a name to the interrupts so that they can be referenced by that instead of a magic number between 0 and 4 in the driver. > > > + clocks: > > + description: > > + Reference to the clock gate phandle(s) if required for this mailbox. > > + Optional since not all mailboxes are attached to a clock gate. > > Do we do anything with the clocks at this point? > The device tree bindings describe the hardware (as best as we can without proper documentation) and some of these mailboxes have clock gates which need to be turned on before accessing their MMIO. This driver already tries to do that and works fine with the downstream clock driver(s) we have. Sven
WARNING: multiple messages have this Message-ID (diff)
From: "Sven Peter" <sven@svenpeter.dev> To: "Alyssa Rosenzweig" <alyssa@rosenzweig.io> Cc: "Jassi Brar" <jassisinghbrar@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Hector Martin" <marcan@marcan.st>, "Mohamed Mediouni" <mohamed.mediouni@caramail.com>, "Stan Skowronek" <stan@corellium.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: mailbox: Add Apple mailbox bindings Date: Tue, 07 Sep 2021 22:26:17 +0200 [thread overview] Message-ID: <ff66c30d-1b43-43d3-a4b0-02fe7d346118@www.fastmail.com> (raw) In-Reply-To: <YTe17jGBobarePaK@sunset> Hi, On Tue, Sep 7, 2021, at 20:56, Alyssa Rosenzweig wrote: > > + - description: > > + M3 mailboxes are an older variant with a slightly different MMIO > > + interface still found on the M1. > > + items: > > + - const: apple,t8103-m3-mailbox > > Would be nice to document an example of where an M3 mailbox is found. Sure, I can add a comment that this is used for the coprocessor controlling Thunderbolt. > > > + interrupts: > > + minItems: 4 > > + items: > > + - description: send fifo is empty interrupt > > + - description: send fifo is not empty interrupt > > + - description: receive fifo is empty interrupt > > + - description: receive fifo is not empty interrupt > > + > > + interrupt-names: > > + minItems: 4 > > + items: > > + - const: send-empty > > + - const: send-not-empty > > + - const: recv-empty > > + - const: recv-not-empty > > If the names became not-constant the asprintf thing goes away, not sure > that's better or worse. I'm not sure I understand your comment here. This property just gives a name to the interrupts so that they can be referenced by that instead of a magic number between 0 and 4 in the driver. > > > + clocks: > > + description: > > + Reference to the clock gate phandle(s) if required for this mailbox. > > + Optional since not all mailboxes are attached to a clock gate. > > Do we do anything with the clocks at this point? > The device tree bindings describe the hardware (as best as we can without proper documentation) and some of these mailboxes have clock gates which need to be turned on before accessing their MMIO. This driver already tries to do that and works fine with the downstream clock driver(s) we have. Sven _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-07 20:26 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-07 14:54 [PATCH 0/3] Apple Mailbox Controller support Sven Peter 2021-09-07 14:54 ` Sven Peter 2021-09-07 14:54 ` [PATCH 1/3] mailbox: Add txdone_fifo Sven Peter 2021-09-07 14:54 ` Sven Peter 2021-09-07 14:55 ` [PATCH 2/3] dt-bindings: mailbox: Add Apple mailbox bindings Sven Peter 2021-09-07 14:55 ` Sven Peter 2021-09-07 18:56 ` Alyssa Rosenzweig 2021-09-07 18:56 ` Alyssa Rosenzweig 2021-09-07 20:26 ` Sven Peter [this message] 2021-09-07 20:26 ` Sven Peter 2021-09-07 20:48 ` Alyssa Rosenzweig 2021-09-07 20:48 ` Alyssa Rosenzweig 2021-09-08 15:36 ` Sven Peter 2021-09-08 15:36 ` Sven Peter 2021-09-11 13:16 ` Mark Kettenis 2021-09-11 13:16 ` Mark Kettenis 2021-09-07 14:55 ` [PATCH 3/3] mailbox: apple: Add driver for Apple mailboxes Sven Peter 2021-09-07 14:55 ` Sven Peter 2021-09-07 18:54 ` Alyssa Rosenzweig 2021-09-07 18:54 ` Alyssa Rosenzweig 2021-09-07 20:23 ` Sven Peter 2021-09-07 20:23 ` Sven Peter 2021-09-07 21:06 ` Alyssa Rosenzweig 2021-09-07 21:06 ` Alyssa Rosenzweig 2021-09-08 15:38 ` Sven Peter 2021-09-08 15:38 ` Sven Peter 2021-09-08 20:48 ` [PATCH 0/3] Apple Mailbox Controller support Jassi Brar 2021-09-08 20:48 ` Jassi Brar 2021-09-09 10:44 ` Sven Peter 2021-09-09 10:44 ` Sven Peter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ff66c30d-1b43-43d3-a4b0-02fe7d346118@www.fastmail.com \ --to=sven@svenpeter.dev \ --cc=alyssa@rosenzweig.io \ --cc=devicetree@vger.kernel.org \ --cc=jassisinghbrar@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=mark.kettenis@xs4all.nl \ --cc=mohamed.mediouni@caramail.com \ --cc=robh+dt@kernel.org \ --cc=stan@corellium.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.