[PATCH] testsuite/smokey: y2038: Fix evaluation of pthread_join result

[PATCH] testsuite/smokey: y2038: Fix evaluation of pthread_join result

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The status value is the pointer, not where the pointer points to.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Not yet resolving the unexpected assertion, though.

 testsuite/smokey/y2038/syscall-tests.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/smokey/y2038/syscall-tests.c b/testsuite/smokey/y2038/syscall-tests.c
index 90bfe28d48..afbe8d42a6 100644
--- a/testsuite/smokey/y2038/syscall-tests.c
+++ b/testsuite/smokey/y2038/syscall-tests.c
@@ -150,7 +150,7 @@ static int run_thread(void *(*thread)(void *), void *arg, int exp_result)
 	if (!__T(ret, pthread_join(tid, &status)))
 		return ret;
 
-	res = *((long *) status);
+	res = (long)status;
 
 	return (res == exp_result) ? 0 : ret;
 }
-- 
2.31.1

Re: [PATCH] testsuite/smokey: y2038: Fix evaluation of pthread_join result

[Bezdeka, Florian]

On Mon, 2021-08-09 at 09:15 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> The status value is the pointer, not where the pointer points to.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Not yet resolving the unexpected assertion, though.
> 
>  testsuite/smokey/y2038/syscall-tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testsuite/smokey/y2038/syscall-tests.c b/testsuite/smokey/y2038/syscall-tests.c
> index 90bfe28d48..afbe8d42a6 100644
> --- a/testsuite/smokey/y2038/syscall-tests.c
> +++ b/testsuite/smokey/y2038/syscall-tests.c
> @@ -150,7 +150,7 @@ static int run_thread(void *(*thread)(void *), void *arg, int exp_result)
>  	if (!__T(ret, pthread_join(tid, &status)))
>  		return ret;
>  
> -	res = *((long *) status);
> +	res = (long)status;

Had a look again. That's correct. Do you want me to integrate it into
the patch that introduced it? 

Thanks for fixing this up.
>  
>  	return (res == exp_result) ? 0 : ret;
>  }

Re: [PATCH] testsuite/smokey: y2038: Fix evaluation of pthread_join result

[Jan Kiszka]

On 09.08.21 09:52, Bezdeka, Florian (T RDA IOT SES-DE) wrote:
> On Mon, 2021-08-09 at 09:15 +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The status value is the pointer, not where the pointer points to.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Not yet resolving the unexpected assertion, though.
>>
>>  testsuite/smokey/y2038/syscall-tests.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/testsuite/smokey/y2038/syscall-tests.c b/testsuite/smokey/y2038/syscall-tests.c
>> index 90bfe28d48..afbe8d42a6 100644
>> --- a/testsuite/smokey/y2038/syscall-tests.c
>> +++ b/testsuite/smokey/y2038/syscall-tests.c
>> @@ -150,7 +150,7 @@ static int run_thread(void *(*thread)(void *), void *arg, int exp_result)
>>       if (!__T(ret, pthread_join(tid, &status)))
>>               return ret;
>>
>> -     res = *((long *) status);
>> +     res = (long)status;
> 
> Had a look again. That's correct. Do you want me to integrate it into
> the patch that introduced it?
> 
> Thanks for fixing this up.

Ah, it's not yet in master - I'll fold this in, need to rebase anyway.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux