* [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk
@ 2021-10-09 7:11 Gang Li
2021-10-10 21:45 ` Steven Rostedt
2021-10-11 7:54 ` Vlastimil Babka
0 siblings, 2 replies; 3+ messages in thread
From: Gang Li @ 2021-10-09 7:11 UTC (permalink / raw)
To: rostedt
Cc: mingo, akpm, vbabka, axelrasmussen, linux-kernel, linux-mm, Gang Li
Ftrace core will add "\n" automatically on print. "\n" in TP_printk
will create blank line, so remove it.
Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
---
include/trace/events/mmap_lock.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
index 0abff67b96f0..5f980c92e3e9 100644
--- a/include/trace/events/mmap_lock.h
+++ b/include/trace/events/mmap_lock.h
@@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
),
TP_printk(
- "mm=%p memcg_path=%s write=%s\n",
+ "mm=%p memcg_path=%s write=%s",
__entry->mm,
__get_str(memcg_path),
__entry->write ? "true" : "false"
@@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
),
TP_printk(
- "mm=%p memcg_path=%s write=%s success=%s\n",
+ "mm=%p memcg_path=%s write=%s success=%s",
__entry->mm,
__get_str(memcg_path),
__entry->write ? "true" : "false",
@@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
),
TP_printk(
- "mm=%p memcg_path=%s write=%s\n",
+ "mm=%p memcg_path=%s write=%s",
__entry->mm,
__get_str(memcg_path),
__entry->write ? "true" : "false"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk
2021-10-09 7:11 [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
@ 2021-10-10 21:45 ` Steven Rostedt
2021-10-11 7:54 ` Vlastimil Babka
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2021-10-10 21:45 UTC (permalink / raw)
To: Gang Li; +Cc: mingo, akpm, vbabka, axelrasmussen, linux-kernel, linux-mm
On Sat, 9 Oct 2021 15:11:05 +0800
Gang Li <ligang.bdlg@bytedance.com> wrote:
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
Yes, thank you!
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> include/trace/events/mmap_lock.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s success=%s\n",
> + "mm=%p memcg_path=%s write=%s success=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk
2021-10-09 7:11 [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
2021-10-10 21:45 ` Steven Rostedt
@ 2021-10-11 7:54 ` Vlastimil Babka
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2021-10-11 7:54 UTC (permalink / raw)
To: Gang Li, rostedt; +Cc: mingo, akpm, axelrasmussen, linux-kernel, linux-mm
On 10/9/21 09:11, Gang Li wrote:
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/trace/events/mmap_lock.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s success=%s\n",
> + "mm=%p memcg_path=%s write=%s success=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-11 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-09 7:11 [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
2021-10-10 21:45 ` Steven Rostedt
2021-10-11 7:54 ` Vlastimil Babka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.