From: Simon Horman <horms+renesas@verge.net.au> To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] clocksource: sh_mtu2: Document r7s72100 binding Date: Tue, 09 Sep 2014 02:40:11 +0000 [thread overview] Message-ID: <ffd24a543afe4c693d5c611ecfa01cc48e97f97d.1410230283.git.horms+renesas@verge.net.au> (raw) In-Reply-To: <cover.1410230283.git.horms+renesas@verge.net.au> In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- * I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC. v2 * Suggestions by Mark Rutland and Sergei Shtylyov - Compatible strings should be "one or more" not "one" of those listed - Describe the generic binding as covering any MTU2 device - Re-order compat strings from most to least specific v3 * Suggested by Laurent Pinchart - Reword compat documentation for consistency with a more extensive CMT change --- Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt index 917453f..d9a8d5a 100644 --- a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt +++ b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt @@ -8,7 +8,10 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4. Required Properties: - - compatible: must contain "renesas,mtu2" + - compatible: must be one or more of the following: + - "renesas,mtu2-r7s72100" for the r7s72100 MTU2 + - "renesas,mtu2" for any MTU2 + This is a fallback for the above renesas,mtu2-* entries - reg: base address and length of the registers block for the timer module. @@ -26,7 +29,7 @@ Required Properties: Example: R7S72100 (RZ/A1H) MTU2 node mtu2: timer@fcff0000 { - compatible = "renesas,mtu2"; + compatible = "renesas,mtu2-r7s72100", "renesas,mtu2"; reg = <0xfcff0000 0x400>; interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>, <0 146 IRQ_TYPE_LEVEL_HIGH>, -- 2.0.1
WARNING: multiple messages have this Message-ID (diff)
From: horms+renesas@verge.net.au (Simon Horman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] clocksource: sh_mtu2: Document r7s72100 binding Date: Tue, 9 Sep 2014 11:40:11 +0900 [thread overview] Message-ID: <ffd24a543afe4c693d5c611ecfa01cc48e97f97d.1410230283.git.horms+renesas@verge.net.au> (raw) In-Reply-To: <cover.1410230283.git.horms+renesas@verge.net.au> In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- * I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC. v2 * Suggestions by Mark Rutland and Sergei Shtylyov - Compatible strings should be "one or more" not "one" of those listed - Describe the generic binding as covering any MTU2 device - Re-order compat strings from most to least specific v3 * Suggested by Laurent Pinchart - Reword compat documentation for consistency with a more extensive CMT change --- Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt index 917453f..d9a8d5a 100644 --- a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt +++ b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt @@ -8,7 +8,10 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4. Required Properties: - - compatible: must contain "renesas,mtu2" + - compatible: must be one or more of the following: + - "renesas,mtu2-r7s72100" for the r7s72100 MTU2 + - "renesas,mtu2" for any MTU2 + This is a fallback for the above renesas,mtu2-* entries - reg: base address and length of the registers block for the timer module. @@ -26,7 +29,7 @@ Required Properties: Example: R7S72100 (RZ/A1H) MTU2 node mtu2: timer at fcff0000 { - compatible = "renesas,mtu2"; + compatible = "renesas,mtu2-r7s72100", "renesas,mtu2"; reg = <0xfcff0000 0x400>; interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>, <0 146 IRQ_TYPE_LEVEL_HIGH>, -- 2.0.1
next prev parent reply other threads:[~2014-09-09 2:40 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-08 9:01 [GIT PULL] Renesas ARM based SoC clocksource updates for v3.13 Simon Horman 2013-10-08 9:01 ` Simon Horman 2013-10-08 9:01 ` [PATCH] clocksource: em_sti: convert to clk_prepare/unprepare Simon Horman 2013-10-08 9:01 ` Simon Horman 2013-10-08 11:24 ` Daniel Lezcano 2013-10-08 11:24 ` Daniel Lezcano 2013-12-14 6:07 ` [GIT PULL] Renesas ARM based SoC Clocksource updates for v3.14 Simon Horman 2013-12-14 6:07 ` Simon Horman 2013-12-14 6:07 ` [PATCH] clocksource: sh_cmt: Add clk_prepare/unprepare support Simon Horman 2013-12-14 6:07 ` Simon Horman 2013-12-14 6:07 ` Simon Horman 2013-12-18 1:08 ` [GIT PULL] Renesas ARM based SoC Clocksource updates for v3.14 Simon Horman 2013-12-18 1:08 ` Simon Horman 2013-12-18 8:21 ` Daniel Lezcano 2013-12-18 8:21 ` Daniel Lezcano 2013-12-18 14:28 ` Daniel Lezcano 2013-12-18 14:28 ` Daniel Lezcano 2013-12-19 0:07 ` Simon Horman 2013-12-19 0:07 ` Simon Horman 2014-09-09 2:40 ` [GIT PULL] Renesas ARM Based SoC Clocksource Updates for v3.18 Simon Horman 2014-09-09 2:40 ` Simon Horman 2014-09-09 2:40 ` [PATCH 1/3] clocksource: sh_cmt: Document SoC specific bindings Simon Horman 2014-09-09 2:40 ` Simon Horman 2014-09-09 2:40 ` Simon Horman [this message] 2014-09-09 2:40 ` [PATCH 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman 2014-09-09 2:40 ` [PATCH 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman 2014-09-09 2:40 ` Simon Horman 2014-08-27 4:59 [PATCH 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman 2014-08-27 4:59 ` [PATCH 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman 2014-08-27 4:59 ` Simon Horman 2014-08-27 11:09 ` Sergei Shtylyov 2014-08-27 11:09 ` Sergei Shtylyov 2014-09-03 1:03 ` Simon Horman 2014-09-03 1:03 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ffd24a543afe4c693d5c611ecfa01cc48e97f97d.1410230283.git.horms+renesas@verge.net.au \ --to=horms+renesas@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.