* [PATCH] nvme-core: remove unnecessary semicolon
@ 2022-01-19 7:49 Chaitanya Kulkarni
2022-01-19 11:24 ` Sagi Grimberg
2022-01-26 16:17 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-01-19 7:49 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, kbusch, sagi, Chaitanya Kulkarni
From: Chaitanya Kulkarni <kch@nvidia.com>
It is not a good practice to have a semicolon at the end of the
function definition. Remove it from nvme_pr_type().
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 4fc794d9c2f4..1759538b36fc 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1967,7 +1967,7 @@ static char nvme_pr_type(enum pr_type type)
default:
return 0;
}
-};
+}
static int nvme_send_ns_head_pr_command(struct block_device *bdev,
struct nvme_command *c, u8 data[16])
--
2.29.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-core: remove unnecessary semicolon
2022-01-19 7:49 [PATCH] nvme-core: remove unnecessary semicolon Chaitanya Kulkarni
@ 2022-01-19 11:24 ` Sagi Grimberg
2022-01-26 16:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2022-01-19 11:24 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme; +Cc: hch, kbusch, Chaitanya Kulkarni
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-core: remove unnecessary semicolon
2022-01-19 7:49 [PATCH] nvme-core: remove unnecessary semicolon Chaitanya Kulkarni
2022-01-19 11:24 ` Sagi Grimberg
@ 2022-01-26 16:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-01-26 16:17 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-nvme, hch, kbusch, sagi, Chaitanya Kulkarni
Thanks,
applied to nvme-5.17.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-26 17:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 7:49 [PATCH] nvme-core: remove unnecessary semicolon Chaitanya Kulkarni
2022-01-19 11:24 ` Sagi Grimberg
2022-01-26 16:17 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.